Commit graph

27454 commits

Author SHA1 Message Date
Abhijeet Kasurde
eed7a338a0 aws: Fix typo in deprecation warning (#57946)
Changed "ec2_instance_information" to "ec2_instance_info" in deprecation warning.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 16:32:00 -04:00
Alex Stephen
9364b4c933 better metadata formatting on gcp_compute (#57778) 2019-06-17 16:10:27 -04:00
Fred-sun
6e89fbe58a Update azure_rm_networkinterface related document (#57454)
* Update azure_rm_networkinterface related document
* fixes errors with plural nouns, typos, uses single quotes for version_added
2019-06-17 14:38:57 -05:00
ShachafGoldstein
66728cb93f win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test
2019-06-18 05:25:38 +10:00
ShachafGoldstein
acc01f1109 Win_copy: doc fix when using become (#57690)
* win_copy: doc update

* Community review
2019-06-17 13:55:29 -05:00
The Magician
7751e97e1e Bug fixes for GCP modules (#57883) 2019-06-17 13:40:04 -04:00
Paul Belanger
fa738613dc
Revert "Fix iosxr discard_changes netconf rpc issue (#57931)" (#57954)
This actually broken junos netconf_rpc, and was merged without properly
testing.

This reverts commit 795cb90367.
2019-06-17 11:45:30 -04:00
Paul Belanger
d40c44bd56 Fix python3 encoding with iosxr_config (#57919)
Python3 requires bytes when writing files.

Depends-On: https://github.com/ansible/ansible/pull/57909/
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 17:42:29 +02:00
Ganesh Nalawade
4a3e14f90b More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test
2019-06-17 17:22:46 +02:00
Ganesh Nalawade
795cb90367
Fix iosxr discard_changes netconf rpc issue (#57931)
* If dispatch() rpc response has data element
return the xml string from <data> element
else return the complete xml string from
<rpc-reply>.

Depends-On: #57909
Depends-On: #57919
2019-06-17 16:22:23 +05:30
Abhijeet Kasurde
cf623fa62f
Terraform: Fix unbound local error (#57044)
* Added Unit tests
* Fixed regression

Fixes: #56934

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 08:23:59 +05:30
Ruben Tsirunyan
9e225fbb1e zabbix: New module zabbix mediatype (#57488)
Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-06-16 23:16:58 +02:00
Jordan Borean
d0c4914469
win_shell - fix space escaping for custom executable (#57455) 2019-06-17 05:14:58 +10:00
Simon Dodsley
0f2903780b purestorage: Add module to set MOTD banner text for Pure Storage FlashArray (#57500) 2019-06-16 09:43:51 +02:00
Abhijeet Kasurde
6b16be638d
VMware: add facts about tags in vmware_host_facts (#56837)
Fixes: #46461

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-16 09:02:26 +05:30
Sergey
7910361b52 Fix failed mounts in podman connector and handle errors (#57741)
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.
2019-06-15 07:35:55 -04:00
Fred-sun
019a48361b Update azure_rm_resourcegroup related document (#57819)
* Update azure_rm_resourcegroup related document

* resolve shippable error
2019-06-14 15:34:20 -04:00
Fred-sun
23eb465956 Update azure_rm_roleassignment related document (#57820)
* Update azure_rm_roleassignment related document

* add new
2019-06-14 15:27:06 -04:00
Brian Coca
342d77b32d
removal of chdir in controller (#57781)
* removal of chdir in controller

also ensure fetch/put uses relative to task cwd
2019-06-14 13:45:41 -04:00
Brian Coca
de87b25a45
show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422
2019-06-14 13:40:22 -04:00
Martin Krizek
e9c83b7a17 gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248
2019-06-14 12:55:22 -04:00
Fred-sun
8d635a82a4 Update azure_rm_publicipaddress related document (#57669)
* Update azure_rm_publicipaddress related document
2019-06-14 10:43:06 -04:00
Fred-sun
aeb72dfb06 Update azure_rm_resource related document (#57786)
* Update azure_rm_resource related document

* resolve shippable check error

* Resolve format error

* resolve format error---02

* Redefine the type variable
2019-06-14 10:13:32 -04:00
Fred-sun
1903aced79 Update azure_rm_rediscache related document (#57721)
* Update azure_rm_rediscache related document

* Update according by comment
2019-06-14 10:06:18 -04:00
Paul Belanger
88a1fc28d8 Clean up iosxr get_config_diff function (#57589)
This fixes an index error issue when running tests on zuul.ansible.com
for iosxr. We can fix this by getting the last element in the list.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-14 15:06:21 +05:30
Jagadeesh N V
6e8fcbf8c9 Adding idrac_pwd alias to modules (#57733) 2019-06-14 01:43:21 -04:00
Sander Steffann
71a704cc14 netbox: inventory: fix implementation of groups option (#57689) 2019-06-14 06:29:46 +02:00
bobdoah
33d0d36eaa AWS: Fix KeyError in aws_secret lookup (#54792) 2019-06-13 17:11:44 -07:00
Skybound1
e7bf46d8bc Adds visibility parameter to gitlab group creation (#57024) 2019-06-13 18:40:14 -04:00
The Magician
138f0e875a Bug fixes for GCP modules (#57724) 2019-06-13 18:25:57 -04:00
The Magician
a58088f661 Bug fixes for GCP modules (#57725) 2019-06-13 18:25:46 -04:00
The Magician
366a9784ac Bug fixes for GCP modules (#57727) 2019-06-13 18:25:23 -04:00
The Magician
ab0a548b0c Bug fixes for GCP modules (#57728) 2019-06-13 18:25:11 -04:00
The Magician
625ef22dd9 New Module: gcp_tpu_node (#57729) 2019-06-13 18:25:00 -04:00
Martin Krizek
61ff61cdf6 Tests as filters were deprecated, remove unused param (#57796) 2019-06-13 15:36:52 -04:00
The Magician
1d6d19f400 New Module: gcp_tpu_node_facts (#57730) 2019-06-13 15:11:46 -04:00
Kevin Breit
a85750dc98 Meraki - Convert response keys to snake_case from camelCase (#53891)
* Initial proposal for new parameter option for response format
- output_version parameter dictates the response key case
- new is snake_case, old is camelCase
- If new, conversion is done at the end of module execution
- This is purely a proposal and not a final draft

* Add support for ANSIBLE_MERAKI_FORMAT env var
- If env var is set to 'camelcase' it will output camelcase
- Otherwise, will default to snakecase
- Added note to documentation fragment
- As of now, all module documentation needs to be updated

* Fix pep8 errors and remove output_version args

* Restructure check in exit_json so it actually works

* Add changelog fragment

* Change output_format to a parameter with env var fallback
- ANSIBLE_MERAKI_FORMAT is the valid env var
- Added documentation

* Convert to camel_dict_to_snake_dict() which is from Ansible
- Fixed integration tests

* Fix yaml lint error

* exit_json camel_case conversion handles no data
- exit_json would fail if data wasn't provided
- Updated 3 integration tests for new naming convention

* convert_camel_to_snake() handles lists and dicts
- The native Ansible method doesn't handle first level lists
- convert_camel_to_snake() acts simply as a wrapper for the method
- There maybe a situation where nested lists are a problem, must test
- Fixed integration tests in some modules

* A few integration test fixes

* Convert response documentation to snake case
2019-06-13 15:07:30 -04:00
jarekgajewski
e264b4126f Update gcp_storage_object.py (#57802)
"name: ansible-storage-module" removed as name is not defined as parameter  


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-13 13:16:07 -04:00
Harald Albers
231f4cfcf1 Fix example in vmware_drs_group module (#57805)
Signed-off-by: Harald Albers <github@albersweb.de>
2019-06-13 13:12:59 -04:00
Adam Miller
d2dc4c9bc4 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-06-13 11:17:23 -04:00
Arnaud RENARD
1a5fd720a4 Ansible galaxy role download should not have to perform aditionnal check against tar archive file extension #56616. (#56617)
Ansible galaxy role download checked for `.tar.gz`, but `tarfile.is_tarfile(...)` can identify and open any valid tarfile. This change uses transparent stream compression to make `.tar.gz` and `.tar.bz2` formats valid with python 2.6.x/2.7.x (as well as `.tar.xz` with python 3.x).
2019-06-13 09:23:41 -05:00
Dmitry Tantsur
d33ee72085 os_ironic_node: avoid set_node_instance_info and purge_node_instance_info (#54463)
These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.
2019-06-13 09:08:24 -04:00
Ondra Machacek
886f4c66ca kubevirt: Add affinity parameters (#57359) 2019-06-13 12:25:30 +02:00
Martin Nečas
f7de9cb39f ovirt host facts fix (#57790) 2019-06-13 06:12:54 -04:00
Mariusz Mazur
51add5aa79 kubevirt: enable/update tests + fix merge_dicts() (#57685)
* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code
2019-06-13 11:07:16 +02:00
Abhijeet Kasurde
00604d3f2c
VMware: Fix vmware_guest_move undefined VM name error (#57582)
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-13 13:07:26 +05:30
René Moser
5143f52def
vultr: vultr_ssh_key_facts -> info (#57571)
* vultr: deprecate vultr_ssh_key_facts

* vultr: rename tests

* vultr: adjust tests

* vultr: new vultr_ssh_key_info module

* vultr: test: vultr_ssh_key_info: improve tests

* update docs
2019-06-13 07:05:00 +02:00
Strahinja Kustudic
8e9f29c40c Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables
2019-06-12 17:36:57 -04:00
Brian Coca
73a16749cb
Enable adjacent collections for ansible-doc (#57764)
* enable adjacent collections for ansible-doc
2019-06-12 17:10:17 -04:00
LucasBoisserie
1d76635206 Remove required field on service_account_file in gcp_compute plugin inventory (#57345) 2019-06-12 16:51:57 -04:00