Commit graph

8261 commits

Author SHA1 Message Date
Kamil Szczygieł
01a15f8a0b VMware datacenter module shouldn't hold pyvmomi context in Ansible module object (#1568)
* VMware datacenter module rewritten to don't hold pyvmomi context and objects in Ansible module object

fixed exceptions handling

added datacenter destroy result, moved checks

changed wrong value

wrong value again... need some sleep

* check_mode fixes

* state defaults to present, default changed to true

* module check fixes
2016-04-12 11:11:33 +02:00
Michael Scherer
2dbfdaa88b Remove dead code (#1303)
The review on https://github.com/ansible/ansible-modules-extras/pull/1303
show the problem was already fixed, so we just need to remove the
code.
2016-04-12 08:13:24 +02:00
stoned
6785f3b424 cpanm: search both its stderr and its stdout for the message 'is up t…
Note that since cpanm version 1.6926 its messages are sent to stdout
when previously they were sent to stderr.

Also there is no need to initialize out_cpanm and err_cpanm and
check for their truthiness as module.run_command() and str.find()
take care of that.
2016-04-12 07:21:28 +02:00
Evgeni Golov
98514ace6e do not set LXC default config
this was accidentally re-introduced in 7120fb4b

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-04-12 07:17:12 +02:00
p53
0c1b2b85cd Merge pull request #2 from p53/Issue#2008
Fixes #2008 Lvol module is not indempodent for cache lv's
2016-04-11 21:57:43 +02:00
Pavol Ipoth
7be55e188a Fixes #2008 Lvol module is not indempodent for cache lv's 2016-04-11 21:55:40 +02:00
David Shrewsbury
fa4769f708 Merge pull request #1970 from rcarrillocruz/os_user_facts
Add os_user_facts module
2016-04-11 15:43:57 -04:00
David Shrewsbury
22720d649c Merge pull request #1969 from rcarrillocruz/os_domain_facts
Add os_keystone_domain_facts module
2016-04-11 15:39:41 -04:00
p53
ad12773056 Merge pull request #1 from p53/Issue#2003
Fixes #2003 Added pvs parameter to lvol module
2016-04-11 20:22:38 +02:00
Pavol Ipoth
ac9a48ad1e Added pvs parameter to lvol module 2016-04-11 20:18:14 +02:00
Rene Moser
1d0df46475 cloudstack: cs_template: fix state=extracted
* url arg is optional but we enforced it
* url is in a required together, but args only relevant while registering
2016-04-11 20:02:03 +02:00
Rene Moser
0b9c8213ad cloudstack: fix doc, display_text not required 2016-04-11 20:01:36 +02:00
Rene Moser
2d78c23dc0 cloudstack: cs_template: fix cross_zones template removal 2016-04-11 20:01:27 +02:00
Matt Hite
c58f5d2137 Fixes issue #1992 -- fixes issue adding and deleting pools (#1994) 2016-04-11 19:57:55 +02:00
Michael Scherer
5e15cc887b Auth_toekn is a secret, shouldn't be logged (#1999) 2016-04-11 11:35:14 -04:00
Joerg Fiedler
44bfca315a add chroot flag to pkgng in order to allow installation of packages into chroot environments, e.g. jails (#1218) 2016-04-11 08:25:30 +02:00
Him You Ten
f99576749a added stdout and stderr outputs (#1900)
* added stdout and stderr outputs

Added stdout and stderr outputs of the results from composer as the current msg output strips \n so very hard to read when debugging

* using stdout for fail_json

using stdout for fail_json so we get the stdout_lines array
2016-04-11 08:21:15 +02:00
Matt Hite
0405c54dba New preserve_node parameter to skip unreferenced node removal 2016-04-11 08:00:30 +02:00
kubilus1
773d402eac Unchecked index causes IndexError. 2016-04-11 07:55:07 +02:00
René Moser
542a96f907 Merge pull request #1827 from jasperla/pkgin_update_cache
support for 'update_cache' in pkgin module
2016-04-10 22:49:31 +02:00
René Moser
31de43d306 Merge pull request #1952 from mscherer/fix_cloudstack
Do not leak passwords in case of error in cloudstack modules
2016-04-10 18:24:26 +02:00
Monty Taylor
38c8fec277 Merge pull request #1149 from Jmainguy/puppet_stdout
Enable stdout and stderr on sucessful runs, making show_diff useable
2016-04-10 08:43:39 -07:00
Evgeni Golov
8db3a63983 fix handling of config options that share the same prefix
container_config:
      - "lxc.network.ipv4.gateway=auto"
      - "lxc.network.ipv4=192.0.2.1"

might try to override lxc.network.ipv4.gateway in the second entry as both
start with "lxc.network.ipv4".
use a regular expression to find a line that contains (optional) whitespace
and an = after the key.

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-04-10 13:37:00 +02:00
Evgeni Golov
c03e77a63a strip whitespace from key and value before inserting it into the config
before the following would produce four entries:

    container_config:
      - "lxc.network.flags=up"
      - "lxc.network.flags =up"
      - "lxc.network.flags= up"
      - "lxc.network.flags = up"

let's strip the whitespace and insert only one "lxc.network.flags = up"
into the final config

Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-04-10 13:33:48 +02:00
René Moser
474baaa831 Merge pull request #1981 from macdiesel/macdiesel/urlencode-hipchat-api-path
Escape room name in hipchat api v2 urls
2016-04-10 11:57:01 +02:00
René Moser
fc79c8820e Merge pull request #1971 from insom/devel
Add `to_destination` parameter to iptables
2016-04-10 11:18:49 +02:00
Vlad Gusev
f1175693f6 system/puppet: add --tags parameter (#1916)
* system/puppet: add --tags parameter

--tags [1] is used to apply a part of the node’s catalog.

In puppet:
puppet agent --tags update,monitoring

In ansible:
puppet: tags=update,monitoring

[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#restricting-catalog-runs

* Add example of tag usage.

* system/puppet: add list type for a tags dict.
2016-04-10 11:14:48 +02:00
Michael Scherer
197ee8bef4 Client_secret is supposed to be kept secret, so mark it as no_log (#1995) 2016-04-09 23:33:11 -07:00
Ricardo Carrillo Cruz
34045fddb1 Add os_user_facts module
This module gather facts about one or more OpenStack users
2016-04-09 11:43:40 +00:00
Ricardo Carrillo Cruz
d914b3fa84 Add os_keystone_domain_facts module
This module gathers one or more OpenStack domains facts
2016-04-09 11:25:06 +00:00
nitzmahone
5abb914315 win_updates fix to use documented InstanceGuid property name 2016-04-07 17:38:38 -07:00
nitzmahone
93db039783 win_updates shouldn't install hidden updates 2016-04-07 17:38:37 -07:00
=
8192ad24d5 adding the ability to manage binary registry data 2016-04-07 18:22:23 +01:00
Michael Scherer
bc198cc33a Avoid token leak by marking it as sensitive with no_log (#1966) 2016-04-07 12:47:57 -04:00
Michael Scherer
7120fb4b01 Properly label path argument with type='path' (#1940) 2016-04-07 11:25:04 -04:00
Michael Scherer
3385bf5ef2 Do not leak mail password by error 2016-04-07 08:59:11 -04:00
Michael Scherer
c215bff12e Mark password as 'no_log', to avoid leaking it 2016-04-07 08:58:15 -04:00
Brian Beggs
ed35159702 hipchat api v2 rooms are now url escaped 2016-04-06 17:07:03 -04:00
Rob
84f2aa6167 Updated Amazon module guidelines regarding boto3
* Updated Amazon module guidelines regarding boto3

* Spelling correction
2016-04-06 09:37:52 -04:00
Aaron Brady
e2138c7e14 Add to_destination parameter 2016-04-06 11:30:59 +01:00
Andy Baker
204b4bab56 type should be 'list' not the default of 'string' 2016-04-04 14:18:00 -04:00
Evgeni Golov
6bfd2846f8 don't create world-readable archives of LXC containers
with the default umask tar will create a world-readable archive of the

container, which may contain sensitive data



Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-04-04 11:28:22 -04:00
Michael Scherer
719b9b229b Prevent password leaks in notification/irc 2016-04-04 09:31:12 -04:00
Michael Scherer
95e07d2f51 Use no_log=True for campfire module to avoid leaks 2016-04-04 09:18:34 -04:00
Michael Scherer
b5333ba08c Set no log for jabber.py password 2016-04-04 09:14:56 -04:00
Michael Scherer
5696e6c33a Do not leak passwords in case of error in cloudstack modules 2016-04-03 10:34:10 +02:00
Evgeni Golov
7c3999a92a do not use a predictable filenames in the LXC plugin
* do not use a predictable filename for the LXC attach script

* don't use predictable filenames for LXC attach script logging

* don't set a predictable archive_path



this should prevent symlink attacks which could result in

* data corruption

* data leakage

* privilege escalation
2016-04-02 01:20:42 -07:00
René Moser
f710908574 Merge pull request #1915 from mscherer/fix_cpanm
Add proper type to cpanm arguments
2016-04-02 08:48:50 +02:00
Chulki Lee
f3c168594a osx_defaults: fix datetime
Fix #1742
2016-04-01 20:45:33 -04:00
Matt Martz
154afa7dc1 Merge pull request #1943 from sivel/rebase-prs
Rebase PRs against $TRAVIS_BRANCH before performing tests
2016-04-01 14:15:12 -05:00