Commit graph

40936 commits

Author SHA1 Message Date
jerrejkw
44044f969d VMware: Add timeout parameter for vmware module vsphere_copy (#46762)
* Enhancement: add timeout parameter for vmware module vsphere_copy
2018-10-18 15:07:39 +05:30
Pierre-Louis Bonicoli
92103bf5d0 test-module: define ansible_version attribute
Executed command:

    ./hacking/test-module -m lib/ansible/modules/cloud/scaleway/scaleway_security_group.py -a ...

Fix this exception found while testing scaleway_security_group module:

    Traceback (most recent call last):
      File "~/debug_dir/__main__.py", line 240, in <module>
        main()
      File "~/debug_dir/__main__.py", line 236, in main
        core(module)
      File "~/debug_dir/__main__.py", line 209, in core
        api = Scaleway(module=module)
      File "~/debug_dir/ansible/module_utils/scaleway.py", line 58, in __init__
        'User-Agent': self.get_user_agent_string(module),
      File "~/debug_dir/ansible/module_utils/scaleway.py", line 99, in get_user_agent_string
        return "ansible %s Python %s" % (module.ansible_version, sys.version.split(' ')[0])
    AttributeError: 'AnsibleModule' object has no attribute 'ansible_version'
2018-10-18 09:45:56 +02:00
Pierre-Louis Bonicoli
7231f7da84 test-module: check availability of special attrs 2018-10-18 09:45:56 +02:00
Jordan Borean
5d2927c9a0
test: filesystem update note on test comment (#47260) 2018-10-18 17:10:16 +10:00
Nicolas Bock
b3dd36bef8 Fix documentation (#47218)
The result variable is `openstack_image` and not `openstack` as incorrectly stated in the description.

+label: docsite_pr
2018-10-18 17:00:08 +10:00
Matt Martz
90d2620939 Remove deprecated os_server_actions alias (#47208)
* Remove deprecated os_server_actions alias. Fixes #44991

* Skip os_server_actions
2018-10-18 16:44:44 +10:00
Jonathan Davila
d3be4f75ca pamd: use module.tmpdir for NamedTemporaryFile() (#47133) 2018-10-18 16:09:07 +10:00
Shuang Wang
0c6513e9b1 add module aws_codecommit to represent AWS CodeCommit (#46161)
* kick off

* done for the day

* beta code and test

* fix a typo

* boto3_conn and boto_exception aren't used in this code, ec2_argument_spec is used but unneeded.

* Returning when find a match avoids doing extra work, especially when pagination is involved

* add new permissions for test

* (output is changed) is preferred over accessing the attribute directly.

* pass the result through camel_dict_to_snake_dict() before returning it.

* AnsibleAWSModule automatically merges the argument_spec.

* deletes the created resources even if a test fails.

* AnsibleAWSModule automatically merges the argument_spec.

* fix typo

* fix pep8

* paginate list_repositories

* specify permissions for test

* cut the unnecessary code.

* add return doc string

* add missed ':'

* fix syntax error: mapping values are not allowed here

* add description for return

* fix syntax error

* rename module name and turn off automated integration test.
2018-10-18 14:32:06 +10:00
Yuwei Zhou
9258ffa478 Fix auto scale create with fix date without recurrence (#47186)
* Fix auto scale create with fix date without  recurrence

* fix indent
2018-10-18 10:52:30 +08:00
Michael Scherer
1be69cd69c Clean up of docker swarm service (#45525)
* Remove redundant assignation of variable

Found with https://lgtm.com/

* Fix check_mode when force_update is used
2018-10-17 17:29:47 -04:00
Stanislas
9cc9ca584a Implement snap packaging module
PR #44939

Fixes #39155
Closes #40852

Co-authored-by: Victor Carceler <vcarceler@iespuigcastellar.xeill.net>
Co-authored-by: Stanislas Lange <angristan@pm.me>
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
2018-10-17 22:59:41 +02:00
Loïc
a661b5f825 Add unsafe_perm flag (#36946) 2018-10-17 21:35:51 +01:00
nikkytub
539f0fee09 Fixed the ssl-certs in netbox plugin (#46543)
* Fixed the ssl-certs in netbox plugin

* Added validate_certs parameter and updated the example
2018-10-17 21:30:47 +01:00
Rémy Léone
8a7a819040 Add support for platform grouping (#45733) 2018-10-17 21:28:20 +01:00
Jordan Borean
ae5aeb9a67
filesystem: fix test to work on newer Fedora (#47176) 2018-10-18 05:36:37 +10:00
Jordan Borean
6666b070a9
openss: fix various test and Python 3 issues (#47188) 2018-10-18 05:29:18 +10:00
Matt Clay
1947d903cd Mark azure_rm_{appserviceplan,webapp} unstable. 2018-10-17 11:36:12 -07:00
maxstack
c11aba6ed8 [aws] New key_data argument to ec2_win_password module (#45463)
* add key_data argument

The key_data argument helps when using a private key stored in Vault.

* Add "version_added" line

Add version_added line to pass automated tests.

* remove unnecessary nesting
2018-10-17 14:01:59 -04:00
Dani Hodovic
28ba10b877 fix: Parse docker_service scale parameter to int (#45508) 2018-10-17 13:58:09 -04:00
Aaron
9c08ff7a94 [aws] New module: iam_password_policy (#36200)
* Adding iam_password_policy module

* fixing various issues -- error handling, bugs

* fixing various issues based on tests

* renaming dummy var

* fixing type reference in documentation

* adding int tests and other updates

* removing typo

* fixing auth for int tests

* removing int tests for now

* readding integration tests w/ unsupported designation

* removing conflicting group

* Update aliases

* Fix unused variable
2018-10-17 13:56:13 -04:00
Jeffrey Noehren
e685027fb8 spotinst_aws_elastigroup module: adding version to Rancher integration (#46293)
* [src] - adding version to spotinst rancher integration

* [src] - adding sdk version to docs
2018-10-17 13:45:02 -04:00
Sloane Hertel
b808e1bc5c [s3_bucket] Cast tag keys and values to text to match the values returned (#46405)
* Cast tag keys and values to text to match the values returned

* changelog
2018-10-17 13:39:52 -04:00
Chas Schley
7fd31b1da0 [docs] Include required ARN format of actions in ec2_metric_alarm (#46514)
<!--- Your description here -->

+label: docsite_pr
2018-10-17 13:39:03 -04:00
Petr Ruzicka
df57a3fc7a [aws][docs] Replace uses of now-obsolete with_items with loop (#47164) 2018-10-17 12:35:31 -04:00
Brian Scholer
2043aad582 [aws] ec2_instance: don't report changed when instance is already stopped (#46714) 2018-10-17 12:34:37 -04:00
Per-Henrik Lundblom
e744c83808 [aws] ec2_vol_facts: only access volume tags when set (#46801) 2018-10-17 12:31:31 -04:00
David González
b923bf708d [aws] Convert containerPort to int before comparing to avoid jinja2 string-int issues (#39215) (#47195) 2018-10-17 12:29:23 -04:00
Brian Coca
fce9673ac1 Adoc fixes (#47137)
* removed hardcoded loader/plugins list
* updated a few errors to keep orig object
* fix httpapi/cliconf listing
* ansible-doc fixes
* show undocumented as UNDOCUMENTEd
* added missing undoc
2018-10-17 10:48:24 -05:00
Luke Short
9cf407f683 Gentoo installation no longer requires a workaround. (#47151)
The default Python version has been 3.6
since June 2018 and was 3.5 before then.
Ansible supports Python 3.5 and above.
2018-10-17 10:23:23 -05:00
Steve Dodd
ee6ab5d5aa Add support for IOS vlan parsing filter. (#40555)
* Add support for IOS vlan parsing filter.
Example usage below:

{% set parsed_vlans = vlans | vlan_parser %}
switchport trunk allowed vlan {{ parsed_vlans[0] }}
{% for i in range (1, parsed_vlans | count) %}
switchport trunk allowed vlan add {{ parsed_vlans[i] }}

* Update test_network.py

Add import statement for filter

* Fixed PEP8 issues relating to comments

* Fix PEP8 issues related to blank lines

* Removed magic numbers for line lengths. This should generalize support
to other IOS-like NOS that use similar methods for listing vlans. The
default arguments for line lengths will still be specific to Cisco IOS.
The unit tests for line length are still specific to Cisco IOS.
2018-10-17 20:50:28 +05:30
Toshio Kuratomi
61ae6424a3 An earlier optimization of ansible-doc -l caused failures. (#47012)
* An earlier optimization of ansible-doc -l caused failures.

The optimization quickly searches the plugin code for short_description
fields and then uses that in the -l output.  The searching was a bit too
naive and ended up pulling out malformed yaml.  This caused those
plugins to be omitted from the list of plugins of that type with
a warning that their documentation strings were wrong.

This change makes the documentation parser aware that the documentation
string could have a relative indent for all of its fields which makes it
robust in the face of this particular problem.

* Don't search for space after short_description:

Any whitespace would be valid.  In particular newline
2018-10-17 11:15:59 -04:00
Jon Stevens
0272fd4b37 docs: Fix restructuredtext link format (#47199)
Fix two links on guide_online.rst
2018-10-17 09:28:48 -05:00
Ryan Merolle
b9cf09e9d5 network.py filter_plugin typo fix (#47011)
changed return_orginal to return_original in /lib/ansible/plugins/filter/network.py
2018-10-17 19:30:56 +05:30
Fran Fitzpatrick
fc341e01fa Fix junos terminal regex (#47096)
Fix junos stdout regex

Change at hing
2018-10-17 19:29:35 +05:30
Jordan Borean
dd46f953f6
postgresql_user: fix test errors on newer Fedora versions (#47166) 2018-10-17 14:01:11 +10:00
Jordan Borean
f720499337
gem: fix tests to work on newer Fedora hosts (#47158) 2018-10-17 10:43:30 +10:00
Matt Clay
d048785640 Update requirements for urllib3 for python 2.6. 2018-10-16 14:08:46 -07:00
Petr Ruzicka
53217a3dbd with_items is obsolete - using loop instead (#46806) 2018-10-16 15:54:09 -05:00
Petr Ruzicka
559c92f9b6 with_items is obsolete - using loop instead (#46805) 2018-10-16 15:53:22 -05:00
Petr Ruzicka
b17f02a89a with_items is obsolete - loop should be used instead (#46524) 2018-10-16 15:52:32 -05:00
Jorgen
f1f47d9a40 Fixed typo (#47139)
<!--- fixed typo in exclude example -->

+label: docsite_pr
2018-10-17 06:14:02 +10:00
Jordan Borean
9ba33f6ac1
test: openssl 1.1.x compatibility (#47112) 2018-10-17 05:38:52 +10:00
Matt Martz
02f4d0a57f
Ensure that an empty literal list with loop skips the task (#47129) 2018-10-16 13:35:10 -05:00
Dag Wieers
4fc6ab55aa This fixes a weird indentation issue in the menu (#45089) 2018-10-16 12:00:43 -05:00
Matt Clay
6a51b5ed26 Use 4 nodes for sanity tests in CI. 2018-10-16 09:55:26 -07:00
Mariusz Mazur
79119c62cd Correct wording in k8s module description (#47125) 2018-10-16 11:52:18 -05:00
Matt Clay
5c7f876d0d
Update default-test-container to version 1.4.1. (#47042) 2018-10-16 09:45:31 -07:00
Matt Martz
abe64775cf Add porting guide note about inline vars on import/include_tasks (#47121)
* Add porting guide note about inline vars. Fixes #47102
2018-10-16 10:33:40 -05:00
Page Bowers
1ec71e503e Update the document to link to the script itself (#46986)
Added a link to the dynamic inventory script to make it easier for a user to find.
2018-10-16 09:12:11 -05:00
Abhijeet Kasurde
b48526ca65
VMware: new module: vmware_guest_disk (#36165)
1. Add support for SCSI controller creation
2. Support for SCSI Type
3. Warn about Disk Unit Number 7
4. Allow specifying SCSI controller
5. Allow specifying Disk Unit Number
6. Idempotency
7. Remove disks
8. Do not allow to reduce disk
9. More than 15 disks support
10. No SCSI controller and unit number check
11. Thin support
12. Update documentation and example
13. Multiple Datastore and datastore cluster support
14. Check datatype of disk unit number and SCSI controller
15. Handle disk_size when it is int or float

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-16 18:37:20 +05:30