Commit graph

3542 commits

Author SHA1 Message Date
Dag Wieers
846161a1a4 Allow to change executable (shell/interpreter) when using raw
This patch adds an optional 'executable=' option to the raw command line to override the default shell (/bin/sh), much like the shell module does.
2012-12-23 20:49:02 +01:00
Michael DeHaan
3d3deb9797 Merge pull request #1795 from dagwieers/raw-enhanced
Add return code and error output to raw module
2012-12-23 09:34:57 -08:00
Dag Wieers
988db558b3 Add return code and error output to raw module
Since we use 'raw' heavily on equipment where 'command' and 'shell' are not (yet) working (and python may need to be installed first using raw) these improvements are necessary in order to write more complex scripts (with return code handling and separated stdout/stderr).

This change includes the following changes:

 - exec_command() now returns the return code of the command
 - _low_level_exec_command() now returns a dict, including 'rc', 'stdout' and 'stderr'
 - all users of the above interfaces have been improved to make use of the above changes
 - all connection plugins have been modified to return rc and stderr
 - fix the newline problem (stdout and stderr would have excess newlines)

In a future commit I intend to add assertions or error handling code to verify the return code in those places where it wasn't done. Since only the output was available, the return code was ignored, even though we expect them to be 0.
2012-12-23 18:04:54 +01:00
Michael DeHaan
7620db4e99 Merge pull request #1796 from jpmens/crondoc
fix cron DOCUMENTATION
2012-12-23 08:12:36 -08:00
Jan-Piet Mens
85e0017a85 fix cron DOCUMENTATION 2012-12-23 14:08:26 +01:00
Michael DeHaan
d154183978 Merge pull request #1792 from jkleint/patch-1
Clarify that lineinfile uses Python regexes.
2012-12-21 04:52:43 -08:00
jkleint
d732b25828 Clarify that lineinfile uses Python regexes. 2012-12-20 11:41:45 -05:00
Daniel Hokka Zakrisson
d4c63e3300 Ensure each basedir is only added to the search path once
Fixes #1790.
2012-12-20 14:17:12 +01:00
Daniel Hokka Zakrisson
3a36c024da Make lookups being fatal up to the caller
Fixes #1769.
2012-12-19 19:19:04 +01:00
Daniel Hokka Zakrisson
eb57c9c430 Indicate the reboot option was added in 1.0
Fixes #1787.
2012-12-19 18:45:33 +01:00
Michael DeHaan
6fc6c37401 Merge pull request #1785 from TutoringAustralasia/devel
Add support for @reboot to cron module
2012-12-19 04:46:27 -08:00
Daniel Hokka Zakrisson
97cc384ccf Set basedir to . if there isn't one
This avoids special-casing '' = '.' everywhere the basedir gets used.
Fixes #1729.
2012-12-19 13:22:57 +01:00
Daniel Hokka Zakrisson
0f1706220b Add support for using the Jinja2 built-ins such as range 2012-12-19 09:42:15 +01:00
Daniel Hokka Zakrisson
ab9e9486ee Merge pull request #1783 from gregorg/fix_bug_python_2.5_json
Bugfix: in hosts with python-2.5, hash keys needs flatten string.
2012-12-19 00:15:09 -08:00
Chelsea Robb
96e2805b31 Change check for date/time parts being set 2012-12-19 15:12:04 +11:00
Chelsea Robb
6a02e3d918 Added error message when reboot and extra params are passed, and added better boolean parsing on reboot 2012-12-19 13:11:58 +11:00
Chelsea Robb
fc4ac70342 Add support for @reboot to cron module 2012-12-19 09:32:51 +11:00
Michael DeHaan
d34e320e12 Merge pull request #1733 from dhozac/lookup-list
Make all lookup plugins accept lists as arguments
2012-12-17 16:53:01 -08:00
Michael DeHaan
04195e202d Merge pull request #1747 from njharman/alpharange
Alphabetic inventory hostname patterns.
2012-12-17 16:52:11 -08:00
Michael DeHaan
4bcdd24688 Merge pull request #1776 from junegunn/inventory-group-var-ws
Allows whitespaces around assignment operators when defining group variables
2012-12-17 16:51:49 -08:00
Michael DeHaan
2699ef3c41 Merge pull request #1782 from candeira/fix-playbook2-documentation
fix documentation for authorized_key in advanced playbooks page in docsite
2012-12-17 16:51:24 -08:00
Javier Candeira
dac83c15a0 fix documentation for authorized_key in advanced playbooks page in docsite 2012-12-18 07:23:40 +11:00
Gregory Duchatelet
29f985aa2e do not conditionalize this for older Python, fix indentation, better use
of hash iteration.
2012-12-17 21:07:36 +01:00
Gregory Duchatelet
e64de2ff88 Bugfix: in hosts with python-2.5, hash keys needs flatten string. 2012-12-17 13:46:50 +01:00
Michael DeHaan
89dab0b12c Merge pull request #1766 from dhozac/complex-vars-in-playbook-include
Allow parameterized playbook includes to define complex variables
2012-12-16 10:59:53 -08:00
Junegunn Choi
8896486606 Adds comments on handling quoted group vars 2012-12-16 10:32:05 +09:00
Daniel Hokka Zakrisson
c2792a936d Allow parameterized playbook includes to define complex variables
To be used like:
- include: playbook.yml
  vars:
    mylistvar:
    - item1
    - item2
2012-12-15 21:56:28 +01:00
Daniel Hokka Zakrisson
b73016b881 Make all lookup plugins work with lists
Lookup plugins should accept a string or a list, and always return
a list, even if it is just one item.
2012-12-15 21:47:16 +01:00
Michael DeHaan
6350dedd7a Merge pull request #1765 from dagwieers/skip-when-no-matches
Change message when a play matches no hosts
2012-12-15 11:59:37 -08:00
Michael DeHaan
ad2ab6a5dd Merge pull request #1772 from fdavis/devel
change error message on check_conditional when variable does not exist
2012-12-15 11:58:52 -08:00
Michael DeHaan
dede11750c Merge pull request #1775 from dagwieers/boolean-yes-no
Make use of yes/no booleans in playbooks
2012-12-15 11:53:48 -08:00
Michael DeHaan
29611bdedf Merge pull request #1777 from dominis/devel
fixes #1767 parsing serial from extra_vars
2012-12-15 11:52:40 -08:00
Daniel Hokka Zakrisson
d4b1874d44 Merge pull request #1773 from jpmens/scriptdoc
fix and clarify 'script' docs
2012-12-15 09:28:50 -08:00
Daniel Hokka Zakrisson
92365d4740 Merge pull request #1778 from junegunn/fix-hostname-expansion
Fix hostname expansion bug in inventory parser
2012-12-15 09:20:35 -08:00
Junegunn Choi
7fbb7e079a Fix hostname expansion bug in inventory parser 2012-12-16 01:49:12 +09:00
Nandor Sivok
f31fbdff1f moving int() conversion to the play init 2012-12-14 18:05:08 +01:00
Stephen Fromm
292ae0ac00 Merge pull request #1774 from jpmens/adoc1
cleanup Example output in ansible-doc
2012-12-14 09:02:21 -08:00
Nandor Sivok
e91db5fcdc fixes #1767 parsing serial from extra_vars 2012-12-14 13:21:58 +01:00
Junegunn Choi
daf797804b Allows whitespaces around assignment operators
when defining group variables
2012-12-14 20:43:29 +09:00
Dag Wieers
66fb7fd9de Make use of yes/no booleans in playbooks
At the moment Ansible prefers yes/no for module booleans, however booleans in playbooks are still using True/False, rather than yes/no. This changes modifies boolean uses in playbooks (and man pages) to favor yes/no rather than True/False.

This change includes:

- Adaptation of documentation and examples to favor yes/no
- Modification to manpage output to favor yes/no (the docsite output already favors yes/no)
2012-12-14 11:56:53 +01:00
Jan-Piet Mens
52a55a3575 cleanup Example output in ansible-doc 2012-12-14 11:12:26 +01:00
Jan-Piet Mens
4f8abd981a fix and clarify 'script' docs 2012-12-14 10:59:48 +01:00
fdavis
7347e54b70 change error message on check_conditional when variable does not exist 2012-12-13 23:02:30 -08:00
Stephen Fromm
23f2a7fc7e Merge pull request #1771 from sfromm/issue1762
Ensure files created by authorized_key have correct selinux context
2012-12-13 16:39:29 -08:00
Stephen Fromm
ccca5fcd1c Ensure files created by authorized_key have correct selinux context
Three changes:
* Add set_default_selinux_context() to module_common that sets
  a file's context according to the defaults in the policy
* In atomic_replace(), set the default context for the file if
  selinux is enabled and the destination file does not exist.
* In authorized_key, set the default context when creating
  $HOME/.ssh and $HOME/.ssh/authorized_keys.  If these already
  exist, this won't touch them.
2012-12-13 16:35:49 -08:00
Daniel Hokka Zakrisson
bf73ac76be Merge pull request #1770 from jkleint/patch-1
Missing colon in $FILE example docs
2012-12-13 13:25:00 -08:00
jkleint
e363abeca7 Missing colon in $FILE example 2012-12-13 16:21:25 -05:00
Michael DeHaan
f2893b6418 Merge pull request #1746 from njharman/subversion
Subverion module improvements
2012-12-13 04:34:19 -08:00
Dag Wieers
cd930d2e34 Change message when a play matches no hosts
I guess my previous pull request was confusing, by changing the message to something we already do for tasks, it makes it more clear.

Just like we say:

    TASK: [foo bar]
    skipping: [system01]

The message now is more clear:

    PLAY [wagawaga] *******************************
    skipping: no hosts matched

It makes it clear that we are skipping the play, just as is done for a task when a condition is not met.
2012-12-13 13:31:41 +01:00
Michael DeHaan
5d31e8d1fc Merge pull request #1752 from jpmens/mail2
mail module: add MIME attachments, port and addresses with phrases
2012-12-13 04:31:01 -08:00