Commit graph

6157 commits

Author SHA1 Message Date
Jordan Borean
f1566f07db fix filesystem tests on OpenSUSE 15+ (#52716)
(cherry picked from commit 5e3e0eb946)
2019-02-21 17:06:01 -08:00
Jordan Borean
773b20886c test suse: get tests working on newer OpenSUSE distributions (#52539)
(cherry picked from commit c312287731)
2019-02-21 16:43:25 -08:00
Jordan Borean
a17d9f1cc6 git: kill gpg-agent in tests on newer OpenSUSE hosts (#52476)
(cherry picked from commit bb0a69e084)
2019-02-18 10:06:09 -08:00
Zim Kalinowski
211fe600a4 fixing force_update in azure_rm_mysqldatabase (#52389)
(cherry picked from commit fa73abcf5d)
2019-02-18 09:57:12 -08:00
Zim Kalinowski
474d76c0dd Fixing azure_rm_postgresqldatabase force_update parameter (#52388)
(cherry picked from commit 8422e23533)
2019-02-18 09:47:01 -08:00
Zim Kalinowski
0e4f07b5ae resolved conflict 2019-02-18 08:48:29 -08:00
Zim Kalinowski
0fed03fa85 merge conflict 2019-02-18 08:48:08 -08:00
Jordan Borean
2800f23274 alternatives - fix OpenSUSE dir on newer distros (#52458)
(cherry picked from commit 3ecd6e19f7)
2019-02-18 08:46:05 -08:00
Jordan Borean
f8e29c81f1 zypper_repository: fix return check on newer OpenSUSE versions (#52457)
(cherry picked from commit d6453a79f5)
2019-02-18 08:45:14 -08:00
Jordan Borean
7ab05d551f zypper: fix tests to use new URL for OpenSUSE 15.0 (#52453)
(cherry picked from commit 4b296da6a2)
2019-02-18 08:44:40 -08:00
Zim Kalinowski
3929cfea85 merged change 2019-02-18 08:44:16 -08:00
Jordan Borean
bbf2d6b637 opensuse - install password-store from specific repo (#52439)
(cherry picked from commit 4a94bd8d9d)
2019-02-18 08:42:59 -08:00
Martin Krizek
7fb1549152 Native Jinja2: raise undefined error immediately (#52237)
Fixes #52158

(cherry picked from commit 50d7483632)
2019-02-18 08:31:26 -08:00
T. Ichikawa
dc3b7aebd6 Backport/2.7/51548 - Properly handle unauthenticated yum proxy config (#52245)
* Properly handle unauthenticated yum proxy config (#51915)

Fixes #51548

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 2721ed260e)

* Fix: Yum module does not use proxy when username is not set #51548 (#51994)

* add test of yum with proxy

* Properly handle unauthenticated yum proxy config

Fixes #51548

* shell executable is bash

(cherry picked from commit c2a409a9e0)
2019-02-14 12:45:31 -08:00
Sam Doran
805c9fa712 Update command/shell docs with note about modules for rebooting(#51499)
(cherry picked from commit ad386290b4)
2019-02-14 12:42:22 -08:00
Wojciech Sciesinski
b7b4182bbd Install the NuGet package provider if needed (#52129)
* Install the NuGet package provider if needed

* Add the changelog fragment file
2019-02-14 12:41:16 -08:00
Matt Martz
396a2f7471 [stable-2.7] Disallow use of remote home directories containing .. in their path (CVE-2019-3828) (#52133) (#52173)
* Disallow use of remote home directories containing .. in their path

* Add CVE to changelog
(cherry picked from commit b34d141)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-02-13 09:23:06 -08:00
Jordan Borean
03100cb647 Add Windows Server 2019 to Shippable matrix (#51685)
* Test out Server 2019 - ci_complete

* run tests and continue on error - ci_complete

* Add the full matrix back in

(cherry picked from commit 0334c20630)
2019-02-12 10:29:28 -08:00
Felix Fontein
0093b69935 openssl_csr: ignore empty strings in altnames (#51473)
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.

(cherry picked from commit 9b1cbcf3a4)
2019-02-11 12:10:22 -08:00
Martin Krizek
1492f46d78 yum: disableexcludes is supported on centos6 (#51698)
(cherry picked from commit 33b07f322c)
2019-02-11 11:18:29 -08:00
Matt Davis
0708c80c40 fix string_format sanity check (#51780)
* newer version of Pylint moved the impl; use conditional import to find for new/old

(cherry picked from commit 6654c7aeea)
2019-02-11 11:15:22 -08:00
Wojciech Sciesinski
90203d0a11 Correct integration tests for the win_disk_facts module (#51044)
* Correct integration tests for the win_disk_facts module

* Exclude W2K8, W2K8-R2 from tests run under CI
2019-02-11 11:14:54 -08:00
Elijah DeLee
fe79534415 Backport aws ec2 missing region discovery (#51626)
* aws_ec2 Implement the missing 'region discovery' (#51333)

* aws_ec2 Implement the missing 'region discovery'

  fixes #45288

  tries to use api as documented (which seems to fail in latest boto3 versions)
  and fallback to boto3 'hardcoded' list of regions

* fixes and cleanup, add error for worst case scenario

* fix tests, remove more unused code

* add load_name

* acually load the plugin

* set plugin as required

* reverted test changes, removed options tests

* fixes as per feedback and cleanup

* Allow default regions list to use flexible credential types
2019-02-11 11:13:48 -08:00
Jordan Borean
ad71a9a7ed Get docker tests working on OpenSUSE (#51896)
(cherry picked from commit c92fcf0b57)
2019-02-07 13:54:22 -08:00
Matt Davis
ac3a3ce599 [stable-2.7] fix azure_rm_deployment test
* recent changes to args for hosted template file broke the test; changed test to use a specific known-working commit instead of `master`.
* long-term may want to consider hosting the template in httptester or just embedding a local copy
(cherry picked from commit 46bf387)

Co-authored-by: Matt Davis <mrd@redhat.com>
2019-02-07 13:15:22 -08:00
Brian Coca
7589d496fc remove default from delegate_facts to inherit (#45492) (#51553)
* remove default from delegate_facts to inherit (#45492)

* remove default from delegate_facts to inherit

fixes #45456

* test delegate_facts

* added note about inheritance and defaults

* yamllint

(cherry picked from commit 8743e6ae2e)

* added changelog
2019-02-04 14:16:32 -08:00
Jordan Borean
bdf7f42b7c test win_setup - make py3 compatible (#51693)
(cherry picked from commit f78cdcd2c5)
2019-02-04 12:57:27 -08:00
Jordan Borean
aedad64c8f win_service - use custom binary for tests (#51689)
(cherry picked from commit 2e99dea867)
2019-02-04 12:57:06 -08:00
Jordan Borean
06505fc521 add pause to make test more stable (#51680)
(cherry picked from commit ebc9e4caf7)
2019-02-04 12:54:08 -08:00
Jordan Borean
9168e6844a win_power_plan: fix for Windows 10 and Server 2008 compatibility (#51471)
(cherry picked from commit f27078df52)
2019-02-04 12:35:53 -08:00
Brian Coca
3bf030ddcc Handle complex quoting in extra args in pull cli (#50212)
* added proper testing

fixes #40729

(cherry picked from commit b6824669df)
(cherry picked from commit e010034151)
2019-02-04 12:27:00 -08:00
Felix Fontein
af977daec7 Adjusting to differences between Ansible 2.7 and Ansible 2.8.
(cherry picked from commit 6cdb357826ffb1446e4ceb1050349fe30f511b41)
2019-01-31 08:42:29 -08:00
Akshay Gaikwad
03bc4be1c3 Add integration tests for docker_image options (#48574)
* Add integration tests for docker_image options

Tests for options in docker_image module

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add force option tests

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add repository option tests

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Modify test for option force

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
(cherry picked from commit 0493ef359a)
2019-01-31 08:42:29 -08:00
Jordan Borean
1d3f29d4be ansible-test: make the httptester for Windows more resiliant around the shell chosen (#51416)
(cherry picked from commit ce8db479f0)
2019-01-29 17:53:32 -08:00
Dag Wieers
67606bfa66 aci_aaa_user: Fix an issue with clear_password_history 2019-01-29 17:31:32 -08:00
Dag Wieers
0d5f083a52 aci_aaa_user: Fix changing user description
This fixes a reported problem with the aci_aaa_user module.
2019-01-29 11:06:18 -08:00
Dag Wieers
a22f46bacf Docs: Add a "seealso" section to the module docs (#45949)
* Docs: Add a separate  "seealso" section to the module docs
to list related modules and/or related references. This clears up the notes
section for things that are actual notes.

So you can add a section in your module documentation and four types of
references are possible.

    seealso:

    # Reference by module name
    - module: aci_tenant

    # Reference by module name, including description
    - module: aci_tenant
      description: ACI module to create tenants on a Cisco ACI fabric.

    # Reference by rST documentation anchor
    - ref: aci_guide
      description: Detailed information on how to manage your ACI infrastructure using Ansible.

    # Reference by Internet resource
    - name: APIC Management Information Model reference
      description: Complete reference of the APIC object model.
      link: https://developer.cisco.com/docs/apic-mim-ref/

This PR also includes:

- Implements ansible-doc support
- Implements schema support for the seealso options
- Updates to the development documentation
- Rename filter convert_symbols_to_format to rst_ify, cfr the existing html_ify and tty_ify filters
  - This makes the existing template a lot easier to read and fixes the confusion I had myself rereading the template (again).
- We fixed the possible suboption types (which was limited to 'bool' only)

* Use latest stable instead of devel docs

(cherry picked from commit baf0ad2309)
2019-01-28 10:13:05 -08:00
Jordan Borean
7d52c07df2 ansible-test: add Ubuntu 18.04 container (#50790)
* ansible-test: Add Ubuntu 18.04 to Shippable CI nodes

* re-add ubuntu1604/3 to matrix

* forgot to add environment for git kill gpg-agent

(cherry picked from commit 828df4b336)
2019-01-24 12:00:16 -08:00
Sam Doran
44d7c1e23e [stable-2.7] Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776)
* Catch SSH authentication errors and don't retry multiple times to prevent account lock out

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Subclass AnsibleAuthenticationFailure from AnsibleConnectionFailure

Use comparison rather than range() because it's much more efficient.

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Make paramiko_ssh connection plugin behave the same way

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add changelog

Signed-off-by: Sam Doran <sdoran@redhat.com>.
(cherry picked from commit 9d4c0dc111)

Co-authored-by: Sam Doran <sdoran@redhat.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-01-24 10:38:08 -08:00
Jordan Borean
44474bf424 file - allow touch on files not owned by user (#50964)
* file - allow touch on files not owned by user

* use Sentinal value and preserved existing args

* Do no instantiate the Sentinel object

(cherry picked from commit 419727a6da)
2019-01-24 10:22:11 -08:00
Matt Clay
22448ce99e [stable-2.7] Disable failing azure_rm_postgresqlserver test..
(cherry picked from commit 37767849ee)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-22 22:34:56 -08:00
Matt Clay
278aa94f1f [stable-2.7] Fix subversion integration test on Fedora 29. (#51089)
* Fix subversion integration test on Fedora 29.

This upgrades the sqlite-libs and subversion packages to make sure
that the version of sqlite expected by subversion is installed.

* Fix compatibility with RHEL and CentOS.
(cherry picked from commit d4dbc7f2e0)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-18 16:24:32 -08:00
Brian Coca
4a89749dd5 Prevent duplicate role insertion into roles: (#50552)
* Corner case in which import_role would add another instance of a role with the same signature into roles: when it already existed there.

  roles:
	- name: a
  tasks:
       - import_role: name=a

  would execute role 'a' 3 times instead of the intended 2 (x2 in roles: phase +1 in tasks:)

* added tests

(cherry picked from commit eca7c3c8c7)
2019-01-18 12:58:43 -08:00
Jordan Borean
8fcdb0a73c ansible-test git: kill gpg-agent to remove locks (#50917)
* ansible-test git: kill gpg-agent to remove locks

* skip gpg-agent kill for OpenSUSE

(cherry picked from commit 3db6b9b416)
2019-01-18 12:42:48 -08:00
Jordan Borean
80b5b33e2b setup_rabbitmq - fix erlang pinned dependencies (#51048)
(cherry picked from commit 18c35b69fb)
2019-01-17 16:57:47 -08:00
Jordan Borean
49f0ab85d6 ansible-test: fix cloud_init_data_facts for Ubuntu 18.04 (#50916)
(cherry picked from commit 03669cdcdd)
2019-01-14 22:28:20 -08:00
Jordan Borean
e70aa001bf ansible-test: fix dpkg_selections on Ubuntu 18.04 (#50915)
(cherry picked from commit a54eb58156)
2019-01-14 22:28:20 -08:00
Jordan Borean
bca3066a27 ansible-test: add postgresql var file for Ubuntu 18.04 (#50914)
(cherry picked from commit 8c5b2048de)
2019-01-14 22:28:20 -08:00
Jordan Borean
19597c559a ansible-test: rename setup_mysql_db Ubuntu name to work with 18.04 (#50907)
(cherry picked from commit 518699988f)
2019-01-14 22:28:20 -08:00
Jordan Borean
4ca81631b6 ansible-test: apt cleanup and futher 18.04 fixes (#50906)
(cherry picked from commit bbad033a5e)
2019-01-14 22:28:20 -08:00