Commit graph

28982 commits

Author SHA1 Message Date
Andreas Calminder
cac93cbd1f os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix (#56577)
* compare list of dicts

* update example for dhcp_server_opts to include ip_version which is automatically added by openstack

* add note about dhcp_server_opts

* add changelog fragment

* fix forgotten exception+pass

* no need to excplicitly check for None

* fix oops

* fix import error

* missed missing_required_lib

* changelog fragment formatting and grammar fixes

* update requirements in documentation and fix spelling
2019-09-06 22:44:25 +02:00
Mark Chappell
b8650c0a50 aws_asg: Fix idempotency when using tags and metrics (#61284)
* Update AWS hacking policy to enable ASG Tagging management

* aws_asg: Add tests for ASG Tagging (including idempotency)

* aws_asg: ignore sort order when comparing tags on the ASG (fix idempotency)

* ec2_asg: (integration tests) test for idempotency when managing metrics collection

* ec2_asg: sort list of enabled metrics to ensure clean comparisons.
2019-09-06 12:48:40 -07:00
Matt Martz
8331c8fdc3
Properly hide limit and list-hosts args from ansible-inventory (#61618)
* Properly hide limit and list-hosts args from ansible-inventory. Fixes #61604

* Add changelog fragment

* Consolidate limit

* Fix positional argument with --graph

* Properly error for hidden arguments

* linting issue

* host pattern changelog
2019-09-06 11:43:50 -05:00
Sam Doran
61efffcbe1
User - correct group removal description in docs (#61936) 2019-09-06 12:16:33 -04:00
Andrey Klychkov
e4d4e49388 Fix mysql.py logic related to 53326 (#61832) 2019-09-06 13:53:54 +01:00
Ganesh Nalawade
4f29b5a76b
Fix ansible-connection persist after playbook run complete issue (#61591)
* Fix ansible-connection persist after playbook run issue

*  PR https://github.com/ansible/ansible/pull/59153 to add support
   for delaying the ansible-connection added an old issue of
   ansible-connection persisting even after playbook run is finished
   till either command timeout or connect timeout is triggered.
   ansible-connection persist after playbook execution is done
   and also delays the connection initilization untill a method
   in invoked from module side on the connection object.

* Add chanegelog
2019-09-06 14:23:18 +05:30
felyl-github
e6fe52bc56 Update os_security_group_rule.py (#61262)
Currently, this module does not support to add 132 SCTP rule in security group rule of openstack. Could we add this support in this module? Thanks~
2019-09-06 02:32:34 -04:00
Matt Davis
7f4328ad12
allow external collections under the ansible NS (#61908)
* fixes #59988
2019-09-05 18:50:22 -07:00
Toshio Kuratomi
f58899eef7 Update release name for 2.10
Add a list of previously used release names to make it easy to tell what
release names are no longer usable.

Add a test that new release names have been added to the used list.

Fixes #61616
2019-09-05 18:36:06 -07:00
Mark Chappell
832e03d932 Fixup iam_group integration tests and return value documentation (#61243)
* iam_group: (integration tests) migrate tests to module_defaults

* iam_group: (integration tests) migrate to using temporary user and group with {{ resource_prefix }}

* iam_group: (integration tests) fix test, checking the return values

* iam_group: (integration tests) Add some more tests around the behaviour of 'changed'

* iam_group: (docs) Update documentation of iam_group return value

* Update AWS testing policies to enable group/user management
2019-09-05 19:25:36 -04:00
Kevin Breit
7d303e54f6 meraki_organization - Add warning about organization deletion (#61886)
* meraki_organization - Add warning about organization deletion
The documentation is now more explicit about the ramifications of using `state: absent` in a task.
2019-09-05 16:02:19 -05:00
Sumit Jaiswal
1425d23513 To fix IOSXR L3 Interfaces idempotency failures (#61860)
* fix zuul idemptency failures

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-05 16:39:15 -04:00
Yannis Ansermoz
ce8af1c8c5 Typo 'state:' net_lldp (#61543)
'state:' should be "absent" not "lldp"
2019-09-05 14:15:19 -05:00
Nathaniel Case
a365e77cc3
Connect before reading the prompt? (#61797) 2019-09-05 14:48:16 -04:00
Travis Burton
394a05108d Update mso_schema_template_deploy.py (#61849)
module names are incorrect in EXAMPLES:  changed module names from 'mso_schema_template' to 'mso_schema_template_deploy'
2019-09-05 10:55:56 -05:00
gen2kes
513bddb44a VMware: Add disk_mode parameter in vmware_guest_disk (#60406)
* Solve issue 58592

Added support to select disk_mode.
2019-09-05 11:52:12 -04:00
Evgeni Golov
1aca1f86b6 don't set default:None in documentation when there is no default (#61111)
otherwise "None" will be rendered as a string on docsite
2019-09-05 10:48:11 -05:00
js-max
70f501d5c8 Update hashi_vault.py documentation with kv V2 example (#61221) 2019-09-05 11:42:39 -04:00
Nathaniel Case
cc9adf7f1a
Unify ios_logging documentation with accepted options (#61777)
* Unify ios_logging documentation with accepted options

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Copy suggestion over to eos_logging
2019-09-05 08:58:57 -04:00
Fabian von Feilitzsch
f406b8b4c4 Fix bug preventing wait_condition from being respected when using apply (#61493) 2019-09-05 22:49:30 +10:00
Abhijeet Kasurde
223dab99ea
gitlab_hook: Update documentation (#61837)
* Update docs for note_events

Fixes: #61833

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 17:09:59 +05:30
Felix Fontein
e06dbe6e4f
Azure _info modules: fix returned ansible_facts when called as _info (#61805)
* Fix Azure _info modules which still returned ansible_facts.

* Adjust PR #.

* Fix wrong assignment.

* Reorganize code for clarity.
2019-09-05 11:51:56 +02:00
Bill Dodd
2a932ad7cf Fix power command ResetType mapping logic (#59927)
* fix power command ResetType mapping logic

* add changelog fragment
2019-09-05 05:39:21 -04:00
Abhijeet Kasurde
823c108fac
ovirt: Fix API calls in ovirt_storage_domain (#61825)
* Fixed argument in _attached_sds_service API
* Fixed argument in _maintenance API

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 15:00:18 +05:30
Paul Belanger
c723eb2f04
Remove unused import from iosxr facts (#61785)
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 22:16:15 -04:00
Jordan Borean
3a7b77a94c
ansible-galaxy fix --server option for roles (#61820) 2019-09-05 11:46:44 +10:00
Paul Belanger
f81b7dd10a
Remove unsed import for eos facts module (#61795)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 19:50:12 -04:00
Matt Martz
8214d188cf Don't truncate the last character from galaxy urls. Fixes #61624 (#61775) 2019-09-05 07:06:42 +10:00
Paul Belanger
7be672e1c2
Remove unsed import for junos facts (#61787)
This is no longer needed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 15:00:19 -04:00
Sloane Hertel
ff05991265
s3 - improve waiting for the bucket (#61802) 2019-09-04 14:50:08 -04:00
Nathan Swartz
4c8407fb83 Fix documentation and facts_from_proxy value in the netapp_e_facts module. (#61072) 2019-09-04 14:34:58 -04:00
Paul Belanger
44eaea9f80
Remove unused import for cisco ios facts (#61790)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 14:22:38 -04:00
Paul Belanger
736938625b
Remove unused import for vyos facts (#61784)
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 13:54:08 -04:00
Scott Luther
0c73e47a42 fix erroneous failures in docker_compose due to deprecation warnings … (#61650)
* fix erroneous failures in docker_compose due to deprecation warnings from docker (#60961)

* Update error handling to work with new method of capturing output

Co-Authored-By: Felix Fontein <felix@fontein.de>

* update error handling

* fix syntax error

* fix indentation

* fix indentation (again)

* remove erroneous line
2019-09-04 19:34:05 +02:00
kucharskim
1dea661ce8 Allow 13 asterisk characters in password field without warning (#54893)
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone.
2019-09-04 11:49:16 -04:00
Strahinja Kustudic
ee4b3b8854 Fix systemd start state with deactivating service state 2019-09-04 08:01:33 -07:00
Nilashish Chakraborty
a795f6941e Make *_bgp modules collection safe (#61761)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-04 10:29:00 -04:00
Sloane Hertel
91ccb03552 aws_s3 - wait for the bucket before setting ACLs (#61735)
* Wait for the bucket to become available if possible before setting ACLs
2019-09-04 09:42:28 -04:00
Florian Paul Hoberg
531e0560cb add trustcacerts option for JAVA keytool (#61750)
* add trustcacerts option for JAVA keytool

* fixed whitespace

* added type in documentation
2019-09-04 13:07:20 +01:00
Trishna Guha
c1e02d5c7a
Remove choices from gather_network_resources facts and fix negated all, min (#61362)
* remove choices from gather_network_resources facts and allow negating subset without needing to add a new subset specific for negation

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* negated all, min should not return any fact

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-09-04 16:31:10 +05:30
Sumit Jaiswal
2672dc9694
Fixes IOS L3 intermittent zuul failure (#61682)
* fix ios l3 intermittent failure

* fix self

* dict to ordered dict

* fix diff_again fn

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* remove orderdict as its expensive

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* update verify fn

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-04 15:51:05 +05:30
Mark Chesney
01f4081b66 Fix creation of DigitalOcean droplets using digital_ocean_droplet module (#61655)
* Omit disallowed 'id' attribute in request body to create a droplet

* Add changelog fragment for PR #61655
2019-09-04 02:28:56 -04:00
Tim Rupp
2ebeadfc14 Migrate ec2_eip module to boto3 (#61575)
* Migrate ec2_eip module to boto3

This patch is a step towards the integration of several PRs that have
attempted to migrate this code

closes #55190
closes #45478

Follow-up PRs will address the outstanding changes made in #55190
2019-09-03 22:46:29 -04:00
Jiri Tyr
47ce938121 Read update file as utf-8 (#55253) 2019-09-03 21:54:10 -04:00
Bill Dodd
091ab12692 Fix issues and limitations in account mgmt commands (#58441)
* fix issues and limitations in account mgmt commands

* fix pep8 and example yaml errors

* remove new option and update option aliases

* find next empty slot when adding user via PATCH
2019-09-03 21:44:33 -04:00
Bill Dodd
088d821f75 Fix KeyError exceptions in GetLogs command (#59877)
* fix KeyError exceptions in GetLogs command

* add changelog fragment

* refine the list of LogEntry properties to collect
2019-09-03 21:44:07 -04:00
John McDonough
86b38a0ead Add ucs_query (#60607)
* Add ucs_query

* fix sanity erros

* Change version_added to 2.10
2019-09-03 21:34:46 -04:00
Orion Poplawski
a09b89f567 osx_defaults - doc tweaks (#60881)
* [osx_default] We are looking for the "defaults" executable, not "osx_defaults"

* [osx_default] Add example for setting system wide default
2019-09-03 20:16:39 -04:00
Miguel Angel Muñoz González
6cf025425e Fix Decode Bug in Py3 (#61691)
* Fix Decode Bug in Py3

* Update fortios.py

* Remove special char from name

* Ensure full compatibility when ansible is install from Py2
2019-09-03 15:37:00 -04:00
Gabriel Suarez
411b208147 Add example of "parent_group" usage in aws_ec2.py (#60430)
##### SUMMARY
Looks like the "parent_group" option in "keyed_groups" is a very recent feature that is not being documented. 
This pull request just adds a simple example of the usage of this useful feature.



##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-03 20:33:47 +01:00
Evgeniy Krysanov
9797857a67 Fix Python 2.7 compat (#58816) 2019-09-03 20:24:41 +01:00
nikkytub
5f9fe6b9c8 Removed additional fetch from config context because it is now available in the host from Netbox v2.6 onwards (#59028)
* Removed additional fetch and config context as an option as it is now available in the host from Netbox v2.6

* Added config-context as an option
2019-09-03 20:23:28 +01:00
Martin Nečas
b46e661d39 ovirt search name with space (#59184)
* init ovirt_search_name_with_space

* add search_by_name with whitespace

* add comments
2019-09-03 20:22:37 +01:00
Kurt Davis
d4147b55dd Issue #41447 - support AWS Aurora S3 privileges in mysql_user module (#59663) 2019-09-03 20:22:07 +01:00
Andrey Klychkov
fad405ac42 postgresql: Move PgMembership to module_utils (#61598)
* postgresql: move PgMembership to module_utils

* postgresql: move PgMembership to module_utils, optimize logic
2019-09-03 20:14:09 +01:00
Yuji Konishi
7c92c4214c Fixes #59613 (#60041) 2019-09-03 15:08:08 -04:00
ETNyx
5d7d4a93c8 docs: Update apt_key.py add requirements of gpg (#61552)
* docs: Update apt_key.py add requirements of gpg. The module needs to have gpg installed, otherwise it will end up with error {"changed": false, "msg": "Failed to find required executable gpg in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-09-03 13:53:44 -05:00
John R Barker
763fa4e85f
version_added: '2.10' for post branch commits (#61678)
Due to bot automerge a few PRs were merged before version_added had been updated.

https://github.com/ansible/ansible/pull/61674
2019-09-03 19:53:10 +01:00
Cristian Dascalu
47b9c5bf04 Ecs taskdefinition secrets (#60112)
* adding specific examples for using environment and secrets in the container definition
2019-09-03 11:17:22 -05:00
Theo Ouzhinski
9c1dc0ea7f grafana_plugin: update documentation (#60600) 2019-09-03 12:10:47 -04:00
Andrej Svenke
bdc87a5651 datadog_monitor: Add process alert support (#60325) 2019-09-03 12:10:07 -04:00
Rob White
a10606484c Fix required_together statement - access_logs_s3_prefix is not required as per the documentation (#52017) 2019-09-03 11:26:38 -04:00
Yves Martin
c4fd2096bf Fix examples for bigip_file_copy (#61686) 2019-09-03 11:16:31 -04:00
Abhijit Menon-Sen
ca3078de5f
Remove duplicated word
We print "%s success", so there's too much success going on.
2019-09-03 20:31:40 +05:30
Yannis Ansermoz
bcbcac3bd8 net_user documentation typo configured_password (#61556)
password -> configured_password in the last example
2019-09-03 10:00:20 -05:00
Wojciech Sciesinski
4b9b5d3745 Remove unnecessary information (#61657) 2019-09-03 15:47:20 +01:00
Tahir Akhtar
58acc8d082 Clarity on mutual exclusion of Username and Token (#61668)
##### SUMMARY
Although there is an example showing that username is not required with personal access token, it will be nice to more clearly state in options description. 
##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-03 15:41:42 +01:00
Simon Legner
7dbd6116d8 Fix typesetting of "GitLab" (#61702) 2019-09-03 09:22:26 -05:00
Tomáš Karásek
74e6c460b4 Fix missing pass of IPXe params to API client call, fixes #32910 (#32912) 2019-09-03 10:07:15 -04:00
Roland Wolters
9744ce1e1d Rename checkpoint to check_point due to legal reasons, fix #61145 (#61172)
* Fix #61145

* Fix type keyword

* Removed file fragment
2019-09-03 19:05:50 +05:30
Bradley A. Thornton
39f35ac5bb Fix network resource module wording and typographical errors (#61613) 2019-09-03 09:11:46 -04:00
Nathaniel Case
d20d10b5c5
Avoid infinite recursion on login (#61617) 2019-09-03 08:55:20 -04:00
jotai73
447c7d9ff0 Update homebrew_cask example docs (#61637)
Changed homebrew_cask module flag from "allow_external_apps" to "accept_external_apps" in example section
2019-09-03 16:56:29 +05:30
David Gallegos
68f9cd14cb feat: support postgres 11 in azure_rm_postgresqlserver (#58727) 2019-09-03 14:00:33 +08:00
Abhijeet Kasurde
e7c6134fd0
VMware: Fix get_tags_for_vm API in vmware_vm_info module (#61697)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-03 11:25:16 +05:30
Alexandre Mulatinho
e4d72dd981 luks_device.py: Allow manipulate LUKS containers with label or UUID (#61603)
* luks_device.py: Allow manipulate LUKS containers with label or UUID

- Allow create a LUKS2 container format with label support
- Allow manipulate (open, close, modify) an LUKS container based on
  both label (LUKS2 format) or UUID instead of using devices only.

Fixes: #58973
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* test_luks_device.py: organizing tests to support labels

- Add label on some tests and fix errors reported by Shippable

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

* luks_device.py: adjusting versions and messages

- Modifying version_added from 2.9 to 2.10
- Fixing some messages
- Created a changelog fragment
- Moving blkid from scope

Fixes #58973
Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
2019-09-03 05:40:09 +02:00
Vitalii Kostenko
6f7cd8370a Ansible FTD Module improvements and tests update. (#60640)
* Ansible FTD Module improvements and tests update.

* Fix sanity tests

* Fix formatting
2019-09-03 08:38:11 +05:30
Christian Fetzer
7197c41fff influxdb: Add support for 'path' parameter (#61173)
While it's possible to host InfluxDB on a different path prefix
(through a reverse proxy such as nginx or traefik), the Ansible
influxdb_* modules did't support that use case.

The patch adds a 'path' parameter, which is passed to the influxdb
Python client.

Example for connecting to InfluxDB running on http://localhost/influxdb

    - hosts: all
      tasks:
        - influxdb_database:
            database_name: test
            path: influxdb
            port: 80
2019-09-02 22:17:25 +02:00
Martin Krizek
9ccef9e819 perf: reduce getting handler variables (#59969)
* perf: reduce getting handler variables

ci_complete

* Do not re-create templar
2019-09-02 10:57:08 -04:00
Maxim Babushkin
f1a1b72f07 os_server - add "tag" to instance nics (#61119)
A custom "tag" could be passed to the instance metadata with the nics.
Add support for the "tag" to the module.
2019-09-02 05:07:53 -04:00
Fred-sun
6e6c2f5cea Set the default value for the managed_disk_type (#60749) 2019-09-02 15:54:58 +08:00
Mateusz Gałażyn
52a665e224 #59096 Fix for not working azure_rm_aks (#59097) 2019-09-02 15:50:11 +08:00
Mariusz Mazur
cf86a5e07a kubevirt: also add wait_sleep (#61020) 2019-09-01 17:53:31 -07:00
Paul Belanger
de6e2de0c4
Remove unused import for iosxr l3_interfaces (#61563)
This was caught by our ansible network collections migration script.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-31 14:47:02 -04:00
Guillaume Leroy
21b101f8e1 add option to define keysize at luks partition creation (#61522)
* add option to define keysize at luks partition creation

* Bump version_added.

* Extend tests.
2019-08-31 19:32:41 +02:00
Andrey Klychkov
a6d9401c88 postgresql modules: explicit defaults for bool params (#61538) 2019-08-31 18:27:57 +02:00
Nathaniel Case
e89048f68a Check module names in action plugin without collection attached (#60947)
* Check for eos_config in action plugin by module name, not entire fqmn

* Modify toher action plugins to find module name

* Restore missing `not`

* Cover netconf plugin as well

* Whoops
2019-08-30 21:11:44 -04:00
Sumit Jaiswal
24ad1dffc9 To fix iosxr_l3_interfaces module zuul tests (#61592)
* fix 61540

* fix utils
2019-08-30 19:36:15 -04:00
René Moser
1ff20e9804 apt_repository: implement update cache retrying (#57266)
* use exponential backoff
* make cache update retries and max delay in between configurable
2019-08-30 16:14:15 -04:00
René Moser
fd4ff54580 apt: honor cache_update=false on auto-install deps (#56549)
* apt: honor cache_update=false on auto-install deps
* add porting guide
2019-08-30 15:57:58 -04:00
René Moser
01ae6991bd apt: use exponential backoff for apt update cache retries (#60527)
* make retries and max delay configurable
2019-08-30 15:55:38 -04:00
Mark Chappell
35359959de aws_codecommit: Fix integration tests and Add support for updating the description (#61263)
* Update DevOps AWS policy
- Fix typos in permission names
- While AWS claims you can use 'arn:aws:codecommit:*' it errors unless you use '*'

* aws_codecommit: (integration tests) Migrate to module_defaults

* aws_codecommit: (integration tests) Fix integration tests

* aws_codecommit: (integration tests) Add tests for updating the description

* aws_codecommit: Add support for updating the description and rename "comment" option to "description"
2019-08-30 11:25:37 -07:00
Toshio Kuratomi
8f6dbb732a
[WIP] Cleanups and version bumping for 2.10 (#61572)
* Cleanups and version bumping for 2.10

* Fix changelog url now that stable has been branched

* Fix the lenth of the porting guide title now that the version is two digits
2019-08-30 09:54:12 -07:00
Jordan Borean
951dac7691
Azure fix _info/_facts return values for some modules (#61584)
* Azure fix _info/_facts return values for some modules

* Further test fixes

* securitygroup fixes after the move to _info module
2019-08-30 16:00:47 +10:00
Simon Dodsley
cd24d57636 Add IOPs bandwidth support to volumes (#61577) 2019-08-30 01:12:39 -04:00
Jordan Borean
a7fd6e99d9
Refactor galaxy collection API for v3 support (#61510)
* Refactor galaxy collection API for v3 support

* Added unit tests for GalaxyAPI and starting to fix other failures

* finalise tests

* more unit test fixes
2019-08-30 11:55:19 +10:00
The Magician
82c1becd24 Bug fixes for GCP modules (#61512) 2019-08-29 19:16:36 -04:00
Mike Wiebe
02572cb9ec Rewrite nxos_file_copy as an action plugin (#60643)
* Initial nxos_file_copy action plugin work
* Remove code from nxos_file_copy module
* Add file_push and file_pull support
* Additional refactoring and shipable updates
* Simplify outcomes and update doc header
* Add more error data information for easier debugging
* Reorder outcomes and add additional tests
* Capture more data for permission denied outcome
2019-08-29 12:57:39 -07:00
Simon Dodsley
3881326ae2 Fix crashing bug in purefa_info module and add some new info (#61494) 2019-08-29 13:50:21 -04:00
Ganesh Nalawade
b03fc093b4
Rename junos_lldp_global enable option to enabled (#61551)
*  Change `enable` option to `enabled` option to be in
   sync with other platforms
2019-08-29 22:32:48 +05:30