Commit graph

24589 commits

Author SHA1 Message Date
Gregory Storme
f461025dbb fix facts memtotal_mb rounding on VMWare and swaptotal_mb conversion from KB to MB (#49940) 2018-12-18 08:09:19 +10:00
Jérémy Lecour
2fb9b46752 Lineinfile must not insert lines multiples times with insertbefore/insertafter (#49409)
* Change test suite to fit expected behaviour

This reverts some changes from ansible/ansible@723daf3
If a line is found in the file, exactly or via regexp matching, it must 
not be added again.
insertafter/insertbefore options are used only when a line is to be 
inserted, to specify where it must be added.

* Implement the change in behaviour mentioned in the previous commit

* Fix comment to reflect what the code does

* Set the correct return message.

In these cases, the lines are added, not replaced.

* Add a changelog
2018-12-17 16:42:24 -05:00
Matt Martz
7eb1ab45a7
Allow tags to be templated from a variable (#49833)
* Allow tags to be templated from a variable. Fixes #49825

* Restore _load_tags to ensure we do csv tag splitting

* Add tests for csv tags and templated tags

* evaluate_tags doesn't need to accept strings, because _load_tags handles this
2018-12-17 15:40:26 -06:00
Matt Martz
a0d71e7735
Fix reverse_inventory order to work on python3 (#49895) 2018-12-17 15:39:29 -06:00
Aleksander Kovtunenko
ba562043e1 changed if logic Type to boolean (#49628)
* changed Type to boolean

* fix after review

* created fragment
2018-12-17 16:21:36 -05:00
Dag Wieers
a8292778f0 Fix GitHub handle, use keachi (#50043)
* Fix GitHub handle, use keachi

* Add UTF8 name
2018-12-17 19:35:49 +00:00
Toshio Kuratomi
61b1daa65f Port from plaform.dist to ansible.module_utils.distro.linux_distribution
ci_complete
2018-12-17 11:01:01 -08:00
Adrian Likins
78a8d09082 Changes to bundled distro to be Python-2.6 compatible
* Port bundled distro to use optparse instead of argparse (py2.6)
* Use an absolute import to satisfy the current import testing harness
* Port from subprocess.check_output to subprocess.Popen.communicate() (py2.6)
* Add license location

The changes have been proposed upstream here:
https://github.com/nir0s/distro/pull/232

Upstream is contemplating a branch where everyone wanting python-2.6
support can collaborate without it becoming part of the regularly
supported releases.
2018-12-17 11:01:01 -08:00
Adrian Likins
5e1f8a48f3 Bundle a copy of github.com/nir0s/distro/distro.py
Since the 'platform.dist()' and 'platform.linux_distribution()'
methods will be removed from future versions of python, this
provides an alternative to replace ansibles use of those
methods.

lib/ansible/module_utils/distro.py is a copy of
https://github.com/nir0s/distro/blob/master/distro.py

This module is originally from https://github.com/nir0s/distro
and is license under the Apache License, Version 2.0.
2018-12-17 11:01:01 -08:00
Nathaniel Case
bf4ad56479
Move errors from import to connect (#50034) 2018-12-17 12:33:44 -05:00
Dag Wieers
d4ee599fe9 Add types to common url parameters (#50000) 2018-12-17 11:26:07 -06:00
Dag Wieers
00a83035f2 Meraki: Add types to common parameters (#49998) 2018-12-17 11:24:43 -06:00
Dag Wieers
0eb2924380 MSC: Add type to common module parameters (#49999) 2018-12-17 11:23:51 -06:00
Dag Wieers
e8885ee4e8 ACI: Add types to modules and doc fragment (#49997)
* ACI: Add types to module doc fragment

* Add types to ACI modules too
2018-12-17 11:23:10 -06:00
Dag Wieers
b3f062b5ca Clean up backup doc fragment (#49995) 2018-12-17 10:41:43 -06:00
Dag Wieers
3bcc0c0498 Add types to vmware REST client/VCA doc fragments (#50001) 2018-12-17 10:33:40 -06:00
Dag Wieers
653c3da500 Fix document references in modules (#49892)
* Docs: Fixes internal module reference syntax for seealso
* Updates anchors and links
* Updates seealso in the docs for module **win_chocolatey**.
2018-12-17 10:20:06 -06:00
Martin Nečas
651ea5da44 add to ovirt snapshot download and upload disk (#46696)
* add to ovirt snapshot download and upload disk

* ovirt snapshot update docs

* ovirt snapshot add version_added to docs

* update ovirt snapshot docs
2018-12-17 10:56:27 -05:00
Johannes Brunswicker
87ee59b8d7 Sophos UTM - add module to handle utm ca host key certificate entries (#48927)
* - add module to handle utm ca host key certificate entries

* - fixed typos in doc

* Apply suggestions from code review

Co-Authored-By: MatrixCrawler <johannes.brunswicker@gmail.com>
2018-12-17 11:57:54 +00:00
Andrey Klychkov
b5ca54eeed New module - postgresql_idx (#49684)
* New module - postgresql_idx

* New module postgresql_idx: added returns block

* New module postgresql_idx: fixed documentation, typos and added idxname to fail_json
2018-12-17 11:56:33 +00:00
Dag Wieers
ba573777ba Add types to docker module fragments (#50002) 2018-12-17 11:55:31 +00:00
Deepak Agrawal
0f2f38b044
network_cli - ansible_command_timeout not working as expected (#49922)
* fix for command_timeout

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix ci warning

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix review comments

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
2018-12-17 13:26:23 +05:30
f-bor
134c1a624e new network module: edgeswitch_vlan (#48041)
* initial commit

* better commands generation
2018-12-17 11:30:17 +05:30
anasbadaha
1580afbd62 Fixes #46410 Onyx show facts module does not work for onyx version 3.6.6000 and higher (#49414)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:53:54 +05:30
anasbadaha
369354547e Issue: 46475 Fix onyx magp module for supporting new json format (#49417)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:52:51 +05:30
Zim Kalinowski
de3d188cdd
support lro in azure_rm_resource (#49919) 2018-12-17 13:21:25 +08:00
Toshio Kuratomi
175f3b51e5 Ensure that current uses of BaseException are required
* In some cases, it appears that Exception should have been used instead
  as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
  a library we depend on calls sys.exit() contrary to good coding
  design.  Comment those so that we know that those have been audited
  and found to be correct and change to use (Exception, SystemExit)
  instead.
2018-12-16 15:03:19 -08:00
Toshio Kuratomi
3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Felix Fontein
65d5f1a4ef Fix stacktrace when fail_on_error is False and a file cannot be parsed. (#49987) 2018-12-16 15:26:29 -05:00
anasbadaha
c0dbc1a441 Issue/38837 (#49873)
* Fix Issue #38837

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Issue #38837 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhance decumentation

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Failures in Shippable

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Version Added

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Add version_added:2.8 in purge attributes

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-16 13:16:28 +05:30
Abhijeet Kasurde
1558f77081
AWS: make jittered_backoff API parameter configurable (#49086)
* AWS: make jittered_backoff API parameter configurable
* Review comments
* minor doc changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-16 11:07:59 +05:30
Abhijeet Kasurde
162d9497ba
Ad-hoc command: fix 'any' call in play_ds (#49852)
* Ad-hoc command: fix 'any' call in play_ds
* Unit test for ad-hoc cli
* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-16 11:07:06 +05:30
Abhijeet Kasurde
ef3b75afcd
fortimanager: Correct example documentation (#49925)
Fixes: #49813

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-15 12:10:32 +05:30
Dag Wieers
26474c6902
Add seealso section to Windows and related modules (#49845)
* Add seealso section to Windows and related modules

* Fixes after review
2018-12-15 03:23:59 +01:00
Adam Miller
0eabb8097b
Fix yum/dnf handling of URIs that don't end in .rpm (#49912)
Fixes #49727

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-14 13:44:40 -06:00
Dave Bendit
d62d7176b0 [docker_container] Failing on non-string env values (#49843)
* [docker_container] Failing on non-string env values

Fixes #49802

* Clarify failure message

Co-Authored-By: DBendit <David@ibendit.com>

* Fixup from review
2018-12-14 13:21:54 -06:00
Dave Bendit
c67f4290e6 [docker_volume] Checking option minimal versions (#49839)
Fixes #38833
2018-12-14 13:20:48 -06:00
Akshay Gaikwad
1e0363ec7d Support for cache_from parameter in docker_image module (#49787)
* Support for cache_from parameter in docker_image module

Fixes #21704

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Minimum docker version check for cache_from option

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add changelog fragment

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* cache_from fix when docker-py is older

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-14 13:19:40 -06:00
Chad Anderson
6ff7797eaa Move verify up so approle and other methods work as intended. 2018-12-14 11:14:12 -08:00
Giuseppe Mancuso
d29f647f09 issue with activation_key and proxy on subscription-manager (#42624)
* Update redhat_subscription.py

I need to use a proxy server/user/password also if I user an activation_key

* remove spaces
2018-12-14 12:27:58 -05:00
Petr Ruzicka
1c8f5c7db5 with_items should not be used any more - using loop instead (#47364) 2018-12-14 12:13:32 -05:00
Petr Ruzicka
0957b37721 with_items should not be used any more - using loop instead (#47652) 2018-12-14 11:17:21 -05:00
Abhijeet Kasurde
013c42b14f
Misc typo fixes (#49816)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-14 15:12:58 +05:30
Yuwei Zhou
7609a8cdd6 support overprovision in azure_rm_vmss (#49806) 2018-12-14 16:48:40 +08:00
Deepak Agrawal
f2eef2d30b
ignore connection timeout out within parenthesis (#48413) 2018-12-14 11:22:10 +05:30
anasbadaha
fb8b59fcc6 Get Capabilities Support (#49880)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-14 09:45:31 +05:30
Jordan Borean
4019d4f6d1
Windows Privileges - moved util code to it's own C# util (#48897)
* Windows Privileges - moved util code to it's own C# util

* Rename Enabler class to PrivilegeEnabler to remove ambiguity

* rename Utils to PrivilegeUtil

* fix missing util name changes
2018-12-14 12:00:46 +10:00
Loïc Blot
c97d2c25b4 postgresql_schema: permit to drop cascade schema (#49469)
* postgresql_schema: permit to drop cascade schema

* Doc fix

* typo fix
2018-12-13 19:03:48 -05:00
Dag Wieers
a4998cfead
ACI: Add seealso fragments to module documentation (#49844) 2018-12-13 19:40:53 +01:00
Dag Wieers
994ce2126a win_updates Add information/example wrt. reboots (#49834)
This documents two common issues related to rebooting Windows systems.
- Updates can take a long time being applied during reboot
- Reboots can cause the WinRM service to start before system has settled
2018-12-13 09:38:11 -06:00