Commit graph

27371 commits

Author SHA1 Message Date
Dag Wieers
a417a4f4b3 Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
2016-12-08 11:35:09 -05:00
Nijin Ashok
b06003e5d2 Fix issue in adding RAW disk in block storage domain (#3432)
By default, sparse option is true in ovirt. So the raw disk
    creation in a block storage domain will fail with error "Disk
    configuration (RAW Sparse) is incompatible with the storage domain
    type".

    The commit adds sparse option where it is send as False when
    format is raw and True when format is qcow2
2016-12-08 11:35:09 -05:00
Maarten Bezemer
dd51ec94e7 mongodb_user: Allow pymongo version 3.2 in combination with mongodb 3.2 (#3474) 2016-12-08 11:35:09 -05:00
René Moser
ae9bc0cded cloudtack: cs_instance: doc fix for missing tag alias (#3484) 2016-12-08 11:35:09 -05:00
René Moser
a0c8b598ff cloudstack: fix state=absent, ip_address not None but falsy (#3483) 2016-12-08 11:35:09 -05:00
Abdoul Bah
318a06f6d6 New module proxmox_kvm (#3292)
* New module proxmox_kvm

* fixed qxl value vor vga param

> | Name | Type | Format | Description |
> |------|------|--------|-------------|
> | vga | enum | std \| cirrus \| vmware \| qxl \| serial0 \| serial1 \| serial2 \| serial3 \| qxl2 \| qxl3 \| qxl4 | Select the VGA type. If you want to use high resolution modes (>= 1280x1024x16) then you should use the options 'std' or 'vmware'. Default is 'std' for win8/win7/w2k8, and 'cirrus' for other OS types. The 'qxl' option enables the SPICE display sever. For win* OS you can select how many independent displays you want, Linux guests can add displays them self. You can also run without any graphic card, using a serial device as terminal. |

* Fix create_vm() fail on PV 4.3

* Set default for force as null in doc

* proxmox_kvm: revision fixes

* proxmox_kvm: more revision fixes

* Fix indentation

* revision fixes

* Ensure PEP-3110: Catching Exceptions

* KeyError, to KeyError as -- PEP-3110: Catching Exceptions

* Fix Yaml document syntax; Notes: => Notes -

* Refix documentation issue

* Fix Documentation

* Remove Notes: in description

* Add current state and it return value

* Update documentation

* fixed local variable 'results' referenced before assignment

* Fix fixed local variable 'results' referenced before assignment

* minor fixes in error messages

* merge upstream/devel int devel

* minor fixes in error messages

* Fix indentation and documentation

* Update validate_certs description
2016-12-08 11:35:09 -05:00
Brian Haggard
84e79770b3 Required and default are mutually exclusive (#3475) 2016-12-08 11:35:09 -05:00
René Moser
72eb8c7be9 ipify_facts: implement timeout (#3369) 2016-12-08 11:35:08 -05:00
jctanner
d2bb9c1298 vmware_guest: Fix the esxi_hostname docstring to match the arg dict's required= (#3479)
Fixes #3476
2016-12-08 11:35:08 -05:00
Davis Phillips
c2dcf62aee removed tabs and fixed formatting 2016-12-08 11:35:08 -05:00
Davis Phillips
24e8428a7b mend 2016-12-08 11:35:08 -05:00
Davis Phillips
e51f6c18eb added vDS support for config spec and note/annotation support 2016-12-08 11:35:08 -05:00
Toshio Kuratomi
4d3fec908b Remove need for translate/maketrans due to py3 differences
* translate() has a different api for text vs byte strings
* maketrans must be imported from a different location on py2 vs py3

Since this is such a small string outside of a loop we don't have to
worry too much about speed so it's better to have a single piece of code
that works on both py2 and py3
2016-12-08 11:35:08 -05:00
Abdul-Anshad-A
c2f4e7c852 Initial effort for pyVmomi snapshot ops
Make description optional during snapshot create
2016-12-08 11:35:08 -05:00
Davis Phillips
ce7c7b6804 Removed list value from description in dns_servers 2016-12-08 11:35:08 -05:00
Davis Phillips
bb017c4af8 updated version_added to 2.3 2016-12-08 11:35:08 -05:00
Davis Phillips
ae9aa2390f Added version_added to all the new params 2016-12-08 11:35:08 -05:00
Davis Phillips
ebdd9cf1a5 remove commented code and fixed formatting 2016-12-08 11:35:08 -05:00
Davis Phillips
995cc2cd2d closes 3305 adds customize support 2016-12-08 11:35:08 -05:00
Rene Moser
e1d79f341e cloudstack: new module cs_vpc 2016-12-08 11:35:08 -05:00
René Moser
8873263894 cloudstack: add new module cs_nic (#3392) 2016-12-08 11:35:08 -05:00
Fabio Alessandro Locati
9a1b5b5e18 Use native YAML (#3435) 2016-12-08 11:35:08 -05:00
Tristan Bessoussa
f68a45ca9a Fixed wrong variable name in the let's encrypt doc (#3398)
It could lead to unwanted error when dummy-paste to try this module.
2016-12-08 11:35:07 -05:00
James Hart
276c3410a5 consul: Pass through service_id if specified on a check (#3295)
Fixes #3249
The python-consul library already supports this, so it is just a simple
case of enablement.
This does not break the current logic in `add` of parsing as a check,
then parsing as a service if that fails… because service_name is
mandatory on a service registration and is invalid on a check
registration.
2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
39f4e17838 Improve yaml code and add an if to make the import more standard (#3424) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
7af000bdb1 Use native YAML (#3436) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
1e00adefd5 Use native YAML in the examples (#3441) 2016-12-08 11:35:07 -05:00
Matthieu Dolci
8822021132 ec2_customer_gateway: state present expect bgp_arn instead of bgp_asn (#3366) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
69fa44b6d1 Use native YAML (#3437) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
616c86529f Use native YAML (#3438) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
be834293ed Use native YAML (#3439) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
0a338a11c2 Normalize yaml example (#3426) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
df6200accc Normalize yaml example (#3425) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
07d96b62b5 Use native YAML (#3434) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
47297bb19c Use native YAML (#3433) 2016-12-08 11:35:07 -05:00
mattwwarren
727e533bfc ec2_elb_facts: fix errors with no names input (#3381)
* None being passed around results in a Bad Time (tm)

* need to return the full set of elbs for an empty list

* logic is hard
2016-12-08 11:35:07 -05:00
Jose Armesto
14fee8d5f7 ec2_lc_find: Set default value for AssociatePublicIpAddress, since is missing when is false (#3417) 2016-12-08 11:35:07 -05:00
Thomas Krahn
9814136d3e Ipa bugfixes (#3421)
* ipa_group: Fix: 'list' object has no attribute 'get'

* ipa_hbacrule: Fix: 'list' object has no attribute 'get'

* ipa_host: Fix: 'list' object has no attribute 'get'

* ipa_hostgroup: Fix: 'list' object has no attribute 'get'

* ipa_role: Fix: 'list' object has no attribute 'get'

* ipa_sudocmd: Fix: 'list' object has no attribute 'get'

* ipa_sudocmdgroup: Fix: 'list' object has no attribute 'get'

* ipa_sudorule: Fix: 'list' object has no attribute 'get'

* ipa_user: Fix: 'list' object has no attribute 'get'

* ipa_sudorule: Fix: invalid 'cn': Only one value is allowed

* ipa_hostgroup: module returns changed if assigned hosts or hostgroups are not in lowercase
2016-12-08 11:35:06 -05:00
Jason Ritchie
0f6aa07d88 Detect and correct PowerShell mishandling nssm Unicode output as UTF8 (#2867)
* extra detail on which step triggered 'change', detect and handle powershell mishandling nssm's unicode as utf8

* Simpler handling of nssm output encoding

Thanks @nitzmahone for a cleaner way to control PowerShell's behavior
2016-12-08 11:35:06 -05:00
Henrique Rodrigues
54c5ebf697 New ec2_group_facts module to be able to get facts from EC2 security groups (#2591)
Add `ec2_group_facts` module to gather facts from EC2 security groups
2016-12-08 11:35:06 -05:00
Andrew Gaffney
a8d80f7165 Fix bare variable references in docs 2016-12-08 11:35:06 -05:00
Krzysztof Magosa
c6b08ca623 tempfile: simple module creating temporary files/directories in OS-independent manner (#2991) 2016-12-08 11:35:06 -05:00
René Moser
de3aea7c36 cloudstack: cs_ip_address: fix returns on state=present (#3406)
In case poll_job=false the return must be None
2016-12-08 11:35:06 -05:00
René Moser
0324d7a681 new module nginx_status_facts (#3286)
* new module nginx_status_facts

* nginx_status_facts: remove requirement

* nginx_status_facts: implement timeout param

* nginx_status_facts: update example docs
2016-12-08 11:35:06 -05:00
jctanner
46174588ca Refactor usage of type() (#3412)
Addresses https://github.com/ansible/ansible/issues/18440
2016-12-08 11:35:06 -05:00
Jeremy Olexa
e44362b6f8 consul_kv, consul_acl: fix missing types bool (#3327)
* Specify bool in consul_kv: validate_certs param
* Specify bool in consul_acl: validate_certs param
* Specify bool in consul_kv: retrieve param
2016-12-08 11:35:06 -05:00
Christophe Biocca
55130b960b haproxy: Fix compatibility when map is actually imap. (#3350)
While I still have no idea why or how the `map` call is being swapped out while still running in python 2.7, this change will fix the following error, as well as improve py3 compatibility.
2016-12-08 11:35:06 -05:00
jctanner
b3795322e9 More isinstance fixes (#3405)
* More isinstance fixes
* Use double types
2016-12-08 11:35:06 -05:00
Thomas Krahn
32fef233f2 Add FreeIPA modules (#3247)
* Add FreeIPA modules

* Update version_added from 2.2 to 2.3

* ipa_*: Use Python 2.4 syntax to concatenate strings

* ipa_*: Replace 'except Exception as e' with 'e = get_exception()'

* ipa_*: import simplejson if json can't be imported

* ipa_hbacrule: Fix: 'SyntaxError' on Python 2.4

* ipa_sudorule: Fix: 'SyntaxError' on Python 2.4

* ipa_*: Fix 'SyntaxError' on Python 2.4

* ipa_*: Import get_exception from ansible.module_utils.pycompat24

* Add FreeIPA modules

* Update version_added from 2.2 to 2.3

* ipa_*: Fix 'SyntaxError' on Python 2.4

* ipa_*: Replace Python requests by ansible.module_utils.url

* ipa_*: Replace Python requests by ansible.module_utils.url

* ipa_*: Add option validate_certs

* ipa_*: Remove requests from Ansible module documentation requirements

* ipa_sudorule: Remove unnecessary empty line

* ipa_sudorule: Remove markdown code from example

* ipa_group: Add choices of state option

* ipa_host: Rename options nshostlocation to ns_host_location, nshardwareplatform to ns_hardware_platform, nsosversion to ns_os_version, macaddress to mac_address and usercertificate to user_certificate and add aliases to be backward compatible
2016-12-08 11:35:06 -05:00
Kei Nohguchi
cc95bc4935 openvswitch_bridge: Check VLAN ID only under fake bridge (#3374) 2016-12-08 11:35:06 -05:00