Commit graph

6181 commits

Author SHA1 Message Date
Matt Martz
6ca357198e Clean up some required argument logic 2015-01-16 15:33:41 -06:00
Matt Martz
ee928dc000 Merge pull request #650 from sivel/rax-clb-nodes-bad-logic
rax_clb_nodes: It is not correct that you need at least 1 primary node
2015-01-16 08:55:37 -06:00
Matt Martz
8609a50450 Merge pull request #652 from sivel/rax-clb-required
rax_clb: Just use built in required functionality for arguments
2015-01-16 08:54:34 -06:00
Matt Martz
d2829c2510 Just use built in required functionality for arguments 2015-01-15 19:27:34 -06:00
Matt Martz
b2fd4d18e0 It is not correct that you need at least 1 primary node 2015-01-15 19:20:36 -06:00
Tim G
8f43a0a4fe Load distutils on all platforms EXCEPT Solaris.
Solaris doesn't ship distutils with with the default Python package.  This patch fixes "service" on Solaris since 30d6713.
2015-01-16 10:06:36 +10:00
Brian Coca
9ac5ed2621 now allows for case in which someone removed the K* links and is trying
to reenable a service
2015-01-15 15:53:39 -05:00
Brian Coca
f4a709ad7c simplified update-rc.d enable/disable handling, removed forced defaults
creation as that breaks local customizations
2015-01-15 15:32:19 -05:00
Toshio Kuratomi
e3759bd0d3 Add detection of uid,gid,mode changes when deciding whether an archive
needs to be unarchived again.
2015-01-14 19:20:07 -08:00
Brian Coca
e8a0ed31db Merge pull request #646 from bcoca/apt_fix_fetch_exception
now captures cache fetch failures
2015-01-14 17:53:22 -05:00
Brian Coca
e2dcb5fc9b now captures cache fetch failures 2015-01-14 17:29:00 -05:00
Toshio Kuratomi
44ec0d735e Merge pull request #642 from ansible/apache2-module-better-error
Better error messages if a2enmod/a2dismod are not found
2015-01-14 13:16:33 -08:00
Toshio Kuratomi
6159b5c423 Implement user,group,mode,selinux settings for unarchive.
This is a partial fix for #234.  Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
2015-01-14 13:11:33 -08:00
Toshio Kuratomi
7f527eefbb Merge pull request #638 from alexclifford/devel
Fix slight typo in doco
2015-01-13 23:22:27 -08:00
Toshio Kuratomi
477391bb24 Better error messages if a2enmod/a2dismod are not found 2015-01-13 23:18:04 -08:00
Toshio Kuratomi
4c50fbedf4 Merge pull request #632 from mscherer/fix_uneeded_echo
Do not use echo shell builtin for password
2015-01-13 23:05:58 -08:00
Toshio Kuratomi
6cbce4d911 Potential fix for 640 2015-01-13 22:39:20 -08:00
Tim G
68b5b7be72 distutils is not available on some non-Linux OS's 2015-01-14 13:15:38 +10:00
Alex Clifford
d2ae2e6cc6 Fix slight typo in doco 2015-01-14 12:12:02 +11:00
Brian Coca
7fc142cc13 Merge pull request #634 from br0ziliy/fix-gce-net-src-tags-param-parsing
gce_net - creating firewall rule, src_range value seems to get lost or set to empty string
2015-01-13 11:10:36 -05:00
Brian Coca
0edfdca58b Merge pull request #105 from luisguilherme/devel
ec2_lc does not create valid launch configuration for EC2-Classic
2015-01-13 11:04:21 -05:00
Toshio Kuratomi
fbb9dcc69a Also catch mysql errors so we can give the error message back through json rather than tracebacking 2015-01-12 14:37:44 -08:00
Toshio Kuratomi
c9c08f885a Merge pull request #619 from bpennypacker/requiressl
mysql_user module: Added support for 'REQUIRE SSL' grant option
2015-01-12 14:29:32 -08:00
Michael Scherer
826d313aad Do not use echo shell builtin for password
Using \t in a password may result in a different password
being set :

    $ echo 'a\ta'
    a   a

Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
2015-01-12 19:30:07 +01:00
Brian Coca
8c8be0e48c Merge pull request #572 from jrobeson/rename-fedora-hostname-strategy
[hostname] rename FedoraStratgy to SystemdStrategy
2015-01-12 10:56:55 -05:00
Michael Scherer
bcfba0c050 Remove unused code
There is no call to yum_base using 'cachedir' argument, so
while it work fine from a cursory look, that's useless code,
and so should be removed to clarify the code.
2015-01-12 01:02:29 +01:00
Michael Scherer
0b2d190f72 Use the rpm python module rather than execing rpm
Using the rpm module prevent a uneeded fork, and permit
to skip the signature checking which slow down a bit the
operation, and which would be done by yum on installation
anyway.
2015-01-11 05:02:51 +01:00
Michael Scherer
e025b591d3 Remove unused option in the repoquery call
Citing the man page:
       -q, --query
              For rpmquery compatibility, doesn't do anything.
2015-01-11 03:57:53 +01:00
Bruce Pennypacker
272bb1fa63 requested changes 2015-01-08 21:41:15 +00:00
Michael DeHaan
d3297dc8a8 Merge pull request #598 from jsmartin/fix_asg_zone_identifier
vpc_zone_identifier must be a csv string when an asg is updated.
2015-01-08 13:46:16 -05:00
Bruce Pennypacker
a07873d6a3 Added support for 'REQUIRE SSL' grant option 2015-01-08 16:26:22 +00:00
Toshio Kuratomi
4cf6725cab Merge pull request #93 from natefoo/hg-bugfix
Fix numerous bugs in the hg module
2015-01-07 16:37:58 -08:00
James Martin
242aa9f81b vpc_zone_identifier must be a csv string when an asg is updated. 2015-01-07 14:39:28 -05:00
Toshio Kuratomi
6339297abb Merge pull request #606 from bcoca/file_link_permissions
fix for allowing permissions on hard links and soft links + follow=yes
2015-01-07 10:58:25 -08:00
Brian Coca
78cacd0c22 fix for allowing permissions on hard links and soft links + follow=yes 2015-01-07 13:16:53 -05:00
Toshio Kuratomi
022e5274e6 Merge pull request #460 from jbinto/file_allow_touch_hardlink
Files module: Allow touch on hardlinks
2015-01-07 09:04:01 -08:00
Toshio Kuratomi
2973bac72f Clarify documented behaviour of user module's ssh_key_file parameter
Fixes #9873
2015-01-07 08:46:42 -08:00
Brian Coca
8d35d1e9df Merge pull request #162 from RickyCook/devel
Warn option left out of command module args
2015-01-06 18:58:55 -05:00
Toshio Kuratomi
1ca8b42770 Merge pull request #599 from bcoca/vmware_template_version
added version added for new template options
2015-01-06 13:38:18 -08:00
Brian Coca
53404c786a added version added for new template options 2015-01-06 16:06:45 -05:00
Vasyl Kaigorodov
c1eb7a4c1d gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252 2015-01-06 20:44:09 +01:00
Brian Coca
4da7f427e8 Merge pull request #596 from bcoca/dir_symlink_follow
fix for directory symlink and follow=yes
2015-01-06 12:14:42 -05:00
Brian Coca
76e75b6024 Merge pull request #2 from atlashealth/ec2_detach_volume
Ability to detach an EBS volume from an EC2 instance
2015-01-06 12:06:16 -05:00
Brian Coca
6237dab4cf fix for when state=directory, follow=yes and target is symlink to directory 2015-01-06 10:06:50 -05:00
Luís Guilherme F. Pereira
cfda942376 Allow ec2_lc to create EC2-Classic Launch Configs
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
2015-01-06 09:30:44 -02:00
Jonathan Armani
f13e3c9147 Merge pull request #4 from eest/openbsd_rcctl
Handle string returned by 'default' correctly.
2014-12-31 14:32:12 +01:00
Philip Misiowiec
71d1044b8b Adds tenancy state to returning json 2014-12-31 00:45:57 -08:00
Philip Misiowiec
ad7f5abf28 Ability to detach an EBS volume from an EC2 instance 2014-12-30 23:17:49 -08:00
Toshio Kuratomi
0d551d8d24 Merge pull request #567 from FabioBatSilva/devel
handle list of lists - python-apt < 0.7.9 compatibility
2014-12-30 11:12:29 -08:00
tedder
c5fe40661d feature pull request: catch and retry recoverable errors
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
2014-12-29 17:19:12 -08:00