Commit graph

480 commits

Author SHA1 Message Date
Matt Jeffery
8131feaade Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
C. Morgan Hamill
5776c95497 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
2014-02-18 15:20:12 -05:00
Nils Pascal Illenseer
858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
Richard C Isaacson
7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
Peter Gehres
c427a829a0 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
2014-02-13 23:05:00 -08:00
Sean Chittenden
5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
Brian Coca
f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
Brian Coca
a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Brian Coca
0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-02-06 11:59:37 -05:00
Brian Coca
de956c57fe changes names to name in example 2014-02-05 18:28:17 -05:00
Brian Coca
453d473728 fixes as per feedback 2014-02-05 18:08:01 -05:00
Tom Dymond
486d14cb2d Reworked PR to avoid repeating the command 2014-02-05 15:35:24 +00:00
jctanner
5967b463c9 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
2014-02-04 10:59:19 -08:00
Tom Dymond
cf80f9b68b Add option to enable the sysctl -e option 2014-02-04 18:19:28 +00:00
kustodian
a7839208c7 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
2014-01-29 23:39:43 +01:00
Aaron Lindsay
59ac969d2b Add move_home option to user module 2014-01-29 14:10:26 -05:00
Richard C Isaacson
7a2df2733f Tested implementation adding action option for (add, delete, unique). 2014-01-28 20:29:41 -05:00
Richard C Isaacson
c198217900 Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
cd871384de Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
b00939acff Change to dynamically pick up the command from the PATH. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
9650c118cf Formating and syntax fixes that were pointed out during code review. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
ec04e30186 Added user option. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
3a7e579bc2 First commit of the at module being very basic. 2014-01-28 20:29:41 -05:00
Brian Coca
46dfe07181 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-01-28 14:49:57 -05:00
Jakub Jirutka
8c9a63bcd0 sysctl: parse bool value as 0/1 and refactor a little bit 2014-01-27 20:26:11 +01:00
Thoai Nguyen
5c4bb5730e reorder usermod options 2014-01-22 15:27:00 -05:00
jctanner
7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
2014-01-20 06:11:29 -08:00
Augustus Kling
c3f182bc9b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 2014-01-20 00:11:01 +01:00
Augustus Kling
1fb830fba6 Merge remote-tracking branch 'upstream/devel' into locale 2014-01-19 23:51:27 +01:00
Augustus Kling
6b75e75161 Handle install/uninstall of locales for Ubuntu, too. 2014-01-19 23:35:10 +01:00
Simon Zimmermann
3db808c840 correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
055b404f13 Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Simon Zimmermann
7495095496 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
James Tanner
3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
2a46022bc7 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
2014-01-16 17:55:24 -08:00
jctanner
450bb37c8c Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
2014-01-16 14:22:57 -08:00
James Tanner
19cb22b6df Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
2014-01-16 16:30:13 -05:00
rishid
34f9349b5e Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
2014-01-16 16:08:51 -05:00
Scott Gilbert
0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
2c39576e80 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
James Tanner
e22af253bb Fixes #5486 Keep authorized key options in tact and ordered 2014-01-15 17:10:10 -05:00
James Tanner
c627358c37 sysctl module: append newline character to lines in the file 2014-01-15 10:25:27 -05:00
Michael DeHaan
6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
2014-01-15 09:52:17 -05:00
jctanner
332d3d6a0e Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
2014-01-14 14:44:51 -08:00
jctanner
6e39adb89e Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
2014-01-14 13:00:08 -08:00
James Tanner
17c50cc81e sysctl module: fail if reloading the file did not succeed 2014-01-14 10:48:57 -05:00
James Tanner
ca05584495 Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
2014-01-13 18:53:02 -05:00
Tyler
2f813f7660 keep /usr/local/etc/rc.conf for backwards compatibility 2014-01-08 14:38:49 -05:00
Tyler
1a655b2dd7 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
2014-01-08 13:48:11 -05:00
Joshua Lund
3b4f3f8ca3 Improved the documentation for password generation 2014-01-07 18:20:39 -07:00
James Tanner
dee960716b Fixes #5353 create etc/hostname file in debian if it does not exist 2014-01-07 15:53:16 -05:00
Michael DeHaan
1e6926b9ab Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
2014-01-07 15:51:21 -05:00
Paul Beattie
e96377685e Fixed typo in example documentation 2014-01-04 00:22:14 +00:00
rgbj
f2150b101e On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 2014-01-03 15:41:12 +01:00
jctanner
89abc35e59 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
2014-01-02 20:24:00 -08:00
James Tanner
86719ce77f Fixes #5040 setup module: do not add primary interface info to the secondary interface data 2014-01-02 16:17:24 -05:00
lichesser
b49cb2e540 Partial fix for #4565. Works only for Debian 7 and later 2013-12-26 17:53:17 +01:00
Michael DeHaan
aa8beadec3 Fix a documentation item. 2013-12-25 13:50:15 -05:00
Augustus Kling
6d1c2a92de Basic handling of locales. 2013-12-24 12:29:02 +01:00
Brian Coca
35980ef329 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 14:09:15 -05:00
Brian Coca
c2c0d9bcd7 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:48:53 -05:00
Brian Coca
555f12c59a did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:35:27 -05:00
Jasper N. Brouwer
a52ca73167 Swapped conditions of the changed if statements 2013-12-23 09:54:16 +01:00
Brian Coca
821aa432a6 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-20 12:50:06 -05:00
Brian Coca
307ab1f561 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:22:05 -05:00
Brian Coca
fd78916a73 fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:21:00 -05:00
Brian Coca
175d6346a2 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 16:54:02 -05:00
jctanner
91f903eabe Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
2013-12-13 11:25:45 -08:00
jctanner
dc41912158 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
2013-12-12 15:32:59 -08:00
Dimos Alevizos
8c73aa13e4 Minor changes to simplify code 2013-12-08 09:02:50 +02:00
David Hummel
cc3678730c Fix issue #5214: hostname persistence on RedHat/CentOS 2013-12-07 21:10:42 -05:00
Dimos Alevizos
de4e4c54b9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 2013-12-07 17:16:20 +02:00
jeromew
1916e8ec90 user module: force= and remove= should not be mutually exclusive 2013-12-05 17:07:24 -05:00
jctanner
5e336d7caf Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
2013-12-05 13:34:57 -08:00
gservat
db2f41bdcb This change is meant to replace distribution_release, not version! 2013-12-06 07:53:39 +11:00
gservat
83f35a63dd Oops... fixed an error 2013-12-06 07:49:03 +11:00
Alfons Zitterbacke
5390ee9763 added AIX network facts 2013-12-05 10:13:55 +01:00
Alfons Zitterbacke
cc783b3e1b added AIX network facts 2013-12-05 10:06:44 +01:00
James Tanner
cbfeb0a2ea Fixes #5169 Evaluate check_mode in the user module SunOS class 2013-12-05 00:44:55 -05:00
Jasper N. Brouwer
0e11e4c86f Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
2013-12-04 21:49:00 +01:00
jctanner
2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
2013-12-03 12:34:55 -08:00
jctanner
872a1ee39b Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
2013-12-02 14:02:43 -08:00
jctanner
ef92b2cb12 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
2013-12-02 13:38:32 -08:00
James Tanner
ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
James Tanner
c050872458 Fixes #4796 handle unicodedecode errors from dmidecode output 2013-12-02 11:56:38 -05:00
Michael DeHaan
5efcf265d1 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
2013-12-01 14:27:40 -08:00
Matthias Blaser
9d442243ab rewrite options to dict parser, fixes #5032 2013-11-30 09:03:35 +01:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
dragon3
d39e6fda92 hostname module: add support for Amazon Linux 2013-11-28 09:31:25 +09:00
gservat
13da2c3ac9 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
2013-11-27 23:44:34 +11:00
Sam Hartsfield
ae7735b45d Fixed hostname module for RHEL6 Workstation 2013-11-26 11:36:10 -05:00
James Tanner
7be13faae8 Fix comment yaml escaping in authorized_key module 2013-11-26 08:54:19 -05:00
James Tanner
4ba51eef6f Save comment hashes in sshkeys 2013-11-25 23:46:48 -05:00
James Tanner
16b22d0d64 Cleanup debug statements 2013-11-25 22:16:04 -05:00
James Tanner
b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 2013-11-25 22:13:42 -05:00
James Tanner
d187066339 Fixes #5010 Add user to all defined supplementary groups 2013-11-25 14:56:46 -05:00
Jens Rantil
883f37e404 Improved documentation of mount module
Mentioning the fact that mount point directories are created and
removed.
2013-11-25 13:58:00 +01:00
James Tanner
32986c4d64 Fixes #5021 safely split hostkeys with quotes 2013-11-22 16:36:31 -05:00
James Tanner
1d24bcc916 Fix pep8 error in hostname module 2013-11-19 16:39:48 -05:00
Michael DeHaan
5e0c6e0af3 Merge pull request #4868 from hnakamur/rhel5_hostname_fix
hostname module fix for RHEL5
2013-11-19 11:38:29 -08:00
Michael DeHaan
b29669dccd Remove the 'host' module for now because the alias handling involves a bit too much automagic. Proposal is to come up with a spec
of how it should work and accept to spec, using the existing patch (cherry-picked) as a baseline.
2013-11-19 14:12:45 -05:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Michael DeHaan
2726b13245 Changelog updates and a few module renames. vpc -> ec2_vpc, githooks -> github_hooks, blacklist -> kernel_blacklist. These are all new in 1.4 so safe to change. 2013-11-18 18:28:21 -05:00
Sergey Sudakovich
4d0f374dbf compatible with python 2.4 2013-11-18 11:33:04 -08:00
jctanner
dc5b952854 Merge pull request #4910 from matze/add-system-blacklist-module
Add system module to blacklist kernel modules
2013-11-15 11:06:05 -08:00
Rene Moser
0c70e898cc host: fix bug, alias was not removed 2013-11-15 14:04:41 +01:00
Rene Moser
6da2d55007 host: removed unused self_has_aliases 2013-11-15 14:04:40 +01:00
Rene Moser
a61f46f4f0 host: skip lines beginning with new line 2013-11-15 14:04:40 +01:00
Rene Moser
ca5e5cfebc host: fix changed is not available on fail 2013-11-15 14:04:40 +01:00
Matthias Vogelgesang
e5ef5e29ec Add system module to blacklist kernel module 2013-11-15 10:34:55 +01:00
nextus
17cbbcdd30 Don't allow cron module to delete cron_file without name parameter assignment 2013-11-14 13:24:14 +04:00
nextus
a43aaaecd0 Fix: absent state removing whole cron.d file instead of specific job 2013-11-13 23:58:37 +04:00
James Tanner
7eadf78009 Merge pull request #4282 from cristobalrosa/ansible
Add a fact for checking if interface is in promiscuous mode.
2013-11-13 10:33:57 -05:00
Sergey Sudakovich
24ea5949bb fix when the system does not have lsb_release script, but has /etc/lsb_release file 2013-11-12 15:25:39 -08:00
James Tanner
6008ea40ee Add more error detail to the service module for FreeBSD 2013-11-12 00:02:30 -05:00
jctanner
ec55268738 Merge pull request #4304 from ferringb/fixes/cron-permissions
Enforce umask for cron module, so cron_file generated files are 0644.
2013-11-11 14:23:39 -08:00
Hiroaki Nakamura
63a552b2d3 Apply the same change as https://github.com/hnakamur/ansible-playbooks/pull/2 2013-11-10 08:28:33 +09:00
James Tanner
fa62ee46bf Set the correct version added for the hostname module 2013-11-07 22:01:02 -05:00
jctanner
01a054d2be Merge pull request #3940 from hnakamur/hostname_module
Add a hostname module, which sets system's hostname.
2013-11-07 15:11:06 -08:00
James Tanner
ce29c158a9 Address #4573 Check interface keys and return gracefully on solaris zones 2013-11-06 18:11:22 -05:00
Jim Richardson
bbfe11fc1e return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
Jim Richardson
bcc08564e7 fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Hiroaki Nakamura
abed2c47fa Fix for RHEL6. 2013-11-01 23:32:14 +09:00
Michael DeHaan
3705f41992 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
9e7b02aaee make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
James Tanner
d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 2013-10-30 10:50:16 -04:00
jctanner
a1fcaf5c61 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
3f0b3a71ca Fix #4702, make setup work on windows 2013-10-28 23:41:18 +01:00
James Cammarata
0e9184eefd Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
Christian Berendt
2848cf34fc changing permissions of modules to 0644 2013-10-28 14:50:35 +01:00
Michael DeHaan
3badedc983 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
d0904ded84 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
b725361bce Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
James Tanner
40574c1938 Fixes #4448 reloaded services should be started if not running 2013-10-25 15:30:02 -04:00
James Cammarata
aa0577c211 Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 2013-10-24 20:13:38 -05:00
James Cammarata
b58b287fce Fixing up authorized_keys to accept comments with spaces 2013-10-24 20:12:56 -05:00
Michael Scherer
951a91723d make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
7672e9fef8 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
264945a1f7 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
Scott Sturdivant
4d24e2e29f If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
Eugene Archibald
30eb5c7342 Fixed (broken) tab to (correct) spaces for indentation 2013-10-19 17:04:37 -07:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
75e0a1c6de Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Eugene Archibald
145c0b8be1 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 2013-10-18 20:32:35 -07:00