Commit graph

46221 commits

Author SHA1 Message Date
Matt Clay
44a262714c
Add common sanity ignore & skip to ansible-test. (#59416)
* Add common sanity ignore & skip to ansible-test.
* Switch ansible-doc sanity test to single version.
* Remove duplicate ignore entry.
2019-07-23 13:31:54 -07:00
Chaz Ruhl
aebc3b0730 Update cobbler_system.py (#59316)
State was not referenced appropriately in doc examples.
2019-07-23 15:13:07 -05:00
Nathan Swartz
6a77533b57 Specify type-str for common NetApp E-Series documention options. (#59459) 2019-07-23 14:38:11 -05:00
Shachaf92
092e5515d1 win_firewall_rule - update doc for localport dep. on protocol (#59467) 2019-07-23 14:37:08 -05:00
UNR Information Security
7b4ce9e4ae Update find.py (#59456)
Return values for `matched` and `examined` in the find module are integers and not strings.
2019-07-23 13:51:56 -05:00
Sandra McCann
cb1dd6d77b remove molecule mentions (#59441) 2019-07-23 13:12:13 -05:00
Toshio Kuratomi
67fb3a8215 Fix root filter test
On python-2.6 the error message is different
2019-07-23 09:50:47 -07:00
Felix Fontein
266d6e77a9 Re-enable docker_container tests (#59425)
Mark dependent container's ipc_mode as shareable
2019-07-23 10:20:18 -04:00
Andrey Klychkov
333953117c Add human_to_bytes isbits arg unit tests&docstring
PR #58623

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-07-23 14:56:56 +02:00
Xu Yuandong
133cb945ae update to fix bugs. (#59345) 2019-07-23 06:30:45 -04:00
Martin Nečas
1998c9c19d add example (#59287) 2019-07-23 06:05:17 -04:00
Martin Nečas
8ee587aa7d ovirt add template cluster (#59378)
* ovirt add template cluster

* update doc

* add global search fallback

* update docs
2019-07-23 06:04:42 -04:00
Xu Yuandong
f1dbf6292b update to "state is present but all of the following are missing: password" bug (#59344) 2019-07-23 05:56:01 -04:00
Xu Yuandong
b728347260 ce_bfd_session: update & add 2 params. (#59333)
* update & add 2 paramers.

* update for shippable

* update for shippable
2019-07-23 03:38:27 -04:00
Ganesh Nalawade
1092ee55d4
Add [junos_lag_interfaces] resource module (#59011)
* Add junos_lag_interfaces resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/29
*  Deprecate junos_linkagg module

* Fix CI issues

* Fix junos integration test cases

* Fail if base lag interface is not configured
2019-07-23 11:53:15 +05:30
Trishna Guha
3bad4d6a50
Add nxos_lag_interfaces resource module (#59031)
* Add nxos_lag_interfaces resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* ix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* module_utils nxos transport-provider fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_lag_interfaces tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-23 11:11:37 +05:30
The Magician
04445f184b Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59322) 2019-07-22 22:07:48 -07:00
The Magician
c6c262a07e Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59131)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:01:47 +05:30
The Magician
b81239ce50 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59323)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:00:22 +05:30
The Magician
5d412d89b1 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59325)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 09:58:21 +05:30
Matt Clay
79eca9c8fb
Initial ansible-test support for collections. (#59197)
* Initial ansible-test support for collections.
* Include cloud config in delegation payload.
* Add missing types import and fix `t` shadowing.
* Fix plugin traceback when config_path not set.
* Fix encoding issues.
* Remove unused imports.
* More encoding fixes.
* Handle delegation outside exception handler.
* Inject ssh keys only if not already in place.
* More defensive approach to getting remote pwd.
* Add missing string format var.
* Correct PowerShell require regex.
* Rename `is_install` and `INSTALL_ROOT`.
2019-07-22 19:24:48 -07:00
Sam Doran
67c69f3540 Mark Docker tests unstable (#59408)
* Mark Docker tests unstable

- docker_swarm is unstable on RHEL 8
- docker_container is unstable on RHEL 7

* Disable docker_container test.
2019-07-22 16:40:45 -07:00
Martin Nečas
c7f414dece ovirt vm when creating Nonetypefix (#59377)
* ovirt vm when creating Nonetypefix

* update fix and add comment

* add changelog

* Update 59377-ovirt-vm-when-creating-fix.yml
2019-07-22 16:18:08 -07:00
Brian Coca
8a886a6bee
Fix gather facts ignoring gather_subsets config (#59271)
* Fix gather facts ignoring gather_subsets config

 fixes #58728

* Update lib/ansible/playbook/play.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 17:59:22 -04:00
Jordan Borean
aa0de421d2
Ignore collection build release files in the root collection directory (#59121) 2019-07-23 07:52:30 +10:00
Brandon Authier
199c97728f Update disk description in vmware_guest.py (#59399)
Corrects grammar in the disk description section of the vmware_guest module documentation.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-07-22 16:14:45 -05:00
Navid Nabavi
b2e58856bf Update hpilo_boot.py (#59136)
Change `hpilo` requirement to `python-hpilo` to avoid being confused in installation with pip.
2019-07-22 16:09:56 -05:00
Alex IP
a2b49854ca Update copy.py (#56370)
* Update copy.py to make the behavior of the `content` option clearer.
2019-07-22 15:57:33 -05:00
Jordan Borean
65049620ee
Generate galaxy.yml based on single source of truth (#59170)
* Generate galaxy.yml based on single source of truth

* Fix up tests and align file names

* Minor Makefile tweak

* Remove link in galaxy.yml file and make it a template file

* Moved collections docs to dev_guide

* change Makefile clean path

* Added readme to example meta file

* review fixes

* Use newer style for doc generation script

* Fix mistake in dev_guide index

* removed uneeded file, fixed links and added preview banner

* Moved banner for sanity test
2019-07-23 06:50:46 +10:00
Tomáš Pospíšek
28b9f71640 remove ambiguity: use "my_test" as module name (#59335)
Naming a module "something_module" is misleading (see below). Let's drop the "_module" part of the module name on the developing_modules_general page.
2019-07-22 14:58:12 -05:00
Jordan Borean
9ff26a4a22
psrp - Added proper reconnection variable name (#59369) 2019-07-23 05:55:52 +10:00
PRASOON KARUNAN V
a20afb5822 Add support for test script parameters in win_pester (#58790)
* add parameter list argument

* add tests

* fix test and add doc

* correct test file

* fix typo

* fix tests

* fix typo in file name

* correct file name reverting the previous commit

* correct property name

* add checkmode message

* changes as per review comments

* variable casing and other review comment changes

* define $test_parameters_check_mode_msg variable
2019-07-23 05:46:26 +10:00
Matt Martz
284dafe476
Perfy McPerferton (#58400)
* InventoryManager start of perf improvements

* 0 not 1

* More startswith to [0] improvements

* Remove unused var

* The hash doesn't need to be a string, start as a list, make it into a tuple

* set actually appears faster than frozenset, and these don't need to be frozen

* Cache hosts lists, to avoid extra get_hosts calls, pass to get_vars too

* negligible perf improvement, it could help with memory later

* Try the fast way, fallback to the safe way

* Revert to previous logic, linting fix

* Extend pre-caching to free

* Address test failures

* Hosts are strings

* Fix unit test

* host is a string

* update test assumption

* drop SharedPluginLoaderObj, pre-create a set, instead of 2 comparisons in the list comprehension

* Dedupe code

* Change to _hosts and _hosts_all in get_vars

* Add backwards compat for strategies that don't do set host caches

* Add deprecation message to SharedPluginLoaderObj

* Remove unused SharedPluginLoaderObj import

* Update docs/comments

* Remove debugging

* Indicate what patterh_hash is

* That won't work

* Re-fix tests

* Update _set_hosts_cache to accept the play directly, use without refresh in get_hosts_remaining and get_failed_hosts for backwards compat

* Rename variable to avoid confusion

* On add_host only manipulate _hosts_cache_all

* Add warning docs around _hosts and _hosts_all args
2019-07-22 14:25:20 -05:00
Chris Archibald
6adf0c581e New feature to na_ontap_snapmirror (#59047)
* updates

* updating version added for connection type
2019-07-22 13:46:00 -04:00
Brian Coca
74ac229fa8 fix all cases of none remote/become users (#59397)
some cases failed, when defaults were None on the plugins
2019-07-22 12:24:31 -05:00
Matt Clay
52ad0f3217 Update ansible-test sanity requirements.
Skip installation of packages on Python 2.x which are only used on 3.x.
2019-07-22 10:14:33 -07:00
Joseph Andreatta
7ee5835821 VMware: vmware_dvs_host: Add vendor_specific_config (#57637)
* Add vendor_specific_config
* Fix documentation typo
* Add example using vendor_specific_config
2019-07-22 22:06:30 +05:30
Chris Archibald
b1360c0d94 bug fixes (#59049) 2019-07-22 11:05:56 -04:00
Trois-Six
6f9f67be18 virt_net: add way to get facts for only one specified network 2019-07-22 16:34:07 +02:00
Eric Anderson
46b821d51f state wasn't a valid value (#59274)
State isn't a valid value for the gcp_compute_address module, remove it from docs example
2019-07-22 09:25:26 -05:00
n3pjk
6531819172 snow: Fix token reference in basic authentication (#59315)
* Fix OAUTHClient logic
* Add Env variable support for snow modules

Fixes: #59299

Signed-off-by: Paul Knight <paul.knight@state.de.us>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 19:31:04 +05:30
Andrey Klychkov
59e647910d Add unit tests for bytes_to_human formatter
PR #58664

Co-Authored-By: Sam Doran <sdoran@redhat.com>
2019-07-22 15:45:07 +02:00
Martin Krizek
d6b1376006
Add changelog for #59280 (#59380) 2019-07-22 13:42:10 +02:00
Evert Mulder
66d12f6f1e Only convert VirtualDiskFix for #57653 clone_with_convert is failing 2019-07-22 12:52:48 +02:00
Gonéri Le Bouder
e9b1e36d76 vcenter provider: avoid a TypeError exception
Avoid `TypeError: option values must be strings` with `ConfigParser`.
Default values must be string, not `None`.

The error happens when `test/integration/cloud-config-vcenter.ini` does
not have the `vmware_proxy_host` or `vmware_proxy_port` keys defined.
2019-07-22 11:19:39 +02:00
Martin Krizek
b7868529ee
Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)
This reverts commit 6069d09b9d.

Fixes #57351
2019-07-22 10:27:11 +02:00
Abhijeet Kasurde
791e565802
VMware: Additional testcase for mem_reservation (#59365)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 10:44:19 +05:30
Tyler Ramer
8d0f2e5725 Address regression causing bootproto=dhcp for manual IP addresses (#56376)
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
2019-07-22 09:30:24 +05:30
Klaus Frank
252d1b7e95 VMware Tools Connector does not support pipelining (#57237) 2019-07-22 09:27:00 +05:30
Abhijeet Kasurde
1f49abb51c
VMware: Accept 0 as valid value for memory reservation (#59230)
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 09:03:25 +05:30