Commit graph

23527 commits

Author SHA1 Message Date
Toshio Kuratomi
40948cfcc4 git still needs to have abspath applied to dest 2016-12-08 11:24:16 -05:00
David Shrewsbury
dcbbd72cfd Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:

  4b0aa1214c

This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
2016-12-08 11:24:16 -05:00
Peter Sprygada
ef8b59f430 handles config replace properly in eos_template
fixes 3366
2016-12-08 11:24:16 -05:00
Michael Scherer
2ae3dbcc6a Set the locales to avoid issue with screenscrapping
See https://github.com/ansible/ansible-modules-core/pull/2462 for

details on why this could happen
2016-12-08 11:24:16 -05:00
Thomas Quinot
a5ec00f89f Reset all locale environment variables before running svn commands
We screenscrape the output of svn(1), so better ensure it is using the

C locale.

Fixes #3255
2016-12-08 11:24:16 -05:00
Kalle Lehtonen
02f737cdee Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
2016-12-08 11:24:16 -05:00
Peter Sprygada
8210ede9b4 refactor iosxr_template module to remove old diff functions
this replaces the old diff functions with the netcfg shared module for
handling configuration diffs between running and candidate
2016-12-08 11:24:16 -05:00
Peter Sprygada
bba38d2cf8 refactor iosxr_config module to remove old diff functions
this replaces the old diff functions with the netcfg lib for handling
configuration diffs between running and candidate configurations
2016-12-08 11:24:16 -05:00
Peter Sprygada
c2c8d51ba2 cleanup iosxr_command module to be consistent with other network modules
this cleans up some of the function calls and output keys to be consistent
with other command modules
2016-12-08 11:24:15 -05:00
Ricardo Carrillo Cruz
1b5288b703 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-12-08 11:24:15 -05:00
Peter Sprygada
834bc225c9 refactors nxos_template and removes diff functions
replaces the diff functions with the netcfg shared module for handling
configuration diff
2016-12-08 11:24:15 -05:00
Peter Sprygada
5a61909b4a refactors nxos_config and removes diff functions
this refactors the nxos_config module removing the diff functions and
replacing with the netcfg shared module
2016-12-08 11:24:15 -05:00
Peter Sprygada
19119a2759 cleans up nxos_command and adds some additonal info on exception
This cleans up some of the nxos_command module code function names to
be more consistent and adds additional information of failures
2016-12-08 11:24:15 -05:00
Peter Sprygada
a4bb4ee146 refactors eos_template to remove diff functions
replaces functions with netcfg shared library for handling configuration
diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
f77bb0ac28 refactors eos_config to remove config diff functions
replaces with netcfg shared library for handling configuration diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
006c11cf34 refactors the ios_template module to use netcfg diff
removes the functions for performing configuration diffs to use the
netcfg shared lib
2016-12-08 11:24:15 -05:00
Peter Sprygada
ff928d0829 refactor ios_config to use netcfg diff shared lib
Move the configuration diff code from the module to the shared lib
2016-12-08 11:24:15 -05:00
Toshio Kuratomi
708d49777d Allow async to not need an args file since new-style modules have args embedded 2016-12-08 11:24:15 -05:00
Brian Coca
ff755da1e5 fixed doc quoting 2016-12-08 11:24:15 -05:00
Brian Coca
37513ca8bb corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-12-08 11:24:15 -05:00
David Shrewsbury
1bdc3b3bb0 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-12-08 11:24:15 -05:00
David Shrewsbury
82a1208e64 Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-12-08 11:24:15 -05:00
Ricardo Carrillo Cruz
5d402f31c8 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-12-08 11:24:15 -05:00
Jan Hutar
45076bddb9 Add missing parameters so these options are usable 2016-12-08 11:24:15 -05:00
Michael Scherer
65243dfb91 Fix type of the rhn_register module
Password and activationkey should be tagged as no_log, as they
are supposed to be secret.
sslcacert is a path, so should be tagged as such.
2016-12-08 11:24:15 -05:00
Christian Aistleitner
51e3c6c49b Guard against too old boto library
route53 creates Record objects using `health check` and `failover`
parameters. Those parameters only became available in boto 2.28.0.
As some prominent LTS Linux releases (e.g.: Ubuntu 14.04) only ship
older boto versions (e.g.: 2.20.1 for Ubuntu 14.04), users are getting
unhelpful error messages like

  TypeError: __init__() got an unexpected keyword argument 'health_check'

when running Ansible 2 against their LTS install's default boto.
We improve upon this error message by checking the boto version
beforehand.

Fixes ansible/ansible#13646
2016-12-08 11:24:14 -05:00
Arnaud Lachaume
50622b4e6a fix aws elasticache idempotency 2016-12-08 11:24:14 -05:00
David Shrewsbury
4b97cd3a42 Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-12-08 11:24:14 -05:00
whiter
dadf835a06 Remove access_key and secret_key as these are provided by aws doc fragment Remove ec2 doc fragment as region is not required for IAM 2016-12-08 11:24:14 -05:00
Bence Nagy
0fd89cfd44 Add prefixing and suffixing fuctionality to assemble 2016-12-08 11:24:14 -05:00
Hugh Saunders
92ebeffd6c Retry apt cache updates 2016-12-08 11:24:14 -05:00
Michael Scherer
3d415ac2da Use type='path' for path arguments for git module 2016-12-08 11:24:14 -05:00
Michael Scherer
55bbe191e5 s/plubic/public/in the doc 2016-12-08 11:24:14 -05:00
nitzmahone
eb3243c15a fix win_stat get_checksum alias issue
made it impossible to prevent gathering checksum without setting both get_md5 and get_checksum false
2016-12-08 11:24:14 -05:00
Toshio Kuratomi
6fae6c7b2d Give headers a default so that we can add to it. 2016-12-08 11:24:14 -05:00
Ash Wilson
6e2f724919 Remove myself from the docker module maintainers
Apologies, but I no longer use this module day-to-day myself, and I don't have the bandwidth right now to effectively triage changes in any kind of timely fashion.
2016-12-08 11:24:14 -05:00
Strahinja Kustudić
db45268b75 Yum module always downloads remote rpms. fixes #1452 2016-12-08 11:24:14 -05:00
Michael Scherer
daddfb490b Improve/fix type checking for docker module
tls_* point to files, so should be type=path
count is a int, so tag it as such and avoid converting later
password should be tagged as no_log
2016-12-08 11:24:14 -05:00
Ashwanth Kumar
7c5b4b142a Doing exponential backoff on route53 upon AWS throttling 2016-12-08 11:24:14 -05:00
Victor Beresnev
2e94affde6 If cmd and entrypoint not set, don't match them
Hello!
I wanted stop the containers matched only by image name, but can't do this, if I not set cmd in playbook.
This behavior confused me.

If cmd or entrypoint is defined for running container, but not defined in playbook, makes matching behavior as this sample:
https://github.com/ansible/ansible-modules-core/blob/devel/cloud/docker/docker.py#L463
2016-12-08 11:24:14 -05:00
curious-eyes
5b88ad45ef Add preemptible option on gce.py 2016-12-08 11:24:14 -05:00
Rene Moser
775521e5cb apt: doc: fix missing version_added
see #2023
2016-12-08 11:24:13 -05:00
Dag Wieers
084c597f45 Update the issue and pull-request templates in sync with ansible/ansible 2016-12-08 11:24:13 -05:00
Chris Lamb
c012358d57 os/apt.py: Add support for passing --allow-unauthenticated
This is useful for packages that bootstrap their own apt-key setup - only
the initial installation will require overriding. Notable examples are the
Dropbox and Google Chrome packages.

(Setting force=yes is far too strong: I only want to bypass
authentication!)

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2016-12-08 11:24:13 -05:00
David Shrewsbury
285ab7656f Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-12-08 11:24:13 -05:00
Ricardo Carrillo Cruz
344a559b61 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-12-08 11:24:13 -05:00
David Shrewsbury
b750b926d3 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-12-08 11:24:13 -05:00
Brian Coca
d035961d1c added version added 2016-12-08 11:24:13 -05:00
Peter Sprygada
11cd361d80 fixes #3274 2016-12-08 11:24:13 -05:00
Toshio Kuratomi
4c9f9973dd If file attribs are specified set them even if file already exists.
Fixes #11821
2016-12-08 11:24:13 -05:00