Robin Roth
64fe01178f
add comment: ports need to be exposed.
...
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.
This comments makes the behaviour more obvious.
2015-06-17 18:01:35 +02:00
Greg DeKoenigsberg
28a869a030
Updating cloud modules with proper github author information
2015-06-15 14:41:22 -04:00
Ed Hein
558f2ace1f
Fix computation of port bindings. Port bindings configuration can be a list
...
if several host ports are bound to the same guest port.
2015-06-12 12:36:52 +02:00
Ryan Walls
a2630d40fb
Fix typo in Docker module.
2015-06-02 00:09:01 -06:00
Ryan Walls
88eddb13c0
Update docker module to avoid false positives when containers are first created. Also have the module check
...
for api compatibility before trying to set a "--log-driver" option.
2015-06-01 09:48:24 -06:00
Ryan Walls
c95717afe5
Set default "log_driver" option to None in docker module.
2015-05-28 11:36:20 -06:00
Ryan Walls
5f1d88a829
Update docker module to look at log_driver variable when deciding if container configuration has changed.
2015-05-27 12:33:11 -06:00
Ryan Walls
3f679933a6
Add support for --log-driver option that docker released with Docker 1.6
2015-05-22 16:36:38 -06:00
Toshio Kuratomi
60a66a544d
Several cleanups to many modules:
...
* Fix docs to specify when python2.6+ is required (due to a library
dep). This helps us know when it is okay to use python2.6+ syntax in
the file.
* remove BabyJson returns. See #1211 This commit fixes all but the
openstack modules.
* Use if __name__ == '__main__' to only run the main part of the module
if the module is run as a program. This allows for the potential to
unittest the code later.
2015-05-11 12:15:53 -07:00
Ian Babrou
501a665060
Pulling missing docker image before doing anything
2015-05-07 10:25:41 +03:00
Ratnadeep Debnath
be66acb436
Fixed typo in cloud docker module.
2015-05-06 15:23:40 +05:30
Toshio Kuratomi
f444e49dfa
Fix error when container has no names.
...
Rename loop variable from "i" to more informative "container"
Fixes #1188
2015-05-04 10:16:01 -07:00
Pascal Borreli
f29a6ec54d
Fixed typos
2015-05-04 12:54:03 +01:00
Toshio Kuratomi
1fdf75d49d
Second try at fixing #1227 -- set e default value earlier
2015-04-30 19:09:22 -07:00
Toshio Kuratomi
e51ea29d8f
Return empty list if an image has no repo_tags
2015-04-30 17:44:05 -07:00
Toshio Kuratomi
e356692c74
Get docker's default api version definition from both 1.2 location and pre-1.2 location
...
Fixes #1227
2015-04-30 07:47:44 -07:00
Brian Coca
09aa79c58f
Merge pull request #1102 from heiparta/extra_hosts
...
Add support for extra_hosts to docker module
2015-04-30 09:08:18 -04:00
Toshio Kuratomi
e95c0b2df3
Only split on the first colon.
...
Fixes #1214
2015-04-28 08:33:50 -07:00
Heikki Partanen
91ca2d6386
Add support for extra_hosts to docker module
...
extra_hosts parameter (maps to --add-host in 'docker run' syntax) is used
to add host-to-ip mappings to the container.
2015-04-07 10:30:14 +03:00
Andrew Davis
f38186ce8b
ansible_facts reflects 1.8 output
2015-04-03 12:41:10 -07:00
Ash Wilson
45b067f097
Record facts for each changed container.
2015-03-31 16:14:16 -04:00
Ash Wilson
b28459e6f5
Wait for process exit on detached=no.
2015-03-30 15:52:17 -04:00
Ryan Trauntvein
5320cc93e6
Specify that "state: reloaded" was added in Ansible 1.9
2015-03-27 16:36:10 -07:00
nemunaire
7f3df5634a
Add optional signal parameter when killing docker container
2015-03-27 18:14:14 +01:00
Ash Wilson
9ce2fc718a
Only fetch details when necessary.
2015-03-24 11:18:15 -04:00
Ash Wilson
47f4c3f2e5
Compare container images to Config.Image.
2015-03-24 11:07:12 -04:00
moncho
3421712e05
Update docker.py
...
Fix typo that prevents use_tls 'encrypt' option from working properly.
2015-03-19 19:30:36 +01:00
Toshio Kuratomi
76198a8223
Merge pull request #961 from nemunaire/fix-docker-version-print
...
[docker] Fix formating error when remote host doesn't have required version
2015-03-18 19:51:45 -07:00
Toshio Kuratomi
e338fef730
Add another valid status from downloading images
2015-03-18 18:27:01 -07:00
nemunaire
fce8c21176
Convert tuple items to string before format
2015-03-18 14:37:26 +01:00
Toshio Kuratomi
8658b82de7
Some code cleanup (removed unused variables and imports)
2015-03-16 11:58:03 -07:00
Toshio Kuratomi
34c4e0d495
Also use DOCKER_TLS_VERIFY env var to turn on tls verification
2015-03-16 11:43:52 -07:00
Toshio Kuratomi
ceda82603a
Merge pull request #947 from ansible/docker-tls-none
...
When no use_tls is not specified and no tls parameters are given we need to not attempt tls.
2015-03-16 11:29:14 -07:00
Toshio Kuratomi
b0d194ea94
Fix a potential bug in docker pull
2015-03-15 11:22:07 -07:00
Toshio Kuratomi
5b4d7a2182
When no use_tls is not specified and no tls parameters are given we need to not attempt tls.
2015-03-14 22:59:17 -07:00
Toshio Kuratomi
45637176dc
Merge branch 'volumes_from' of https://github.com/lorin/ansible-modules-core into lorin-volumes_from
...
Remove volumes_from altogether
Conflicts:
cloud/docker/docker.py
2015-03-13 13:42:40 -07:00
Toshio Kuratomi
e4a5b46cfb
Merge pull request #936 from ansible/docker-pid-mode
...
Make pid_mode parameter do minimum docker-py/docker server version checks
2015-03-13 11:50:46 -07:00
Toshio Kuratomi
81fc92bd66
Make state=running work for backwards compatibility with 1.8
2015-03-13 10:23:10 -07:00
Toshio Kuratomi
bddd02bfcb
Fix lookup of parameter name to be pid instead of pid_mode
2015-03-13 07:31:55 -07:00
Toshio Kuratomi
9d0d54b9a6
Merge pull request #926 from ansible/docker-tls-alt-854
...
Alternative implementation of tls for docker
2015-03-12 23:41:28 -07:00
Toshio Kuratomi
cf9374f3ea
Make pid_mode parameter do minimum docker-py/docker server version checks
2015-03-12 22:53:31 -07:00
Toshio Kuratomi
3a6cc86578
Fix for problems found by @dguerri
...
* TLSConfig['verify'] has to be set to False if we're only encrypting the
connection, not verifying the host.
* tls_hostname was not set if tls_ca_cert was not present
https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78573877
2015-03-12 12:53:48 -07:00
Toshio Kuratomi
1add8ed9e5
Implement comments from @smashwilson:
...
* if tls_ca_cert is set then use tls to verify the server
* take tls_hostname from the environment variable DOCKER_TLS_HOSTNAME
if it's not specified in the playbook
https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78542210
2015-03-12 11:07:22 -07:00
Stefan Junker
c3f92cca21
docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list.
2015-03-12 12:55:14 +01:00
Stefan Junker
d8df5da49f
merge and resolve conflict in docker.py
2015-03-12 12:47:54 +01:00
Ian Babrou
763f472f5b
fixed: global name 'e' is not defined
2015-03-12 11:04:50 +03:00
Toshio Kuratomi
3e0cbc82f1
Alternative implementation of tls for docker
...
Alternative to #854
2015-03-11 20:37:27 -07:00
Toshio Kuratomi
ca32205c7b
Documentation style changes
2015-03-11 08:26:16 -07:00
Ian Babrou
9ecfde7551
not triggering reload for links and not string env variables
2015-03-09 22:49:00 +03:00
Ash Wilson
0969fd75c8
Use {0}, {1} style format indices for 2.6 compat
2015-03-09 12:54:22 -04:00
Ash Wilson
19664a96db
Expect module env vars to override Dockerfile ones.
2015-03-09 12:17:39 -04:00
Ash Wilson
608ddbea29
Include bind mounts in VOLUMES check.
2015-03-09 11:20:14 -04:00
Ash Wilson
2c58eb3845
Exposed ports, env vars, volumes from the image.
...
This will account for settings that are provided by the hierarchy of
Dockerfiles used to construct your image, rather than only accounting
for settings provided to the module directly.
2015-03-09 10:32:10 -04:00
Ash Wilson
79db475316
Full image inspection and just repo tags
...
Hat tip to @bobrik.
2015-03-09 10:05:56 -04:00
Brian Coca
1c0623ab8d
Merge pull request #890 from SamYaple/docker-pid-support
...
Add pid mode support to docker module
2015-03-07 20:27:42 -05:00
Ash Wilson
d046425049
Connect to Docker with optional TLS.
2015-03-06 18:04:36 -05:00
Ash Wilson
80aca4b936
Rework docker module states.
...
Organize each state into a distinct function for readability and composability.
Rework `present` to create but not start containers. Add a `restarted` state
to unconditionally restart a container and a `reloaded` state to restart a
container if and only if its configuration is incorrect. Store our most recent
knowledge about container states in a ContainerSet object. Improve the value
registered by this task to include not only the inspect data from any changed
containers, but also action counters in their native form, a summary message
for all actions taken, and a `reload_reasons` key to store a human-readable
diagnostic to determine why each container was reloaded.
2015-03-06 17:58:11 -05:00
Ash Wilson
7490223940
Pull newer image versions when requested.
2015-03-06 17:56:45 -05:00
Ash Wilson
fedbea682e
Another documentation commit.
2015-03-06 17:56:37 -05:00
Sam Yaple
e1e74bdf33
Updated version and fixed default
2015-03-06 03:13:55 -06:00
Sam Yaple
74e922449b
Add pid mode support to docker module
...
This allows setting the pid namespace for a container. Currently only
the 'host' pid namespace is supported.
This requires Docker 1.4.1 and docker-py 1.0.0
2015-03-03 23:32:15 -06:00
Brian Coca
b787792908
Merge pull request #679 from marqc/fix_dns_create_container_issue
...
Fixes docker.errors.DockerException: 'dns' parameter has no effect on create_container()...
2015-02-18 15:44:16 -05:00
Brian Coca
7e71121da5
Merge pull request #730 from SergeyZh/devel
...
Fixed broken volumes_from for client API >= 1.10
2015-02-17 11:49:16 -05:00
Tomer Paz
374dd06c8e
resolve issue 764
...
https://github.com/ansible/ansible-modules-core/issues/764
added 'domainname' attribute in addition to existing 'hostname'.
That's the most elegant way to delegate domain name to docker-py...
2015-02-11 09:25:24 +02:00
Sergey Zhukov
7baaf97a8b
Fixed broken volumes_from for client API >= 1.10
2015-01-30 19:58:12 +03:00
Toshio Kuratomi
670098af2d
Spelling and grammar fix
2015-01-22 23:08:24 -08:00
calmera
d2c6791082
Update docker.py
...
Added some more documentation for the memory_limit and volume options.
2015-01-22 23:08:24 -08:00
Brian Coca
d66c3fcf51
moved defaulting to module constant to after when it is defined
2015-01-21 19:50:34 -05:00
Marek Chodor
13685fb91b
Fixes docker.errors.DockerException: 'dns' parameter has no effect on create_container(). It has been moved to start()
2015-01-21 13:37:24 +01:00
Lorin Hochstein
48ce8bb564
Don't pass volumes_from to create_container
...
Don't pass the volumes_from argument to the Docker create_container method.
If the volumes_from argument is passed to the create_container method, Docker
raises the following exception:
docker.errors.DockerException: 'volumes_from' parameter has no effect on
create_container(). It has been moved to start()
2014-12-27 22:05:55 -05:00
Lorin Hochstein
3665c92856
docker: fix volume[s]_from typo
...
Code makes reference to volume_from instead of volumes_from. If volumes_from is
passed as an argument, generates a KeyError.
2014-12-25 23:31:06 -05:00
Jan Weitz
ebf9b8c6e2
Fixes invalid dictionary access.
2014-12-24 13:15:40 +01:00
Jan Weitz
82601fdc54
Fixes version check for docker-py
2014-12-24 03:04:04 +01:00
Stefan Junker
8f3b5c640b
Fix bind-volumes on docker >= 1.4.0
...
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
2014-12-21 17:11:47 +01:00
Toshio Kuratomi
c4f9366e91
Newstyle class
2014-12-18 13:43:55 -08:00
Toshio Kuratomi
f65d9ab793
Make insecure_registry feature version check against the client API
2014-12-18 12:45:13 -08:00
Maksim Losev
4172d445d3
Add insecure_registry to docker-py pull method
...
Starting from docker-py>=0.5.0 it is impossible to work with private registries based on HTTP.
So we need additional parameter to allow pull from insecure registry
Related to ansible/ansible#9111
2014-12-18 12:36:17 -08:00
Toshio Kuratomi
fa0fa9d221
Make docker ver checks issue failures rather than silently ignoring
...
Also:
* make client version checks robust for two digit version pieces and
alpha versions
* consolidate version checking code
2014-12-18 11:23:44 -08:00
Ingo Gottwald
80d45c78a3
Add support for new docker restart policies
2014-12-18 10:27:53 +01:00
PikachuEXE
6ce7e63c5f
~ Add missing documentation for option email
2014-12-10 10:23:59 +08:00
Toshio Kuratomi
c6522620c5
Clean up the docker module just a little so that we can unittest the get_split_image_tag function
2014-11-14 08:46:32 -08:00
Brian Coca
0c4adcb2c6
made subcategories for cloud modules for better organization
2014-11-04 11:18:09 -05:00