Commit graph

27616 commits

Author SHA1 Message Date
Wojciech Wypior
66c828d45f adds new parameters to tcp profile module (#58185)
minor fix in policy module
2019-06-21 07:07:48 -07:00
Wojciech Wypior
07fc880b3c minor fixes in two modules (#58178) 2019-06-21 07:07:17 -07:00
Wojciech Wypior
3531bf3148 fixes issue with ssl protocols ordering (#58177) 2019-06-21 06:46:53 -07:00
Wojciech Wypior
cee3d539cb Fixes issue with failure messages (#58173) 2019-06-21 06:45:57 -07:00
Wojciech Wypior
becca36c5e Added new module for remote user management (#58171) 2019-06-21 06:45:29 -07:00
Tobias
e7c39460ed ipaddr: Handle ipaddress index in network correctly (#57896)
This commit prevents integer indices from being parsed as ip nets

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
2019-06-21 15:26:08 +02:00
Kevin Breit
0f12e1c7d8 Meraki - Improve type information in module documentation (#58114)
* Improve type information in module documentation
- Removed some duplicate documentation
- Ensure org_id is always string
- Add type information for items which don't have it

* Fix whitespace
2019-06-21 09:25:03 -04:00
Sumit Jaiswal
58d446e61a
PR to fix where ansible_net_model was not being populated (#58159)
* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-21 16:18:59 +05:30
markafarrell
43872d6b88 Fix netconf guess_network_os to use ssh_config if supplied. (#55199)
* feature: use network_os=auto to trigger network os guessing

* doc: add debug messages

* fix linting

* fix test_netconf_init default network_os is auto

* add documentation

* fix rst errors

* use init lexer

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-06-21 09:04:13 +05:30
Ganesh Nalawade
f864f621d8
Fix junos module transport check (#58050)
*  Since new junos resource modules will
   support only network_cli connection type
   modify the transport check from network_cli
   connection netconf as netconf only supported modules
   is a fronzen set.
2019-06-21 08:56:52 +05:30
The Magician
28b67d809f Bug fixes for GCP modules (#58107) 2019-06-20 20:51:43 -04:00
Kohei Asano
ddf6d096c5 Support the new TLS termination on NLBs (#51327) (#58031) 2019-06-20 17:03:04 -07:00
Felix Fontein
f8f2738351 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.
2019-06-20 16:59:15 -04:00
Dmitriy Yakovlev
122d4164c5 docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end
2019-06-20 15:58:32 -04:00
Felix Fontein
4188cd299b crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.
2019-06-20 21:31:00 +02:00
Alberto Murillo
320d05dc30 tower_workflow_template: Add missing options (#56891)
The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
2019-06-20 13:55:37 -04:00
Stefan Prietl
9dbc838d99 Add rudimentary wait for os_zone (#54391)
This adds a rudimentary wait functionality for the os_zone module.

It will wait for:
* Zone not in OpenStack API when choosing `absent`
* Zone `status` being `AVAILABLE` in OpenStack when choosing `present`
2019-06-20 13:00:57 -04:00
panticz
d0ee6e1e54 Implement protected parameter (#54114)
* Implement protected parameter

* version_added field

* Remove point at at the end of the sentence

* Update version_added to 2.9
2019-06-20 12:47:18 -04:00
A Codeweavers Infrastructure Bod
2f70c90efd Update apt.py (#56479)
* Update apt.py

Tested under Debian 9 with installation of Apache2 and PostgreSQL
In both cases the daemons are started immediately upon installation

https://www.alextomkins.com/2018/03/runlevel-apt-get-install-package-alternative/
https://major.io/2014/06/26/install-debian-packages-without-starting-daemons/
2019-06-20 12:10:28 -04:00
Josef 'veloc1ty' Stautner
bdb089b910 Update sysctl.py (#57984)
##### SUMMARY
Quote values to mitigate this ansible warning:

+label: docsite_pr
2019-06-20 11:46:25 -04:00
Tom Moore
67e02b5eee Corrected module example in documentation (#58124) 2019-06-20 11:37:05 -04:00
pratikgadiya12
2b5ad94a96 vmware_guest_disk_facts: return controller_bus_number and controller_type (#58117)
Fixes: #57608
Fixes: #57998
2019-06-20 20:07:17 +05:30
Matt Martz
ffd117132f
Create new instance of the action plugin per until iteration. Fixes #57886 (#58022) 2019-06-20 09:17:50 -05:00
Matt Martz
375ac76e58
ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
2019-06-20 09:15:53 -05:00
smile37773
3a3465c47d Add the way to create a VM with the image id (#58106) 2019-06-20 16:42:09 +08:00
Cameron Nemo
cc7bea2100 plugins/connection/netconf: remove unimplemented option (#58104)
closes #51972
2019-06-20 12:07:10 +05:30
Yurii Vlasenko
8c1c2afd02 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-19 23:32:59 +02:00
The Magician
8b6c6cf302 Bug fixes for GCP modules (#58041) 2019-06-19 14:20:43 -04:00
Jeya
bdd0bbf50a [nxos] New parameter vrf in nxos_file_copy (#57851)
* [nxos] New parameter vrf in nxos_file_copy

* Fix version_added

* Fix documentation default value
2019-06-19 21:26:07 +05:30
Chris Van Heuveln
52c811c841 nxos_bgp_neighbor: Add bfd support (#56932)
* nxos_bgp_neighbor: Add bfd support

- Add support for bfd state in nxos_bgp_neighbor

- Feature Pull Request

- nxos_bgp_neighbor

- Tested on platforms: `N3K,N6K,N7K,N9K`

* bfd T/F now bfd enable/disable

* pep fix ws
2019-06-19 21:23:00 +05:30
Chris Van Heuveln
727a6b405a nxos_ospf_vrf: Add 'bfd' support (#57425)
* nxos_ospf_vrf: Add 'bfd' support

* Add default to bfd doc hdr

* bfd T/F now bfd enable/disable
2019-06-19 21:22:32 +05:30
Chris Van Heuveln
30830a4482 nxos_pim: Add bfd support (#56908)
* nxos_pim: Add bfd support

* Add integration sanity

* minor cleanup

* bfd T/F now bfd enable/disable
2019-06-19 21:22:03 +05:30
Mike Wiebe
12d656901f Add CmdRef logic to handle multiples (#57495)
* Add CmdRef logic to handle multiples

* Fix python 2.6 issues

* Fix bug when existing is not a dict object

* Fix python2 vs python3 incompatibilty

* Ignore unnecessary-lambda warning
2019-06-19 21:15:32 +05:30
Kevin Breit
8f68c8d438 meraki_snmp - Enable check mode (#54625)
* Add support for check mode

* Add diff support

* Remove check mode for idempotent action
2019-06-19 11:35:10 -04:00
Fred-sun
8cff96e388 Update azure_rm_roledefinition related document (#57927)
* Update azure_rm_roledefinition related documentation
2019-06-19 09:27:30 -05:00
Nathaniel Case
f656959861
Fix RESTCONF media types (#58015)
Fixes #56680
2019-06-19 10:22:24 -04:00
Andrey Klychkov
64d0559e9f Postgres module_utils: add get_connect_params + unit tests (#58067)
* add get_conn_params

* add get_conn_params: add to the modules
2019-06-19 06:49:19 -07:00
René Moser
6bace8aa54
vultr: vultr_account_facts -> info (#57563) 2019-06-19 14:10:55 +02:00
Zim Kalinowski
ee32222ae7 fixing vmss failure (#56625)
* triggering test

* deleting autocreated as last one

* fixed mistake
2019-06-19 05:00:43 -04:00
MyronFanQiu
ec95086b69 add support for https (#57785) 2019-06-19 15:14:53 +08:00
endurancetest20380119
3d452fb917 Update azure_rm_aks.py (#57898) 2019-06-19 15:13:16 +08:00
Martin Nečas
c609fad106 Ovirt vnic profile fix (#57936)
* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style
2019-06-18 21:46:41 -04:00
Rob
feae35ab7e add IAM role assumption to aws_ec2 inventory (#41637)
* add IAM role assumption to aws_ec2 inventory
* Ensure inventory._options has necessary option keys populated since the plugin docs parser isn't accessible to unit tests yet
2019-06-18 15:34:41 -07:00
Dusan Matejka
8646b6953d updated zabbix modules to use missing_required_lib helper (#58002) 2019-06-18 16:57:09 -04:00
Andrey Klychkov
186210af8a postgresql modules: remove unused imports, remove blank lines after docstrings 2019-06-18 12:55:32 -07:00
The Magician
a1128b6b94 Bug fixes for GCP modules (#58016) 2019-06-18 15:45:47 -04:00
Martin Nečas
b4d4f77963 Ovirt add managed storage domain (#57995)
* init managed storage domain

* add version added

* add no log for sensitive options

* add driver default types

* update docs

* update pep8 syntax

* update example syntax

* update example syntax

* set default domain_fucntion for managed_block_storage

* correct pep8 syntax

* update managed example

* update managed docs
2019-06-18 14:05:48 -04:00
Martin Nečas
c87dbed20f Ovirt nic default vnic (#57945)
* default vnic init

* ovirt default nic

* add spacing

* use network must be specified

* Update ovirt_nic.py

* Update ovirt_nic.py

* add no vnic profile exception

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax
2019-06-18 12:16:45 -04:00
Felix Fontein
505c99265c docsite: remove lexers which have been fixed in Pygments 2.4.0 (#57508)
* Remove lexers which have been fixed in Pygments 2.4.0.
* Add Pygments >= 2.4.0 to test runner.
* Fix pages that triggered lexer errors.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-06-18 10:56:33 -05:00
Ganesh Nalawade
cc00f21a35 Fix issue in netconf plugin dispatch for junos and iosxr (#57981)
*  If case xml reply is transformed or namespace is removed in ncclient
   device specific handler return modified xml response as string

*  If data xml node is present in xml response return the xml string
   with data node as root node

*  If none above is true return raw xml string received from host
   with rpc-reply as the root node
2019-06-18 10:36:03 -04:00
Fred-sun
21a95c0a16 Update azure_rm_route related document (#57928)
* Update docs for azure_rm_route, azure_rm_routetable, and azure_rm_routetable_facts
2019-06-18 09:19:52 -05:00
Gabor Szabo
d4555cbd45 Examples on how to remove files and directories (#57766)
* Docs: file module - adds examples on how to remove files and directories
2019-06-18 09:07:31 -05:00
Guillaume Martinez
ec7b18952b gitlab_runner: Fix idempotency when creating runner (#57833) 2019-06-18 13:12:12 +02:00
hexdump0x0200
81f0b70f11 junos_netconf: fix check mode, fixes #57929 (#57930) 2019-06-18 15:11:15 +05:30
Kevin Breit
d24e9ab4bb meraki_content_filtering - Add support for querying (#57273)
* Added querying functionality

* Fix PEP8 and documentation

* Increment version added

* Fix version info
2019-06-18 14:52:46 +05:30
Will Thames
a66687f2d2 rds_instance: allow empty iops and storage_type (#57943) 2019-06-18 07:56:01 +02:00
zhongjun2
c58b715f82 hwc_network_vpc: fix typo (#57977) 2019-06-18 07:42:37 +02:00
Sumit Jaiswal
d63ccb5bc8
fix 57447 bug (#57938)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-18 10:09:43 +05:30
Sayed Anisul Hoque
a82156a63f Updated Notes section of the meta (#57921)
Docs: note that 'meta` tasks are handled differently internally than 'normal tasks' so looping on meta tasks is not supported.
2019-06-17 16:33:06 -05:00
Felix Fontein
f56cf72e2b
ufw: remove from sanity ignores (#57910)
* Remove from pylint ignore list.

* Make sure that option is called the same as in the documentation.
2019-06-17 22:57:55 +02:00
PRASOON KARUNAN V
0cf6a418ab Correcting the documentation for win_package return value[log] (#57854)
* correcting the documentaiton for log return value

* grammar change
2019-06-18 06:56:57 +10:00
Felix Fontein
da6f6cc456 Fix missing doc type. (#57884) 2019-06-17 15:52:08 -05:00
Abhijeet Kasurde
eed7a338a0 aws: Fix typo in deprecation warning (#57946)
Changed "ec2_instance_information" to "ec2_instance_info" in deprecation warning.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 16:32:00 -04:00
Alex Stephen
9364b4c933 better metadata formatting on gcp_compute (#57778) 2019-06-17 16:10:27 -04:00
Fred-sun
6e89fbe58a Update azure_rm_networkinterface related document (#57454)
* Update azure_rm_networkinterface related document
* fixes errors with plural nouns, typos, uses single quotes for version_added
2019-06-17 14:38:57 -05:00
ShachafGoldstein
66728cb93f win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test
2019-06-18 05:25:38 +10:00
ShachafGoldstein
acc01f1109 Win_copy: doc fix when using become (#57690)
* win_copy: doc update

* Community review
2019-06-17 13:55:29 -05:00
The Magician
7751e97e1e Bug fixes for GCP modules (#57883) 2019-06-17 13:40:04 -04:00
Paul Belanger
fa738613dc
Revert "Fix iosxr discard_changes netconf rpc issue (#57931)" (#57954)
This actually broken junos netconf_rpc, and was merged without properly
testing.

This reverts commit 795cb90367.
2019-06-17 11:45:30 -04:00
Paul Belanger
d40c44bd56 Fix python3 encoding with iosxr_config (#57919)
Python3 requires bytes when writing files.

Depends-On: https://github.com/ansible/ansible/pull/57909/
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 17:42:29 +02:00
Ganesh Nalawade
4a3e14f90b More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test
2019-06-17 17:22:46 +02:00
Ganesh Nalawade
795cb90367
Fix iosxr discard_changes netconf rpc issue (#57931)
* If dispatch() rpc response has data element
return the xml string from <data> element
else return the complete xml string from
<rpc-reply>.

Depends-On: #57909
Depends-On: #57919
2019-06-17 16:22:23 +05:30
Abhijeet Kasurde
cf623fa62f
Terraform: Fix unbound local error (#57044)
* Added Unit tests
* Fixed regression

Fixes: #56934

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-17 08:23:59 +05:30
Ruben Tsirunyan
9e225fbb1e zabbix: New module zabbix mediatype (#57488)
Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>
2019-06-16 23:16:58 +02:00
Jordan Borean
d0c4914469
win_shell - fix space escaping for custom executable (#57455) 2019-06-17 05:14:58 +10:00
Simon Dodsley
0f2903780b purestorage: Add module to set MOTD banner text for Pure Storage FlashArray (#57500) 2019-06-16 09:43:51 +02:00
Abhijeet Kasurde
6b16be638d
VMware: add facts about tags in vmware_host_facts (#56837)
Fixes: #46461

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-16 09:02:26 +05:30
Sergey
7910361b52 Fix failed mounts in podman connector and handle errors (#57741)
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.
2019-06-15 07:35:55 -04:00
Fred-sun
019a48361b Update azure_rm_resourcegroup related document (#57819)
* Update azure_rm_resourcegroup related document

* resolve shippable error
2019-06-14 15:34:20 -04:00
Fred-sun
23eb465956 Update azure_rm_roleassignment related document (#57820)
* Update azure_rm_roleassignment related document

* add new
2019-06-14 15:27:06 -04:00
Brian Coca
342d77b32d
removal of chdir in controller (#57781)
* removal of chdir in controller

also ensure fetch/put uses relative to task cwd
2019-06-14 13:45:41 -04:00
Brian Coca
de87b25a45
show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422
2019-06-14 13:40:22 -04:00
Martin Krizek
e9c83b7a17 gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248
2019-06-14 12:55:22 -04:00
Fred-sun
8d635a82a4 Update azure_rm_publicipaddress related document (#57669)
* Update azure_rm_publicipaddress related document
2019-06-14 10:43:06 -04:00
Fred-sun
aeb72dfb06 Update azure_rm_resource related document (#57786)
* Update azure_rm_resource related document

* resolve shippable check error

* Resolve format error

* resolve format error---02

* Redefine the type variable
2019-06-14 10:13:32 -04:00
Fred-sun
1903aced79 Update azure_rm_rediscache related document (#57721)
* Update azure_rm_rediscache related document

* Update according by comment
2019-06-14 10:06:18 -04:00
Paul Belanger
88a1fc28d8 Clean up iosxr get_config_diff function (#57589)
This fixes an index error issue when running tests on zuul.ansible.com
for iosxr. We can fix this by getting the last element in the list.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-14 15:06:21 +05:30
Jagadeesh N V
6e8fcbf8c9 Adding idrac_pwd alias to modules (#57733) 2019-06-14 01:43:21 -04:00
Sander Steffann
71a704cc14 netbox: inventory: fix implementation of groups option (#57689) 2019-06-14 06:29:46 +02:00
bobdoah
33d0d36eaa AWS: Fix KeyError in aws_secret lookup (#54792) 2019-06-13 17:11:44 -07:00
Skybound1
e7bf46d8bc Adds visibility parameter to gitlab group creation (#57024) 2019-06-13 18:40:14 -04:00
The Magician
138f0e875a Bug fixes for GCP modules (#57724) 2019-06-13 18:25:57 -04:00
The Magician
a58088f661 Bug fixes for GCP modules (#57725) 2019-06-13 18:25:46 -04:00
The Magician
366a9784ac Bug fixes for GCP modules (#57727) 2019-06-13 18:25:23 -04:00
The Magician
ab0a548b0c Bug fixes for GCP modules (#57728) 2019-06-13 18:25:11 -04:00
The Magician
625ef22dd9 New Module: gcp_tpu_node (#57729) 2019-06-13 18:25:00 -04:00
Martin Krizek
61ff61cdf6 Tests as filters were deprecated, remove unused param (#57796) 2019-06-13 15:36:52 -04:00
The Magician
1d6d19f400 New Module: gcp_tpu_node_facts (#57730) 2019-06-13 15:11:46 -04:00
Kevin Breit
a85750dc98 Meraki - Convert response keys to snake_case from camelCase (#53891)
* Initial proposal for new parameter option for response format
- output_version parameter dictates the response key case
- new is snake_case, old is camelCase
- If new, conversion is done at the end of module execution
- This is purely a proposal and not a final draft

* Add support for ANSIBLE_MERAKI_FORMAT env var
- If env var is set to 'camelcase' it will output camelcase
- Otherwise, will default to snakecase
- Added note to documentation fragment
- As of now, all module documentation needs to be updated

* Fix pep8 errors and remove output_version args

* Restructure check in exit_json so it actually works

* Add changelog fragment

* Change output_format to a parameter with env var fallback
- ANSIBLE_MERAKI_FORMAT is the valid env var
- Added documentation

* Convert to camel_dict_to_snake_dict() which is from Ansible
- Fixed integration tests

* Fix yaml lint error

* exit_json camel_case conversion handles no data
- exit_json would fail if data wasn't provided
- Updated 3 integration tests for new naming convention

* convert_camel_to_snake() handles lists and dicts
- The native Ansible method doesn't handle first level lists
- convert_camel_to_snake() acts simply as a wrapper for the method
- There maybe a situation where nested lists are a problem, must test
- Fixed integration tests in some modules

* A few integration test fixes

* Convert response documentation to snake case
2019-06-13 15:07:30 -04:00
jarekgajewski
e264b4126f Update gcp_storage_object.py (#57802)
"name: ansible-storage-module" removed as name is not defined as parameter  


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-13 13:16:07 -04:00
Harald Albers
231f4cfcf1 Fix example in vmware_drs_group module (#57805)
Signed-off-by: Harald Albers <github@albersweb.de>
2019-06-13 13:12:59 -04:00
Adam Miller
d2dc4c9bc4 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-06-13 11:17:23 -04:00
Arnaud RENARD
1a5fd720a4 Ansible galaxy role download should not have to perform aditionnal check against tar archive file extension #56616. (#56617)
Ansible galaxy role download checked for `.tar.gz`, but `tarfile.is_tarfile(...)` can identify and open any valid tarfile. This change uses transparent stream compression to make `.tar.gz` and `.tar.bz2` formats valid with python 2.6.x/2.7.x (as well as `.tar.xz` with python 3.x).
2019-06-13 09:23:41 -05:00
Dmitry Tantsur
d33ee72085 os_ironic_node: avoid set_node_instance_info and purge_node_instance_info (#54463)
These openstacksdk calls are awkward special-case wrappers around
patch_machine, and I would like to deprecate them in openstacksdk change
https://review.openstack.org/647730. Use much simpler update_machine instead.
2019-06-13 09:08:24 -04:00
Ondra Machacek
886f4c66ca kubevirt: Add affinity parameters (#57359) 2019-06-13 12:25:30 +02:00
Martin Nečas
f7de9cb39f ovirt host facts fix (#57790) 2019-06-13 06:12:54 -04:00
Mariusz Mazur
51add5aa79 kubevirt: enable/update tests + fix merge_dicts() (#57685)
* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code
2019-06-13 11:07:16 +02:00
Abhijeet Kasurde
00604d3f2c
VMware: Fix vmware_guest_move undefined VM name error (#57582)
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-13 13:07:26 +05:30
René Moser
5143f52def
vultr: vultr_ssh_key_facts -> info (#57571)
* vultr: deprecate vultr_ssh_key_facts

* vultr: rename tests

* vultr: adjust tests

* vultr: new vultr_ssh_key_info module

* vultr: test: vultr_ssh_key_info: improve tests

* update docs
2019-06-13 07:05:00 +02:00
Strahinja Kustudic
8e9f29c40c Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables
2019-06-12 17:36:57 -04:00
Brian Coca
73a16749cb
Enable adjacent collections for ansible-doc (#57764)
* enable adjacent collections for ansible-doc
2019-06-12 17:10:17 -04:00
LucasBoisserie
1d76635206 Remove required field on service_account_file in gcp_compute plugin inventory (#57345) 2019-06-12 16:51:57 -04:00
Strahinja Kustudic
f6a0f9874d Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.
2019-06-12 16:38:48 -04:00
Mike Garrett
4bf051b8bb redfish: fix a problem with Chassis/Power URI (#56185)
Fixes #56137 - problem with Chassis/Power URI and GetChassisPower command - assemble URI from data in Chassis resource
2019-06-12 20:40:30 +02:00
xuxiaowei0512
5bddd55703 update vxlan (#57264)
* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.
2019-06-12 13:00:55 -04:00
xuxiaowei0512
e009936f87 update acl (#57268) 2019-06-12 12:58:15 -04:00
Chaitanya Deshpande
6d21cebd7d Avi credentials added sub-options (#57531)
* Split Avi Credentials into two parts - secrets and login_info

* Fixed indentation issue

* Removed trailing whitespaces

* Added sub-options to avi credentials

* Added sub-options to avi credentials

* Updated argument specs to use fallback instead of getting defaults from environment variable
2019-06-12 12:19:29 -04:00
xuxiaowei0512
5ac3661176 update snmp modules to fix bugs for cloudengine (#57025)
* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range
2019-06-12 11:27:21 -04:00
Kevin Breit
17c475b101 meraki_ssid - Improve change reporting (#56201)
* Improve change reporting for meraki_ssid
- Documentation is more clear about dependencies
- Not all change reports are accurate without new algorithm
- Improved integration tests

* Rename changelog fragment

* Enable all tests in integration tests
- Fix type merging

* Add more integration tests for code coverage

* Update URL creation
2019-06-12 11:06:00 -04:00
Martin Krizek
1fa7bfcd5d Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive
2019-06-12 10:56:14 -04:00
Mikhail Yohman
d07d394779 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix
2019-06-12 10:45:20 -04:00
Kevin Breit
a50b3d7695 meraki_syslog - Module properly handles net_id parameter (#57286) 2019-06-12 10:44:05 -04:00
Kevin Breit
87169c4aa4 meraki_vlan - Enable check mode (#54627)
* Add support for check mode

* Add diff support
- diff support is based on "have" and "want" data structures.
- Review needs to be done on the diffs for accuracy and usefulness.
- Changed change mode changed responses to be accurate.

* Remove config template based integration tests
2019-06-12 10:43:02 -04:00
Stefan Horning
77ec0549b0 New module for AWS CodeBuild (#47187)
* New AWS module for the CodeBuild service, called aws_codebuild

* Integration test for new aws_codebuild module
2019-06-12 10:25:53 -04:00
mrtwnklr
83bf90e02f Fixes #55476 (#57715)
* fixes bug introduced by commit 8cb73720f0599b08794cb7a3fbdf36d430214446: "TypeError: argument of type 'NoneType' is not iterable" when using module systemd without param 'name' (e.g. with daemon_reload)
2019-06-12 09:50:32 -04:00
Alexey Kamenskiy
793c18506a lvg: fix default value type, should be str (#57723) 2019-06-12 14:52:43 +02:00
Stefan Horning
33a26d31fd New module for AWS CodePipeline (#47189)
* New module for AWS CodePipeline

* Added integration test for new aws_codepipeline module
2019-06-12 08:50:09 -04:00
Martin Nečas
4052d6d294 set ovirt disk active default (#57464)
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
2019-06-12 12:32:58 +02:00
Gonéri Le Bouder
6537d1bc0f vmware_host_ipv6: only changed when changed (#57702)
Do not return the `changed` status when a reboot is required. The
configuration is applied and so the configuration changed has already been
done.
2019-06-12 14:20:18 +05:30
Nijin Ashok
166a5c909c ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-12 04:41:51 -04:00
Brett
69ead0ba78 puppet: new arg to toggle no-/use_srv_records flag (#53095) 2019-06-12 10:02:58 +02:00
Chris Van Heuveln
205f6b1699 nxos_pim_interface: Add 'bfd' support (#57133)
* nxos_pim_interface: Add 'bfd' support

* PEP fixes

* fix copyright date

* bfd states changed from T/F to enable/disable/default
2019-06-12 09:47:41 +05:30
ShachafGoldstein
7880be240f Remove usage of global var log_path for win_domain_* modules (#57092)
* Remove usage of global var log_path

* Add changelog and edit ignore.txt

* win_pagefile: not using testPath

* Revert "win_pagefile: not using testPath"

This reverts commit c8bc10234048257414454905e1c860a8f57a3b3f.

* PSLint error

* Update win_domain_membership.ps1

* Update win_domain_controller.ps1
2019-06-12 05:31:19 +10:00
ShachafGoldstein
d2909d5ef0 win_scheduled_task: Fix start/end boundry triggers to allow for timezone sync (#57282)
* Fix 49327

* Add a test

* Join test

* Test issue

* Fix missed assertion
2019-06-12 05:27:51 +10:00
ShachafGoldstein
1b5975f17e Fixes #54550 (#56279)
* "setup.ps1" - Change $env:COMPUTERNAME to [System.Net.Dns]::GetHostName(), to support non NETBIOS compliant hostnames

* Change method to base on WMI

* changed ansible_domain to use WMI

* Fixed per review

* Fixed dot stuff

* Revert "Fixed dot stuff"

This reverts commit a1d5be00f1.

* dot stuff

* dot stuff 2.0

* Update setup.ps1

* Wrap this up to go
2019-06-12 05:25:38 +10:00
Abhijeet Kasurde
6c23a8df66 VMware: Restrict vcenter_folder for vCenter
Folder creation API is only supported by vCenter, specifying
Standalone ESXi system will raise error.
This fix adds an user warning for suggesting this restriction.

Fixes: #49938

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-11 14:51:38 -04:00
The Magician
31bec0dd95 Bug fixes for GCP modules (#57152) 2019-06-11 13:53:42 -04:00
The Magician
087f560b7c Bug fixes for GCP modules (#57260) 2019-06-11 13:53:27 -04:00
The Magician
142598972d Bug fixes for GCP modules (#57261) 2019-06-11 13:53:13 -04:00
The Magician
ecbd1173b9 New Module: gcp_cloudscheduler_job (#57262) 2019-06-11 13:52:56 -04:00
The Magician
fcff70f887 New Module: gcp_cloudscheduler_job_facts (#57263) 2019-06-11 13:52:41 -04:00
mirfire
20ec5e66e1 Fixed heading link password field in user module (#57694)
##### SUMMARY
In the [user module](https://docs.ansible.com/ansible/latest/modules/user_module.html#user-module), the password field links to `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-crypted-passwords-for-the-user-module`, but the actual link is `https://docs.ansible.com/ansible/faq.html#how-do-i-generate-encrypted-passwords-for-the-user-module` as it was modified in d27d956d71

So I corrected the link in the user module to the actual link. 

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-06-11 11:38:30 -04:00
Mariusz Mazur
1035a9aa49 kubevirt_pvc: fix parameter priority (#57617) 2019-06-11 11:03:32 -04:00
Chris Archibald
98da0e6c99 Bug Fixes for na_ontap_interface (#57363)
* bug fixes

* bug fix
2019-06-11 16:26:39 +02:00
Chris Archibald
e80d6f18ce Duplicate rules were being created if rule index was not set (#57379)
* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf35.

* bug fix
2019-06-11 16:26:02 +02:00
Pilou
c4f336081e fix tower_credential example: lookup are run on controller (#57516)
- don't advise to use lookups in order to fetch path on managed nodes
- fix example:
    - use slurp instead 'file' lookup
    - remove extraneous brackets
2019-06-11 10:25:39 -04:00
Andrey Klychkov
a25acbbf83 postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql (#57684)
* postgresql_idx: self.__exec_sql -> module_utils.postgres.exec_sql

* postgresql_idx: exec_sql, added a changelog fragment

* postgresql_idx: exec_sql, fix the changelog fragment
2019-06-11 10:07:03 -04:00
Christian Claus
aa3b2c47f1 Update azure_rm_virtualmachine.py (#57125)
Docs: Add resource_group values in examples of:
- Power On
- Restart
2019-06-11 08:54:29 -05:00
Andrey Klychkov
a8ebbecd53 postgresql modules: use postgres.exec_sql instead of __exec_sql methods (#57674)
* postgresql modules: use postgres.exec_sql instead of __exec_sql methods

* postgresql modules: use exec_sql, added changelog fragment

* Update changelogs/fragments/57674-postgres_modules_use_exec_sql_instead_of_methods.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-11 13:42:53 +02:00
Andrey Klychkov
f80ac73316 postgresql_idx: add docstrings, remove extra doc lines (#57670) 2019-06-11 06:20:26 -04:00