76d71f034e
* Remove unused imports.
* Clean up ConfigParser usage in ansible-test.
* Fix bare except statements in ansible-test.
* Miscellaneous cleanup from PyCharm inspections.
* Enable pylint no-self-use for ansible-test.
* Remove obsolete pylint ignores for Python 3.7.
* Fix shellcheck issuers under newer shellcheck.
* Use newer path for ansible-test.
* Fix issues in code-smell tests.
(cherry picked from commit ac492476e5)
106 lines
3 KiB
Python
106 lines
3 KiB
Python
"""Sanity test for proper python syntax."""
|
|
from __future__ import absolute_import, print_function
|
|
|
|
import os
|
|
|
|
from lib.sanity import (
|
|
SanityMultipleVersion,
|
|
SanityMessage,
|
|
SanityFailure,
|
|
SanitySuccess,
|
|
SanitySkipped,
|
|
)
|
|
|
|
from lib.util import (
|
|
SubprocessError,
|
|
run_command,
|
|
display,
|
|
find_python,
|
|
read_lines_without_comments,
|
|
parse_to_list_of_dict,
|
|
)
|
|
|
|
from lib.config import (
|
|
SanityConfig,
|
|
)
|
|
|
|
from lib.test import (
|
|
calculate_best_confidence,
|
|
)
|
|
|
|
|
|
class CompileTest(SanityMultipleVersion):
|
|
"""Sanity test for proper python syntax."""
|
|
def test(self, args, targets, python_version):
|
|
"""
|
|
:type args: SanityConfig
|
|
:type targets: SanityTargets
|
|
:type python_version: str
|
|
:rtype: TestResult
|
|
"""
|
|
skip_file = 'test/sanity/compile/python%s-skip.txt' % python_version
|
|
|
|
if os.path.exists(skip_file):
|
|
skip_paths = read_lines_without_comments(skip_file)
|
|
else:
|
|
skip_paths = []
|
|
|
|
paths = sorted(i.path for i in targets.include if (os.path.splitext(i.path)[1] == '.py' or i.path.startswith('bin/')) and i.path not in skip_paths)
|
|
|
|
if not paths:
|
|
return SanitySkipped(self.name, python_version=python_version)
|
|
|
|
cmd = [find_python(python_version), 'test/sanity/compile/compile.py']
|
|
|
|
data = '\n'.join(paths)
|
|
|
|
display.info(data, verbosity=4)
|
|
|
|
try:
|
|
stdout, stderr = run_command(args, cmd, data=data, capture=True)
|
|
status = 0
|
|
except SubprocessError as ex:
|
|
stdout = ex.stdout
|
|
stderr = ex.stderr
|
|
status = ex.status
|
|
|
|
if stderr:
|
|
raise SubprocessError(cmd=cmd, status=status, stderr=stderr, stdout=stdout)
|
|
|
|
if args.explain:
|
|
return SanitySuccess(self.name, python_version=python_version)
|
|
|
|
pattern = r'^(?P<path>[^:]*):(?P<line>[0-9]+):(?P<column>[0-9]+): (?P<message>.*)$'
|
|
|
|
results = parse_to_list_of_dict(pattern, stdout)
|
|
|
|
results = [SanityMessage(
|
|
message=r['message'],
|
|
path=r['path'].replace('./', ''),
|
|
line=int(r['line']),
|
|
column=int(r['column']),
|
|
) for r in results]
|
|
|
|
line = 0
|
|
|
|
for path in skip_paths:
|
|
line += 1
|
|
|
|
if not path:
|
|
continue
|
|
|
|
if not os.path.exists(path):
|
|
# Keep files out of the list which no longer exist in the repo.
|
|
results.append(SanityMessage(
|
|
code='A101',
|
|
message='Remove "%s" since it does not exist' % path,
|
|
path=skip_file,
|
|
line=line,
|
|
column=1,
|
|
confidence=calculate_best_confidence(((skip_file, line), (path, 0)), args.metadata) if args.metadata.changes else None,
|
|
))
|
|
|
|
if results:
|
|
return SanityFailure(self.name, messages=results, python_version=python_version)
|
|
|
|
return SanitySuccess(self.name, python_version=python_version)
|