bc4ef99533
* openstack: standardize tls params * tower: tower_verify_ssl->validate_certs * docker: use standard tls config params - cacert_path -> ca_cert - cert_path -> client_cert - key_path -> client_key - tls_verify -> validate_certs * k8s: standardize tls connection params - verify_ssl -> validate_certs - ssl_ca_cert -> ca_cert - cert_file -> client_cert - key_file -> client_key * ingate: verify_ssl -> validate_certs * manageiq: standardize tls params - verify_ssl -> validate_certs - ca_bundle_path -> ca_cert * mysql: standardize tls params - ssl_ca -> ca_cert - ssl_cert -> client_cert - ssl_key -> client_key * nios: ssl_verify -> validate_certs * postgresql: ssl_rootcert -> ca_cert * rabbitmq: standardize tls params - cacert -> ca_cert - cert -> client_cert - key -> client_key * rackspace: verify_ssl -> validate_certs * vca: verify_certs -> validate_certs * kubevirt_cdi_upload: upload_host_verify_ssl -> upload_host_validate_certs * lxd: standardize tls params - key_file -> client_key - cert_file -> client_cert * get_certificate: ca_certs -> ca_cert * get_certificate.py: clarify one or more certs in a file Co-Authored-By: jamescassell <code@james.cassell.me> * zabbix: tls_issuer -> ca_cert * bigip_device_auth_ldap: standardize tls params - ssl_check_peer -> validate_certs - ssl_client_cert -> client_cert - ssl_client_key -> client_key - ssl_ca_cert -> ca_cert * vdirect: vdirect_validate_certs -> validate_certs * mqtt: standardize tls params - ca_certs -> ca_cert - certfile -> client_cert - keyfile -> client_key * pulp_repo: standardize tls params remove `importer_ssl` prefix * rhn_register: sslcacert -> ca_cert * yum_repository: standardize tls params The fix for yum_repository is not straightforward since this module is only a thin wrapper for the underlying commands and config. In this case, we add the new values as aliases, keeping the old as primary, only due to the internal structure of the module. Aliases added: - sslcacert -> ca_cert - sslclientcert -> client_cert - sslclientkey -> client_key - sslverify -> validate_certs * gitlab_hook: enable_ssl_verification -> hook_validate_certs * Adjust arguments for docker_swarm inventory plugin. * foreman callback: standardize tls params - ssl_cert -> client_cert - ssl_key -> client_key * grafana_annotations: validate_grafana_certs -> validate_certs * nrdp callback: validate_nrdp_certs -> validate_certs * kubectl connection: standardize tls params - kubectl_cert_file -> client_cert - kubectl_key_file -> client_key - kubectl_ssl_ca_cert -> ca_cert - kubectl_verify_ssl -> validate_certs * oc connection: standardize tls params - oc_cert_file -> client_cert - oc_key_file -> client_key - oc_ssl_ca_cert -> ca_cert - oc_verify_ssl -> validate_certs * psrp connection: cert_trust_path -> ca_cert TODO: cert_validation -> validate_certs (multi-valued vs bool) * k8s inventory: standardize tls params - cert_file -> client_cert - key_file -> client_key - ca_cert -> ca_cert - verify_ssl -> validate_certs * openshift inventory: standardize tls params - cert_file -> client_cert - key_file -> client_key - ca_cert -> ca_cert - verify_ssl -> validate_certs * tower inventory: verify_ssl -> validate_certs * hashi_vault lookup: cacert -> ca_cert * k8s lookup: standardize tls params - cert_file -> client_cert - key_file -> client_key - ca_cert -> ca_cert - verify_ssl -> validate_certs * laps_passord lookup: cacert_file -> ca_cert * changelog for TLS parameter standardization
252 lines
8.2 KiB
Python
252 lines
8.2 KiB
Python
# (c) 2018 Red Hat, Inc.
|
|
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
__metaclass__ = type
|
|
|
|
import sys
|
|
import copy
|
|
|
|
from units.compat import unittest
|
|
from units.compat.mock import patch, MagicMock, Mock
|
|
from ansible.module_utils.net_tools.nios import api
|
|
|
|
|
|
class TestNiosApi(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestNiosApi, self).setUp()
|
|
|
|
self.module = MagicMock(name='AnsibleModule')
|
|
self.module.check_mode = False
|
|
self.module.params = {'provider': None}
|
|
|
|
self.mock_connector = patch('ansible.module_utils.net_tools.nios.api.get_connector')
|
|
self.mock_connector.start()
|
|
|
|
def tearDown(self):
|
|
super(TestNiosApi, self).tearDown()
|
|
|
|
self.mock_connector.stop()
|
|
|
|
def test_get_provider_spec(self):
|
|
provider_options = ['host', 'username', 'password', 'validate_certs', 'silent_ssl_warnings',
|
|
'http_request_timeout', 'http_pool_connections',
|
|
'http_pool_maxsize', 'max_retries', 'wapi_version', 'max_results']
|
|
res = api.WapiBase.provider_spec
|
|
self.assertIsNotNone(res)
|
|
self.assertIn('provider', res)
|
|
self.assertIn('options', res['provider'])
|
|
returned_options = res['provider']['options']
|
|
self.assertEqual(sorted(provider_options), sorted(returned_options.keys()))
|
|
|
|
def _get_wapi(self, test_object):
|
|
wapi = api.WapiModule(self.module)
|
|
wapi.get_object = Mock(name='get_object', return_value=test_object)
|
|
wapi.create_object = Mock(name='create_object')
|
|
wapi.update_object = Mock(name='update_object')
|
|
wapi.delete_object = Mock(name='delete_object')
|
|
return wapi
|
|
|
|
def test_wapi_no_change(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
|
|
'comment': 'test comment', 'extattrs': None}
|
|
|
|
test_object = [
|
|
{
|
|
"comment": "test comment",
|
|
"_ref": "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:default/true",
|
|
"name": self.module._check_type_dict().__getitem__(),
|
|
"extattrs": {}
|
|
}
|
|
]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertFalse(res['changed'])
|
|
|
|
def test_wapi_change(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
|
|
'comment': 'updated comment', 'extattrs': None}
|
|
|
|
test_object = [
|
|
{
|
|
"comment": "test comment",
|
|
"_ref": "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:default/true",
|
|
"name": "default",
|
|
"extattrs": {}
|
|
}
|
|
]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.update_object.called_once_with(test_object)
|
|
|
|
def test_wapi_change_false(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
|
|
'comment': 'updated comment', 'extattrs': None, 'fqdn': 'foo'}
|
|
|
|
test_object = [
|
|
{
|
|
"comment": "test comment",
|
|
"_ref": "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:default/true",
|
|
"name": "default",
|
|
"extattrs": {}
|
|
}
|
|
]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"fqdn": {"ib_req": True, 'update': False},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.update_object.called_once_with(test_object)
|
|
|
|
def test_wapi_extattrs_change(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
|
|
'comment': 'test comment', 'extattrs': {'Site': 'update'}}
|
|
|
|
ref = "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:default/true"
|
|
|
|
test_object = [{
|
|
"comment": "test comment",
|
|
"_ref": ref,
|
|
"name": "default",
|
|
"extattrs": {'Site': {'value': 'test'}}
|
|
}]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
kwargs = copy.deepcopy(test_object[0])
|
|
kwargs['extattrs']['Site']['value'] = 'update'
|
|
kwargs['name'] = self.module._check_type_dict().__getitem__()
|
|
del kwargs['_ref']
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.update_object.assert_called_once_with(ref, kwargs)
|
|
|
|
def test_wapi_extattrs_nochange(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
|
|
'comment': 'test comment', 'extattrs': {'Site': 'test'}}
|
|
|
|
test_object = [{
|
|
"comment": "test comment",
|
|
"_ref": "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:default/true",
|
|
"name": self.module._check_type_dict().__getitem__(),
|
|
"extattrs": {'Site': {'value': 'test'}}
|
|
}]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertFalse(res['changed'])
|
|
|
|
def test_wapi_create(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'ansible',
|
|
'comment': None, 'extattrs': None}
|
|
|
|
test_object = None
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.create_object.assert_called_once_with('testobject', {'name': self.module._check_type_dict().__getitem__()})
|
|
|
|
def test_wapi_delete(self):
|
|
self.module.params = {'provider': None, 'state': 'absent', 'name': 'ansible',
|
|
'comment': None, 'extattrs': None}
|
|
|
|
ref = "networkview/ZG5zLm5ldHdvcmtfdmlldyQw:ansible/false"
|
|
|
|
test_object = [{
|
|
"comment": "test comment",
|
|
"_ref": ref,
|
|
"name": "ansible",
|
|
"extattrs": {'Site': {'value': 'test'}}
|
|
}]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.delete_object.assert_called_once_with(ref)
|
|
|
|
def test_wapi_strip_network_view(self):
|
|
self.module.params = {'provider': None, 'state': 'present', 'name': 'ansible',
|
|
'comment': 'updated comment', 'extattrs': None,
|
|
'network_view': 'default'}
|
|
|
|
test_object = [{
|
|
"comment": "test comment",
|
|
"_ref": "view/ZG5zLm5ldHdvcmtfdmlldyQw:ansible/true",
|
|
"name": "ansible",
|
|
"extattrs": {},
|
|
"network_view": "default"
|
|
}]
|
|
|
|
test_spec = {
|
|
"name": {"ib_req": True},
|
|
"network_view": {"ib_req": True},
|
|
"comment": {},
|
|
"extattrs": {}
|
|
}
|
|
|
|
kwargs = test_object[0].copy()
|
|
ref = kwargs.pop('_ref')
|
|
kwargs['comment'] = 'updated comment'
|
|
kwargs['name'] = self.module._check_type_dict().__getitem__()
|
|
del kwargs['network_view']
|
|
del kwargs['extattrs']
|
|
|
|
wapi = self._get_wapi(test_object)
|
|
res = wapi.run('testobject', test_spec)
|
|
|
|
self.assertTrue(res['changed'])
|
|
wapi.update_object.assert_called_once_with(ref, kwargs)
|