ansible/test/units/modules/network
Chris Van Heuveln 0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
2019-06-28 16:18:46 +05:30
..
aireos
aruba
asa
basics
checkpoint
cli
cloudvision
cnos
cumulus
dellos6
dellos9
dellos10
edgeos
edgeswitch
enos
eos
exos
f5 adds initial_hotfix parameter to vcmp guest (#58180) 2019-06-25 15:26:09 +02:00
fortimanager
frr
ftd FTD configuration module: fix a bug with response parsing (#57480) 2019-06-10 18:30:35 +05:30
ingate
ios Revert nxos, ios, iosxr return_timestamps (#56206) 2019-05-08 20:49:29 +05:30
iosxr Revert nxos, ios, iosxr return_timestamps (#56206) 2019-05-08 20:49:29 +05:30
ironware
itential
junos
netact
netscaler
netvisor Pluribus Networks ipv6security raguard module with UT (#57031) 2019-06-24 16:29:41 +05:30
nos
nso
nuage
nxos nxos_vpc: pkl_vrf fixes for #57069 (#57370) 2019-06-28 16:18:46 +05:30
onyx Adding New Model onyx_qos for Configuring QoS on Onyx Switches (#55127) 2019-05-17 14:20:56 -04:00
opx
ovs Fix ovsdb module not being idempotent (#57735) 2019-06-26 10:48:46 -04:00
radware Changing the license to Apache 2 2019-05-20 10:14:32 -07:00
routeros
slxos
voss
vyos
__init__.py