ansible/test
Matt Martz 34809f2b02 [stable-2.7] Ensure that the src file contents is converted to unicode in diff info (#45744)
* Ensure that the src file contents is converted to unicode in diff info. Fixes #45717

* Fix up and cleanup

* The diff functionality in the callback plugins should have the
  to_text() calls removed since we're now doing it in ActionBase
* catching of UnicodeError and warnings in the callback diff
  functionality from 61d01f549f haven't been
  needed since we switched to to_text so remove them.
* Add a note to ActionBase's diff function giving an example of when the
  diff function will be inaccurate and how to fix it

* Fix callback get_diff() tests

I believe the unittests of callback's get_diff() were wrong.  They were
sending in a list where strings were expected.  Because previous code
was transforming the lists into strings via their repr, the previous
tests did not fail but they would have formatted the test cases output
in an odd way if we had looked at it.
(cherry picked from commit 95e77ac)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-01-09 14:47:42 -08:00
..
cache
env [stable-2.7] Add env command to ansible-test and run in CI. (#50176) 2018-12-22 00:10:16 -08:00
integration Fix rabbitmq_plugin test. 2019-01-07 16:03:07 -08:00
legacy vultr_server: fix multiple ssh keys not handled (#50337) 2019-01-07 11:05:25 -08:00
results
runner [stable-2.7] Add env command to ansible-test and run in CI. (#50176) 2018-12-22 00:10:16 -08:00
sanity [stable-2.7] Add retries for Invoke-ScriptAnalyzer in pslint. 2018-12-21 20:27:05 -08:00
units [stable-2.7] Ensure that the src file contents is converted to unicode in diff info (#45744) 2019-01-09 14:47:42 -08:00
utils [stable-2.7] Fix run.py --branch argument. 2019-01-07 16:50:31 -08:00