ea04e0048d
* Allow to deprecate options and aliases by date instead of only by version. * Update display.deprecate(). * Adjust behavior to conform to tested behavior, extend tests, and improve C# style. * Parse date and fail on invalid date. This is mainly to make sure that people start using invalid dates, and we eventually have a mess to clean up. * C# code: improve validation and update/extend tests. * Make sure that deprecate() is not called with both date and version. * Forgot to remove no longer necessary formatting. * Adjust order of warnings in C# code. * Adjust unrelated test. * Fix grammar (and make that test pass). * Don't parse date, and adjust message to be same as in #67684. * Sanity tests: disable date in past test. * Validate-modules: validate ISO 8601 date format. * Validate-modules: switch schema declaration for deprecated_aliases to improve error messages for invalid dates. * Use DateTime instead of string for date deprecation. * Validate that date in deprecated_aliases is actually a DateTime. * Fix tests. * Fix rebasing error. * Adjust error codes for pylint, and add removed_at_date and deprecated_aliases.date checks to validate-modules. * Make deprecation date in the past error codes optional. * Make sure not both version and date are specified for AnsibleModule.deprecate() calls. * Stop using Python 3.7+ API. * Make sure errors are actually reported. Re-add 'ansible-' prefix. * Avoid crashing when 'name' isn't there. * Linting. * Update lib/ansible/module_utils/csharp/Ansible.Basic.cs Co-authored-by: Jordan Borean <jborean93@gmail.com> * Adjust test to latest change. * Prefer date over version if both end up in Display.deprecated(). Co-authored-by: Jordan Borean <jborean93@gmail.com>
62 lines
2.1 KiB
Python
62 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
#
|
|
# Copyright (c) 2017 Ansible Project
|
|
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
|
|
import json
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize('stdin', [{}], indirect=['stdin'])
|
|
def test_warn(am, capfd):
|
|
|
|
am.warn('warning1')
|
|
|
|
with pytest.raises(SystemExit):
|
|
am.exit_json(warnings=['warning2'])
|
|
out, err = capfd.readouterr()
|
|
assert json.loads(out)['warnings'] == ['warning1', 'warning2']
|
|
|
|
|
|
@pytest.mark.parametrize('stdin', [{}], indirect=['stdin'])
|
|
def test_deprecate(am, capfd):
|
|
am.deprecate('deprecation1')
|
|
am.deprecate('deprecation2', '2.3')
|
|
am.deprecate('deprecation3', version='2.4')
|
|
am.deprecate('deprecation4', date='2020-03-10')
|
|
|
|
with pytest.raises(SystemExit):
|
|
am.exit_json(deprecations=['deprecation5', ('deprecation6', '2.4')])
|
|
|
|
out, err = capfd.readouterr()
|
|
output = json.loads(out)
|
|
assert ('warnings' not in output or output['warnings'] == [])
|
|
assert output['deprecations'] == [
|
|
{u'msg': u'deprecation1', u'version': None},
|
|
{u'msg': u'deprecation2', u'version': '2.3'},
|
|
{u'msg': u'deprecation3', u'version': '2.4'},
|
|
{u'msg': u'deprecation4', u'date': '2020-03-10'},
|
|
{u'msg': u'deprecation5', u'version': None},
|
|
{u'msg': u'deprecation6', u'version': '2.4'},
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize('stdin', [{}], indirect=['stdin'])
|
|
def test_deprecate_without_list(am, capfd):
|
|
with pytest.raises(SystemExit):
|
|
am.exit_json(deprecations='Simple deprecation warning')
|
|
|
|
out, err = capfd.readouterr()
|
|
output = json.loads(out)
|
|
assert ('warnings' not in output or output['warnings'] == [])
|
|
assert output['deprecations'] == [
|
|
{u'msg': u'Simple deprecation warning', u'version': None},
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize('stdin', [{}], indirect=['stdin'])
|
|
def test_deprecate_without_list(am, capfd):
|
|
with pytest.raises(AssertionError) as ctx:
|
|
am.deprecate('Simple deprecation warning', date='', version='')
|
|
assert ctx.value.args[0] == "implementation error -- version and date must not both be set"
|