489156378c
* Initial commit for rate limiting - Detects if error code is 429 - Pauses for random time between .5 and 5 seconds before retrying - If it fails 10 times, give up and tell user * Redo structure of request() to support rate limiting * Hold down timer is now a sliding scale - 3 * number of retries - Fails after the 30 second wait * Whitespace fixes * Redo implementation using decorators - Errors aren't tested but code works for regular calls * Unit tests work for error handling * Add integration tests for successful retries * Add condition for 502 errors and retry * Move _error_report out of the class * PEP8 fixes * Add changelog entry
160 lines
4.9 KiB
Python
160 lines
4.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2019 Kevin Breit <kevin.breit@kevinbreit.net>
|
|
|
|
# This file is part of Ansible by Red Hat
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import json
|
|
import os
|
|
import pytest
|
|
|
|
from units.compat import unittest, mock
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
from ansible.module_utils.network.meraki.meraki import MerakiModule, meraki_argument_spec, HTTPError, RateLimitException
|
|
from ansible.module_utils.six import PY2, PY3
|
|
from ansible.module_utils._text import to_native, to_bytes
|
|
from units.modules.utils import set_module_args
|
|
|
|
fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
|
|
fixture_data = {}
|
|
testcase_data = {
|
|
"params": {'orgs': ['orgs.json'],
|
|
}
|
|
}
|
|
|
|
|
|
def load_fixture(name):
|
|
path = os.path.join(fixture_path, name)
|
|
|
|
if path in fixture_data:
|
|
return fixture_data[path]
|
|
|
|
with open(path) as f:
|
|
data = f.read()
|
|
|
|
# try:
|
|
data = json.loads(data)
|
|
# except Exception:
|
|
# pass
|
|
|
|
fixture_data[path] = data
|
|
return data
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def module():
|
|
argument_spec = meraki_argument_spec()
|
|
set_module_args({'auth_key': 'abc123',
|
|
})
|
|
module = AnsibleModule(argument_spec=argument_spec,
|
|
supports_check_mode=False)
|
|
return MerakiModule(module)
|
|
|
|
|
|
def mocked_fetch_url(*args, **kwargs):
|
|
print(args)
|
|
if args[1] == 'https://api.meraki.com/api/v0/404':
|
|
info = {'status': 404,
|
|
'msg': '404 - Page is missing',
|
|
'url': 'https://api.meraki.com/api/v0/404',
|
|
}
|
|
info['body'] = '404'
|
|
elif args[1] == 'https://api.meraki.com/api/v0/429':
|
|
info = {'status': 429,
|
|
'msg': '429 - Rate limit hit',
|
|
'url': 'https://api.meraki.com/api/v0/429',
|
|
}
|
|
info['body'] = '429'
|
|
return (None, info)
|
|
|
|
|
|
def mocked_fetch_url_rate_success(module, *args, **kwargs):
|
|
if module.retry_count == 5:
|
|
info = {'status': 200,
|
|
'url': 'https://api.meraki.com/api/organization',
|
|
}
|
|
resp = {'body': 'Succeeded'}
|
|
else:
|
|
info = {'status': 429,
|
|
'msg': '429 - Rate limit hit',
|
|
'url': 'https://api.meraki.com/api/v0/429',
|
|
}
|
|
info['body'] = '429'
|
|
return (resp, info)
|
|
|
|
|
|
def mocked_fail_json(*args, **kwargs):
|
|
pass
|
|
|
|
|
|
def mocked_sleep(*args, **kwargs):
|
|
pass
|
|
|
|
|
|
def test_fetch_url_404(module, mocker):
|
|
url = '404'
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url', side_effect=mocked_fetch_url)
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.MerakiModule.fail_json', side_effect=mocked_fail_json)
|
|
with pytest.raises(HTTPError):
|
|
data = module.request(url, method='GET')
|
|
assert module.status == 404
|
|
|
|
|
|
def test_fetch_url_429(module, mocker):
|
|
url = '429'
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url', side_effect=mocked_fetch_url)
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.MerakiModule.fail_json', side_effect=mocked_fail_json)
|
|
mocker.patch('time.sleep', return_value=None)
|
|
with pytest.raises(RateLimitException):
|
|
data = module.request(url, method='GET')
|
|
assert module.status == 429
|
|
|
|
|
|
def test_fetch_url_429_success(module, mocker):
|
|
url = '429'
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.fetch_url', side_effect=mocked_fetch_url_rate_success)
|
|
mocker.patch('ansible.module_utils.network.meraki.meraki.MerakiModule.fail_json', side_effect=mocked_fail_json)
|
|
mocker.patch('time.sleep', return_value=None)
|
|
# assert module.status == 200
|
|
|
|
|
|
def test_define_protocol_https(module):
|
|
module.params['use_https'] = True
|
|
module.define_protocol()
|
|
testdata = module.params['protocol']
|
|
assert testdata == 'https'
|
|
|
|
|
|
def test_define_protocol_http(module):
|
|
module.params['use_https'] = False
|
|
module.define_protocol()
|
|
testdata = module.params['protocol']
|
|
assert testdata == 'http'
|
|
|
|
|
|
def test_is_org_valid_org_name(module):
|
|
data = load_fixture('orgs.json')
|
|
org_count = module.is_org_valid(data, org_name="My organization")
|
|
assert org_count == 1
|
|
|
|
|
|
def test_is_org_valid_org_id(module):
|
|
data = load_fixture('orgs.json')
|
|
org_count = module.is_org_valid(data, org_id=2930418)
|
|
assert org_count == 1
|