ansible/changelogs/fragments
Rick Elrod 707458cc8c
Make netbsd virtualization facts more specific (#70467)
Change:
Our handling of NetBSD virtualization facts led to facts that were just
plain incorrect. One example is reporting Xen even when the system is
running on something completely different (like KVM).

As stated by the reporter of #69352, NetBSD has a better sysctl setting
to use for this information, machdep.hypervisor.

This PR does the following:

- Try to use machdep.hypervisor sysctl value if the other sysctl values
  we check don't end up with enough information to be useful
- Only look for /dev/xencons and assume Xen if nothing else works
  (Really this should probably return 'unknown' since the file exists on
  non-Xen systems and is not very useful).
- Add a few more patterns (Xen matches and also Hyper-V) to
  VirtualSysctlDetectionMixin#detect_virt_product.

This change is slightly breaking:
- If the first two attempts at using sysctl worked before,
  (machdep.dmi.system-product and machdep.dmi.system-vendor), they will
  continue to work.
- For cases when those values didn't work, previously the existence of
  /dev/xencons was checked, and if found, we reported 'xen' (even on
  non-Xen systems when the file existed). After this PR, we try the
  machdep.hypervisor sysctl key before still falling back to
  /dev/xencons. This means that in some cases, we might go from
  (wrongly) saying "xen" to giving a more accurate value such as "kvm"
  or "Hyper-V".

Test Plan:
- Tested with local NetBSD VM and got 'kvm' instead of 'xen' back.

Tickets:
- Fixes #69352

Signed-off-by: Rick Elrod <rick@elrod.me>
2020-07-07 17:28:13 -05:00
..
565_default_callback.yml default_callback: Move 'check_mode_markers' in doc_fragments (#70228) 2020-06-23 16:26:09 -04:00
63105-wcswidth.yml Use libc wcwidth to calculate print width in display (#66214) 2020-06-22 16:57:01 -05:00
65262_ansible_inventory.yml Suppress warning for user directory in ansible-inventory (#65344) 2020-07-02 16:22:21 -04:00
69352-netbsd-virtual-facts.yml Make netbsd virtualization facts more specific (#70467) 2020-07-07 17:28:13 -05:00
69463-fix-apt_repository-typeerror- instancemethod.yaml Fixed TypeError instancemethod expecting at least 2 arguments (#69463) 2020-07-02 00:01:31 -04:00
70017-avoid-params-to-callable-checkers.yml Only pass kwargs to our string checker not callable checkers (#70151) 2020-06-19 09:52:05 -04:00
70042-dnf-repository-hotfixes.yml Add new option for YUM4/DNF repositories (#70042) 2020-06-30 15:48:36 -04:00
70045-ansible-doc-yaml-anchors.yml ansible-doc: avoid problems with YAML anchors when formatting man page (#70045) 2020-06-30 15:33:44 -04:00
70046-ansible-doc-description-crash.yml ansible-doc man formatter: fail with better error message when description isn't there (#70046) 2020-07-06 13:29:03 -04:00
70056-add-a-param-to-apt-module-to-avoid-unintended-uninstalls.yml apt - add fail_on_autoremove option to avoid unintended package removals (#70056) 2020-06-30 09:53:14 -04:00
70099-make-apt-errors-more-transparent.yaml apt - make errors more transparent (#70099) 2020-07-06 12:20:09 -04:00
70122-improve-error-message-ssh-client-is-not-found.yml Improve error message when ssh client is not found on the host (#70122) 2020-06-29 17:26:19 -04:00
70148-galaxy-role-info.yaml Fix galaxy role info bug to support multiple roles (#70148) 2020-06-23 16:57:25 -04:00
70168-fix-delegate_facts-without-interpreter-set.yml Fix delegate_facts with interpreter not being set (#70293) 2020-06-30 15:49:09 +02:00
70244-selinux-special-fs.yml Fix string/bytestring comparsion in m_u.basic (#70439) 2020-07-07 11:48:05 -04:00
70256_stat_colon_split.yml stat: Handle colon in filename (#70259) 2020-06-25 14:21:50 -05:00
70258-hash-filter-fail-unsupported-type.yml hash filter - fail when unsupported type is passed as an argument (#70292) 2020-06-25 14:55:21 -05:00
70344-plugin-deprecation-collection-name.yml Top-level deprecation of plugin did not get collection_name added when deprecating by version (#70344) 2020-06-29 11:58:54 -07:00
70375-galaxy-server.yml Use the first galaxy server supporting v1 for roles (#70375) 2020-07-01 14:58:35 -05:00
70437-ssh-args.yml ssh connection - use get_option() rather than _play_context (#70438) 2020-07-02 15:04:58 -04:00
ansible-boilerplate.yml Fix boilerplate in setup.py and lib/ansible/ dir. 2020-06-22 16:29:16 -07:00
ansible-galaxy-stdout.yml Improve ansible-galaxy STDOUT messages for collections (#70040) 2020-06-29 15:18:30 -04:00
ansible-test-cleanup-pylint-config.yml Clean up ansible-test pylint configs. (#70129) 2020-06-17 15:06:04 -07:00
ansible-test-coverage-code-cleanup.yml Code cleanup for ansible-test coverage support. 2020-06-24 17:39:35 -07:00
ansible-test-pylint-plugin-name.yml Rename pylint plugin and add tests. (#70225) 2020-06-22 20:25:35 -07:00
ansible-test-rhel-requirements.yml Pin ansible-test requirements for RHEL. 2020-06-23 11:52:25 -07:00
ansible-test-sanity-ansible-doc.yml Test netconf plugins in ansible-doc sanity test. 2020-06-24 15:53:32 -07:00
ansible-test-sanity-importer-cleanup.yml Code cleanup in the import sanity test. 2020-06-23 23:09:00 -07:00
ansible-test-sanity-yamllint-lineno.yml Fix yamllint sanity test line numbers. 2020-06-18 10:03:21 -07:00
changelog-yaml.yml Include changelogs/changelog.yaml in distribution. (#70260) 2020-06-24 11:38:20 -05:00
collection-ad-hoc.yml Add collection path in CLI version info (#68633) 2020-06-25 01:58:56 -04:00
collection_meta_use_libyaml.yml misc collection metadata fixes (#70403) 2020-07-01 14:09:21 -04:00
crypt-oserror.yml Throw AnsibleError instead of OSError, py3.9 crypt (#70246) 2020-06-24 13:50:28 -05:00
deprecation-callback-get_item.yml Nuke _get_item() from callback, deprecated 2.11 (#70233) 2020-06-23 12:03:27 -04:00
deprecation-strategy-SharedPluginLoaderObj.yml Nuke strategy.SharedPluginLoaderObj, depr. 2.11 (#70235) 2020-06-23 13:09:26 -04:00
deprecation-systemd-user.yml Nuke systemd module user option, 2.11 deprecation (#70211) 2020-06-23 11:55:01 -04:00
deprecation-taskexecutor-squash.yml Nuke with_ squashing, deprecated for 2.11 (#70209) 2020-06-23 11:53:25 -04:00
display-stdout-column-width.yml display: use stdout for column width (#70199) 2020-06-25 12:57:24 +05:30
distribution_support_parrot.yml Add support for Parrot Linux, a Debian derivate (#69158) 2020-06-29 20:22:44 +05:30
fix_lp_flat.yml fix flatten handling of nulls/nones (#70141) 2020-07-01 18:52:03 -04:00
git-add-single_branch.yml git - add single_branch option (#28465) 2020-06-29 15:40:54 -04:00
pause-catch-error-when-no-std-exists.yml pause - fix curses.setupterm() error (#47851) 2020-06-29 10:37:40 -04:00
plugin-loader-cleanup.yml Change comprehension to list() in plugin loader. 2020-06-18 12:29:52 -07:00
runtime-splunk-redirect.yml fix runtime.yml splunk.enterprise_security -> splunk.es (#70305) 2020-06-25 18:34:11 +01:00
syslog-prettier-error.yml Throw a prettier error in m_u.basic syslog (#70312) 2020-07-01 09:28:48 -05:00
v2.11.0-initial-commit.yaml Bump devel to 2.11.0 (#70121) 2020-06-17 14:22:38 -05:00
validate-modules-ps-doc-blacklist.yaml ansible-test - do not validate blacklisted ps modules (#70376) 2020-07-01 07:59:53 +10:00
win_setup-redirection.yaml Fix up the redirection of the win setup module (#70158) 2020-06-19 09:24:35 -07:00
with_seq_example.yml with_sequence: example using vars (#69369) 2020-07-01 16:12:48 -04:00