ceb474bb9e
Batch of docs backports: * docs: Clarify include_task v import_tasks with conditionals (#43856) (cherry picked from commit6be42a2a0e) * Add single quotes around package name (#45152) (cherry picked from commit0d81386144) * prefer ansible_facts namespace and dict notation (#44980) (cherry picked from commit44510448b0) * fix cherrypick conflict - scenario_guides * Update implicit_localhost.rst (#45455) (cherry picked from commitf68cd1acc6) * updated fbsd install instructions (#45309) (cherry picked from commite9c2695ce7) * Change "Defaulting Undefined Variables" (#41379) (cherry picked from commite35c4be1c1) * adds license details to dev guide pages (#45574) (cherry picked from commit6e68d77f6d) * FAQ: fix a typo, add link to 'vars' lookup (#42412) (cherry picked from commit95649dc793) * Fix link and toctree (#45595) (cherry picked from commit6999bf318f) * Improve the local toctree (and title) (#45590) (cherry picked from commitafea00fa9f) * Add undocumented configuration parameter and explain in porting guide (#36059) (cherry picked from commita892a6ef03) * Simplify PPA installation for Ubuntu (#45690) (cherry picked from commit78e9f452a5) * adding git+ssh uri scheme (#36025) (cherry picked from commit84a4257774) * Add workaround for non-standard kerberos environments (#41465) (cherry picked from commit4e532e0ad9) * Restore license agreement (#45809) (cherry picked from commitf430f60541) * partial cherry-pick - lenovo doc update PR 45483
59 lines
1.9 KiB
ReStructuredText
59 lines
1.9 KiB
ReStructuredText
:orphan:
|
|
|
|
.. _testing_pep8:
|
|
|
|
*****
|
|
PEP 8
|
|
*****
|
|
|
|
.. contents:: Topics
|
|
|
|
`PEP 8`_ style guidelines are enforced by `pycodestyle`_ on all python files in the repository by default.
|
|
|
|
Current Rule Set
|
|
================
|
|
|
|
By default all files are tested using the current rule set.
|
|
All `PEP 8`_ tests are executed, except those listed in the `current ignore list`_.
|
|
|
|
.. warning: Updating the Rule Set
|
|
|
|
Changes to the Rule Set need approval from the Core Team, and must be done via the `Testing Working Group <https://github.com/ansible/community/blob/master/meetings/README.md>`_.
|
|
|
|
Legacy Rule Set
|
|
===============
|
|
|
|
Files which are listed in the `legacy file list`_ are tested using the legacy rule set.
|
|
|
|
All `PEP 8`_ tests are executed, except those listed in the `current ignore list`_ or `legacy ignore list`_.
|
|
|
|
Files listed in the legacy file list which pass the current rule set will result in an error.
|
|
|
|
This is intended to prevent regressions on style guidelines for files which pass the more stringent current rule set.
|
|
|
|
Skipping Tests
|
|
==============
|
|
|
|
Files listed in the `skip list`_ are not tested by `pycodestyle`_.
|
|
|
|
Removed Files
|
|
=============
|
|
|
|
Files which have been removed from the repository must be removed from the legacy file list and the skip list.
|
|
|
|
Running Locally
|
|
===============
|
|
|
|
The `PEP 8`_ check can be run locally with::
|
|
|
|
|
|
./test/runner/ansible-test sanity --test pep8 [file-or-directory-path-to-check] ...
|
|
|
|
|
|
|
|
.. _PEP 8: https://www.python.org/dev/peps/pep-0008/
|
|
.. _pycodestyle: https://pypi.org/project/pycodestyle/
|
|
.. _current ignore list: https://github.com/ansible/ansible/blob/devel/test/sanity/pep8/current-ignore.txt
|
|
.. _legacy file list: https://github.com/ansible/ansible/blob/devel/test/sanity/pep8/legacy-files.txt
|
|
.. _legacy ignore list: https://github.com/ansible/ansible/blob/devel/test/sanity/pep8/legacy-ignore.txt
|
|
.. _skip list: https://github.com/ansible/ansible/blob/devel/test/sanity/pep8/skip.txt
|