ansible/changelogs
Sam Doran 7e4cffc5d2
[stable-2.10] Change default file permissions so they are not world readable (#70221) (#70824)
* Change default file permissions so they are not world readable

CVE-2020-1736

Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.

A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.

- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit 5260527c4a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2020-07-23 09:07:18 -07:00
..
fragments [stable-2.10] Change default file permissions so they are not world readable (#70221) (#70824) 2020-07-23 09:07:18 -07:00
CHANGELOG-v2.10.rst New release v2.10.0b1 2020-06-17 14:38:15 -05:00
CHANGELOG.rst
changelog.yaml New release v2.10.0b1 2020-06-17 14:38:15 -05:00
config.yaml Use antsibull-changelog instead of packaged changelog generator (#69313) 2020-06-11 11:21:21 -07:00