8a0abed1ba
Change: - Hostname strategies' get_*() methods should never write to the filesystem. They are used in check_mode by default to determine if there is any work to be done. Test Plan: - New unit tests to ensure that (at least when in check_mode) the get methods don't ever call write. Tickets: - Fixes #66432 Signed-off-by: Rick Elrod <rick@elrod.me>
35 lines
1.3 KiB
Python
35 lines
1.3 KiB
Python
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
from units.compat.mock import patch, MagicMock, mock_open
|
|
from ansible.module_utils import basic
|
|
from ansible.module_utils.common._utils import get_all_subclasses
|
|
from ansible.modules import hostname
|
|
from units.modules.utils import ModuleTestCase, set_module_args
|
|
from ansible.module_utils.six import PY2
|
|
|
|
|
|
class TestHostname(ModuleTestCase):
|
|
@patch('os.path.isfile')
|
|
def test_stategy_get_never_writes_in_check_mode(self, isfile):
|
|
isfile.return_value = True
|
|
|
|
set_module_args({'name': 'fooname', '_ansible_check_mode': True})
|
|
subclasses = get_all_subclasses(hostname.GenericStrategy)
|
|
module = MagicMock()
|
|
for cls in subclasses:
|
|
instance = cls(module)
|
|
|
|
instance.module.run_command = MagicMock()
|
|
instance.module.run_command.return_value = (0, '', '')
|
|
|
|
m = mock_open()
|
|
builtins = 'builtins'
|
|
if PY2:
|
|
builtins = '__builtin__'
|
|
with patch('%s.open' % builtins, m):
|
|
instance.get_permanent_hostname()
|
|
instance.get_current_hostname()
|
|
self.assertFalse(
|
|
m.return_value.write.called,
|
|
msg='%s called write, should not have' % str(cls))
|