No description
Find a file
Adrian Likins 95abc1d82e Fix fact failures cause by ordering of collectors (#30777)
* Fix fact failures cause by ordering of collectors

Some fact collectors need info collected by other facts.
(for ex, service_mgr needs to know 'ansible_system').
This info is passed to the Collector.collect method via
the 'collected_facts' info.

But, the order the fact collectors were running in is
not a set order, so collectors like service_mgr could
run before the PlatformFactCollect ('ansible_system', etc),
so the 'ansible_system' fact would not exist yet. 

Depending on the collector and the deps, this can result
in incorrect behavior and wrong or missing facts.

To make the ordering of the collectors more consistent
and predictable, the code that builds that list is now
driven by the order of collectors in default_collectors.py,
and the rest of the code tries to preserve it.

* Flip the loops when building collector names

iterate over the ordered default_collectors list
selecting them for the final list in order instead
of driving it from the unordered collector_names set.

This lets the list returned by select_collector_classes
to stay in the same order as default_collectors.collectors

For collectors that have implicit deps on other fact collectors,
the default collectors can be ordered to include those early.

* default_collectors.py now uses a handful of sub lists of
collectors that can be ordered in default_collectors.collectors.

fixes #30753
fixes #30623
2017-09-28 10:36:22 -04:00
.github I am officially done with the unarchive module 2017-09-28 10:56:56 +02:00
bin nicer error on bad ansible config (#30461) 2017-09-19 10:50:28 -04:00
contrib Add a select_chain_match filter to vmware_inventory (#28778) 2017-09-27 19:06:01 -04:00
docs correct the Python 3 Pip environment setup instructions (#30988) 2017-09-28 13:21:38 +10:00
examples dont override previous ini entries with defaults 2017-09-20 16:38:11 -04:00
hacking Allow AWS image and snapshot creation/deletion 2017-09-19 23:12:50 -07:00
lib/ansible Fix fact failures cause by ordering of collectors (#30777) 2017-09-28 10:36:22 -04:00
packaging Add 2.4.1 to packaging/release/vars/versions.yml 2017-09-27 20:50:47 -07:00
test Fix fact failures cause by ordering of collectors (#30777) 2017-09-28 10:36:22 -04:00
ticket_stubs
.coveragerc
.gitattributes
.gitignore updated plugin docs (#30490) 2017-09-22 23:19:50 -04:00
.gitmodules
.mailmap
.yamllint
ansible-core-sitemap.xml
CHANGELOG.md fixed wrong changelog entry 2017-09-27 11:49:39 -04:00
CODING_GUIDELINES.md
CONTRIBUTING.md
COPYING
docsite_requirements.txt
Makefile Fix make clean to remove test reports correctly 2017-09-18 16:49:16 -07:00
MANIFEST.in
MODULE_GUIDELINES.md Update link to MAINTAINERS.txt 2017-09-14 16:21:00 +02:00
README.md devel usage README update (#30369) 2017-09-14 10:48:58 -07:00
RELEASES.txt Use a more convenient and standard date format 2017-09-14 16:12:57 +02:00
requirements.txt
ROADMAP.rst
setup.py
shippable.yml Update Windows CI groups from 2 to 3. 2017-09-14 23:54:28 -07:00
tox.ini
VERSION Bump the versions now that devel is 2.5 2017-09-06 13:13:57 -07:00

PyPI version Build Status

Ansible

Ansible is a radically simple IT automation system. It handles configuration-management, application deployment, cloud provisioning, ad-hoc task-execution, and multinode orchestration - including trivializing things like zero downtime rolling updates with load balancers.

Read the documentation and more at https://ansible.com/

You can find installation instructions here for a variety of platforms. Most users should probably install a released version of Ansible from pip, a package manager or our release repository. Officially supported builds of Ansible are also available. Some power users run directly from the development branch - while significant efforts are made to ensure that devel is reasonably stable, you're more likely to encounter breaking changes when running Ansible this way.

Design Principles

  • Have a dead simple setup process and a minimal learning curve
  • Manage machines very quickly and in parallel
  • Avoid custom-agents and additional open ports, be agentless by leveraging the existing SSH daemon
  • Describe infrastructure in a language that is both machine and human friendly
  • Focus on security and easy auditability/review/rewriting of content
  • Manage new remote machines instantly, without bootstrapping any software
  • Allow module development in any dynamic language, not just Python
  • Be usable as non-root
  • Be the easiest IT automation system to use, ever.

Get Involved

  • Read Community Information for all kinds of ways to contribute to and interact with the project, including mailing list information and how to submit bug reports and code to Ansible.
  • All code submissions are done through pull requests. Take care to make sure no merge commits are in the submission, and use git rebase vs git merge for this reason. If submitting a large code change (other than modules), it's probably a good idea to join ansible-devel and talk about what you would like to do or add first and to avoid duplicate efforts. This not only helps everyone know what's going on, it also helps save time and effort if we decide some changes are needed.
  • Users list: ansible-project
  • Development list: ansible-devel
  • Announcement list: ansible-announce - read only
  • irc.freenode.net: #ansible

Branch Info

  • Releases are named after Led Zeppelin songs. (Releases prior to 2.0 were named after Van Halen songs.)
  • The devel branch corresponds to the release actively under development.
  • Various release-X.Y branches exist for previous releases.
  • We'd love to have your contributions, read Community Information for notes on how to get started.

Authors

Ansible was created by Michael DeHaan (michael.dehaan/gmail/com) and has contributions from over 1000 users (and growing). Thanks everyone!

Ansible is sponsored by Ansible, Inc

License

GNU General Public License v3.0

See COPYING to see the full text.