9687879840
* Replace InventoryFileCacheModule with a better developer-interface Use new interface for inventory plugins with backwards compatibility Auto-update the backing cache-plugin if the cache has changed after parsing the inventory plugin * Update CacheModules to use the config system and add a deprecation warning if they are being imported directly rather than using cache_loader * Fix foreman inventory caching * Add tests * Add integration test to check that fact caching works normally with cache plugins using ansible.constants and inventory caching provides a helpful error for non-compatible cache plugins * Add some developer documentation for inventory and cache plugins * Add user documentation for inventory caching * Add deprecation docs * Apply suggestions from docs review * Add changelog
188 lines
6.5 KiB
Python
188 lines
6.5 KiB
Python
# (c) 2012-2015, Michael DeHaan <michael.dehaan@gmail.com>
|
|
#
|
|
# This file is part of Ansible
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Make coding more python3-ish
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
from units.compat import unittest, mock
|
|
from ansible.errors import AnsibleError
|
|
from ansible.plugins.cache import FactCache, CachePluginAdjudicator
|
|
from ansible.plugins.cache.base import BaseCacheModule
|
|
from ansible.plugins.cache.memory import CacheModule as MemoryCache
|
|
from ansible.plugins.loader import cache_loader
|
|
|
|
HAVE_MEMCACHED = True
|
|
try:
|
|
import memcache
|
|
except ImportError:
|
|
HAVE_MEMCACHED = False
|
|
else:
|
|
# Use an else so that the only reason we skip this is for lack of
|
|
# memcached, not errors importing the plugin
|
|
from ansible.plugins.cache.memcached import CacheModule as MemcachedCache
|
|
|
|
HAVE_REDIS = True
|
|
try:
|
|
import redis
|
|
except ImportError:
|
|
HAVE_REDIS = False
|
|
else:
|
|
from ansible.plugins.cache.redis import CacheModule as RedisCache
|
|
|
|
import pytest
|
|
|
|
|
|
class TestCachePluginAdjudicator:
|
|
# memory plugin cache
|
|
cache = CachePluginAdjudicator()
|
|
cache['cache_key'] = {'key1': 'value1', 'key2': 'value2'}
|
|
cache['cache_key_2'] = {'key': 'value'}
|
|
|
|
def test___setitem__(self):
|
|
self.cache['new_cache_key'] = {'new_key1': ['new_value1', 'new_value2']}
|
|
assert self.cache['new_cache_key'] == {'new_key1': ['new_value1', 'new_value2']}
|
|
|
|
def test_inner___setitem__(self):
|
|
self.cache['new_cache_key'] = {'new_key1': ['new_value1', 'new_value2']}
|
|
self.cache['new_cache_key']['new_key1'][0] = 'updated_value1'
|
|
assert self.cache['new_cache_key'] == {'new_key1': ['updated_value1', 'new_value2']}
|
|
|
|
def test___contains__(self):
|
|
assert 'cache_key' in self.cache
|
|
assert 'not_cache_key' not in self.cache
|
|
|
|
def test_get(self):
|
|
assert self.cache.get('cache_key') == {'key1': 'value1', 'key2': 'value2'}
|
|
|
|
def test_get_with_default(self):
|
|
assert self.cache.get('foo', 'bar') == 'bar'
|
|
|
|
def test_get_without_default(self):
|
|
assert self.cache.get('foo') is None
|
|
|
|
def test___getitem__(self):
|
|
with pytest.raises(KeyError) as err:
|
|
self.cache['foo']
|
|
|
|
def test_pop_with_default(self):
|
|
assert self.cache.pop('foo', 'bar') == 'bar'
|
|
|
|
def test_pop_without_default(self):
|
|
with pytest.raises(KeyError) as err:
|
|
assert self.cache.pop('foo')
|
|
|
|
def test_pop(self):
|
|
v = self.cache.pop('cache_key_2')
|
|
assert v == {'key': 'value'}
|
|
assert 'cache_key_2' not in self.cache
|
|
|
|
def test_update(self):
|
|
self.cache.update({'cache_key': {'key2': 'updatedvalue'}})
|
|
assert self.cache['cache_key']['key2'] == 'updatedvalue'
|
|
|
|
|
|
class TestFactCache(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
with mock.patch('ansible.constants.CACHE_PLUGIN', 'memory'):
|
|
self.cache = FactCache()
|
|
|
|
def test_copy(self):
|
|
self.cache['avocado'] = 'fruit'
|
|
self.cache['daisy'] = 'flower'
|
|
a_copy = self.cache.copy()
|
|
self.assertEqual(type(a_copy), dict)
|
|
self.assertEqual(a_copy, dict(avocado='fruit', daisy='flower'))
|
|
|
|
def test_plugin_load_failure(self):
|
|
# See https://github.com/ansible/ansible/issues/18751
|
|
# Note no fact_connection config set, so this will fail
|
|
with mock.patch('ansible.constants.CACHE_PLUGIN', 'json'):
|
|
self.assertRaisesRegexp(AnsibleError,
|
|
"Unable to load the facts cache plugin.*json.*",
|
|
FactCache)
|
|
|
|
|
|
class TestAbstractClass(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
pass
|
|
|
|
def tearDown(self):
|
|
pass
|
|
|
|
def test_subclass_error(self):
|
|
class CacheModule1(BaseCacheModule):
|
|
pass
|
|
with self.assertRaises(TypeError):
|
|
CacheModule1() # pylint: disable=abstract-class-instantiated
|
|
|
|
class CacheModule2(BaseCacheModule):
|
|
def get(self, key):
|
|
super(CacheModule2, self).get(key)
|
|
|
|
with self.assertRaises(TypeError):
|
|
CacheModule2() # pylint: disable=abstract-class-instantiated
|
|
|
|
def test_subclass_success(self):
|
|
class CacheModule3(BaseCacheModule):
|
|
def get(self, key):
|
|
super(CacheModule3, self).get(key)
|
|
|
|
def set(self, key, value):
|
|
super(CacheModule3, self).set(key, value)
|
|
|
|
def keys(self):
|
|
super(CacheModule3, self).keys()
|
|
|
|
def contains(self, key):
|
|
super(CacheModule3, self).contains(key)
|
|
|
|
def delete(self, key):
|
|
super(CacheModule3, self).delete(key)
|
|
|
|
def flush(self):
|
|
super(CacheModule3, self).flush()
|
|
|
|
def copy(self):
|
|
super(CacheModule3, self).copy()
|
|
|
|
self.assertIsInstance(CacheModule3(), CacheModule3)
|
|
|
|
@unittest.skipUnless(HAVE_MEMCACHED, 'python-memcached module not installed')
|
|
def test_memcached_cachemodule(self):
|
|
self.assertIsInstance(MemcachedCache(), MemcachedCache)
|
|
|
|
@unittest.skipUnless(HAVE_MEMCACHED, 'python-memcached module not installed')
|
|
def test_memcached_cachemodule_with_loader(self):
|
|
self.assertIsInstance(cache_loader.get('memcached'), MemcachedCache)
|
|
|
|
def test_memory_cachemodule(self):
|
|
self.assertIsInstance(MemoryCache(), MemoryCache)
|
|
|
|
def test_memory_cachemodule_with_loader(self):
|
|
self.assertIsInstance(cache_loader.get('memory'), MemoryCache)
|
|
|
|
@unittest.skipUnless(HAVE_REDIS, 'Redis python module not installed')
|
|
def test_redis_cachemodule(self):
|
|
self.assertIsInstance(RedisCache(), RedisCache)
|
|
|
|
@unittest.skipUnless(HAVE_REDIS, 'Redis python module not installed')
|
|
def test_redis_cachemodule_with_loader(self):
|
|
# The _uri option is required for the redis plugin
|
|
self.assertIsInstance(cache_loader.get('redis', **{'_uri': '127.0.0.1:6379:1'}), RedisCache)
|