No description
Find a file
Dag Wieers 983cdd00bc Making unarchive idempotent (#3307)
* WIP: Making unarchive idempotent

Currently unarchive is not idempotent and has many rough edges and bugs.
The current release is a workable improvement on many fronts:

- zip support is now idempotent (but gtar lacks check-mode)
- New option `exclude` to exclude specific paths/files
- New option `keep_newer` to exclude newer files on target
- New option `extra_opts` to influence unzip/gtar (like synchronize module)

The following items are still ongoing:

- Implement CRC32 support for .zip files
- Re-implement the zip support using native zipfile module
- Re-implement the gtar support using native tarfile/gzip/bz2 modules (lzma external)
- Implement check-mode (works in gzip, but fails using gtar)
- Implement diff-mode (discuss an appropriate output model, like synchronize module)

The re-implementation of unzip/gtar support using native python modules will not only simplify the codebase, additional functionality can be implemented correctly and identically, which is currently not possible. (Other archives could be implemented using native modules equally, incl. options)

* Assorted fixes to zip support (during quality checks)

- Support both rw---- and rwx--- permstr
- Better file type support (more qa needed)
- Symlink support
- Include fix from #3229

* Implement zip diff-mode (itemized change) and avoid changes permissions every time (!)

This commit implements:
- rsync-compatible itemized-change output in diff-mode (using zip)
- no longer changing permissions unconditionally (when idempotent)

* Small fixes to itemized change output

* Fixes to user/group ownership changes

- The implementation of user/group ownership is a bit more complex for idempotency
- We report when a ZIP file incorrectly tags a directory as a file/link
- We only offer diff output when there is a change

* Fix the handling of includes and excludes for unzip

* Remove test output from output (confuses easily)

* Logic and performance improvements to ownership handling, and umask fix

* Handle special files (type '?')

* Make exceptions compatible with python 2.4

* Implement CRC32 support

* Revert some unintended/unknown changes ?

* Taking over maintenance as offered by current maintainer

* Fix support for white-spaces in filenames

* Remove/rename incorrect regex

* Ensure that fat executables end up with execute permission

* Remove check_result from output when unchanged

* When unarchiving as a user, or when owner/group/mode is supplied --diff is insufficient

Only way to be sure is to check request with what is on disk (as we do for zip).
Leave this up to set_fs_attributes_if_different() instead of inducing a (false) change

* By default, don't send confusing check_results in verbose output

This fixes #74.
2016-04-18 16:31:06 -04:00
.github Update the issue and pull-request templates in sync with ansible/ansible 2016-03-23 15:59:17 +01:00
cloud rebase for #2477, ready_for_review (#2581) 2016-04-16 21:50:53 +02:00
commands Added some documentation for the shell return values 2016-02-25 10:42:54 +01:00
database Give encoding examples (#3436) 2016-04-14 11:17:13 -04:00
files Making unarchive idempotent (#3307) 2016-04-18 16:31:06 -04:00
inventory Add missing GPLv3 License header 2015-07-03 22:57:53 -05:00
network ops_template.py: Taking care of the JSON src variable (#3313) 2016-04-16 22:04:37 +02:00
packaging Resolve idempotency issue with virtual apt package (#3449) 2016-04-18 11:14:57 -04:00
source_control make git updates respect depth (#3254) 2016-04-14 09:40:23 -07:00
system Fix mount's handling of passno 2016-04-12 16:42:55 -08:00
test/unit/cloud/openstack add some unit tests for the os_server module 2015-10-16 21:03:50 -04:00
utilities Allow async to not need an args file since new-style modules have args embedded 2016-04-01 19:50:58 -07:00
web_infrastructure Set the locales to avoid issue with screenscrapping 2016-04-05 10:24:43 -07:00
windows fix win_user type checking 2016-04-07 18:25:41 -07:00
.gitignore Add basic top level files. 2014-09-26 09:21:20 -04:00
.travis.yml Disable travis docs checks 2015-07-01 07:24:39 -07:00
__init__.py package files 2014-09-26 11:05:47 -04:00
CONTRIBUTING.md point to local issue temmplate 2016-02-18 09:28:47 -08:00
COPYING Add basic top level files. 2014-09-26 09:21:20 -04:00
README.md updated to keep same info as in extras repo 2015-03-10 10:35:29 -04:00
test-docs.sh Add testing of docs to the core repo 2015-06-29 12:42:50 -07:00
test-requirements.txt add some unit tests for the os_server module 2015-10-16 21:03:50 -04:00
VERSION Version bump for new beta 2.0.0-0.5.beta3 2015-11-13 16:46:32 -05:00

ansible-modules-core

This repo contains Ansible's most popular modules that are shipped with Ansible.

New module submissions for modules that do not yet exist should be submitted to ansible-modules-extras, rather than this repo.

Take care to submit tickets to the appropriate repo where modules are contained. The docs.ansible.com website indicates this at the bottom of each module documentation page.

Reporting bugs

Take care to submit tickets to the appropriate repo where modules are contained. The repo is mentioned at the bottom of module documentation page at docs.ansible.com.

Testing modules

Ansible module development guide contains the latest info about that.

License

As with Ansible, modules distributed with Ansible are GPLv3 licensed. User generated modules not part of this project can be of any license.

Installation

There should be no need to install this repo separately as it should be included in any Ansible install using the official documented methods.