103ede26df
* Add tests for `get_fqdn_and_port` method. Currently tests verify original behavior - returning default `ssh-keyscan` port Add test around `add_host_key` to verify underlying command arguments Add some new expectations for `get_fqdn_and_port` Test that non-standard port is passed to `ssh-keyscan` command * Ensure ssh hostkey checks respect server port ssh-keyscan will default to getting the host key for port 22. If the ssh service is running on a different port, ssh-keyscan will need to know this. Tidy up minor flake8 issues * Update known_hosts tests for port being None Ensure that git urls don't try and set port when a path is specified Update known_hosts tests to meet flake8 * Fix stdin swap context for test_known_hosts Move test_known_hosts from under basic, as it is its own library. Remove module_utils.known_hosts from pep8 legacy files list |
||
|---|---|---|
| .. | ||
| current-ignore.txt | ||
| legacy-files.txt | ||
| legacy-ignore.txt | ||
| README.md | ||
| skip.txt | ||
PEP 8
PEP 8 style guidelines are enforced by pep8 on all python files in the repository by default.
Current Rule Set
By default all files are tested using the current rule set.
All pep8 tests are executed, except those listed in the current ignore list.
Legacy Rule Set
Files which are listed in the legacy file list are tested using the legacy rule set.
All pep8 tests are executed, except those listed in the current ignore list or
legacy ignore list.
Files listed in the legacy file list which pass the current rule set will result in an error. This is intended to prevent regressions on style guidelines for files which pass the more stringent current rule set.
Skipping Tests
Files listed in the skip list are not tested by pep8.
Removed Files
Files which have been removed from the repository must be removed from the legacy file list and the skip list.
Running Locally
The pep8 check can be run locally with:
./test/runner/ansible-test sanity --test pep8 [file-or-directory-path-to-check] ...