ansible/test/units/modules/network/nxos/fixtures
Chris Van Heuveln 0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
2019-06-28 16:18:46 +05:30
..
_nxos_switchport Deprecate nxos_switchport and Add nxos_l2_interface DI module (#33813) 2018-01-05 07:44:02 +00:00
nxos_acl
nxos_acl_interface Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_bfd_global nxos_bfd_global / NxosCmdRef initial commit (#56317) 2019-06-06 15:52:55 +05:30
nxos_bgp nxos_bgp_neighbor: Add bfd support (#56932) 2019-06-19 21:23:00 +05:30
nxos_command
nxos_config
nxos_evpn_global
nxos_feature
nxos_interface Fix nxos_interface multiple issues (#36827) 2018-03-01 10:56:16 +05:30
nxos_interface_ospf nxos_interface_ospf: Add bfd support (#56807) 2019-06-07 09:58:29 +05:30
nxos_l3_interface Add support for multiple IPv6 addresses in nxos_l3_interface module (#50892) 2019-03-27 10:52:42 -04:00
nxos_nxapi
nxos_pim nxos_pim: Add bfd support (#56908) 2019-06-19 21:22:03 +05:30
nxos_pim_interface
nxos_pim_rp_address
nxos_vlan nxos_vlan: fix broken purge behavior (issue #57101) (#57229) 2019-06-04 09:14:09 +05:30
nxos_vpc nxos_vpc: pkl_vrf fixes for #57069 (#57370) 2019-06-28 16:18:46 +05:30
nxos_vpc_interface
nxos_vrf Convert nxos_vrf to DI module (#34274) 2018-01-08 10:10:34 +05:30
nxos_vxlan_vtep
nxos_vxlan_vtep_vni
_nxos_ip_interface.cfg Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 2018-05-30 13:03:20 -04:00
nxos_evpn_vni_config.cfg
nxos_overlay_global_config.cfg
nxos_static_route.cfg
nxos_system_config.cfg