ansible/test/units
David Shrewsbury ff47d3f766
Make sure collection is a list if a str is given (#69081)
* Make sure collection is a list if a str is given

* Call field validation early on collections

Because we are doing work on modifying the collections value before
it is actually validated, we can validate it ourselves early to make
sure the user supplies either a string or list. Dicts are not valid.

The new validation allows us to simplify the _ensure_default_collection()
function. And since the field is now static, we no longer need to specify
a default for it, which also allows us to simplify the function. Since
the default is now removed, we can also remove the sanity/ignore.txt entry
for collectionsearch.py.

New unit tests are added (and the existing one modified) that allow us to
make sure that we throw a parser error if a user specifies something other
than a string or list for the collections value everywhere it can be specified.

* Revert removing the collection default

The default is actually used, so restore it.

* Fix unit tests in test_helpers.py affected by early collection validation
2020-04-28 10:47:11 -05:00
..
cli Use Templar for galaxy skeletons (#69106) 2020-04-23 10:36:14 -05:00
compat
config Fix inline vaults for plugins in ensure_type (#67492) 2020-02-25 10:42:31 -05:00
errors Remove empty overridden unittest.setUp and unittest.tearDown methods. 2019-11-05 09:12:11 -08:00
executor Try to load action plugin from the same collection as the module (#66701) 2020-01-31 12:49:37 -05:00
galaxy ansible-galaxy - Fix tar path traversal issue during install - CVE-2020-10691 (#68596) 2020-04-01 06:39:02 +10:00
inventory Clean up unit tests to assist with migration. (#67875) 2020-02-28 20:29:41 -08:00
inventory_test_data/group_vars
mock Replace TestCase.assertEquals with TestCase.assertEqual. 2019-11-11 10:24:21 -08:00
module_utils Expose to_<str> as a public function (#68965) 2020-04-17 07:54:00 +10:00
modules Remove unused unit test files. 2020-03-23 11:14:21 -05:00
parsing Replace TestCase.assertEquals with TestCase.assertEqual. 2019-11-11 10:24:21 -08:00
playbook Make sure collection is a list if a str is given (#69081) 2020-04-28 10:47:11 -05:00
plugins windows - fix up env var quoting for unicode single quotes (#68968) 2020-04-16 20:24:23 +10:00
regex
template Do not treat AnsibleUndefined as being unsafe (#65202) 2019-11-25 15:06:29 +01:00
utils Fix colorization to not extend across newline boundary (#68517) 2020-03-27 17:10:38 -07:00
vars Remove empty setUp/tearDown/tearDownClass methods in test classes. 2019-11-06 08:14:29 -08:00
__init__.py
requirements.txt Remove unnecessary unit test requirements. 2020-03-23 11:14:21 -05:00
test_constants.py
test_context.py Unit tests: remove unused imports (#59740) 2019-07-29 22:10:13 +02:00