bb50fc3889
* Updates aci.py with the ability to add ACI objects to any depth Changes start at line 411 (construct_deep_url() and supporting functions). One minor change to line 633 (the original construct_url()) to provide for testability: ...join(sorted(self.child_classes)) vs ...join(self.child_classes) I am also attaching two test files. One characterizing the existing construct_url() and the matching test set for construct_deep_url() to support my efforts and proof of parity * Two PyTest files to support construct_deep_url These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function * Correcting previous upload to incorrect folder These two files provide testing parity, one characterizing the original construct_url() function and the other proofing construct_deep_url(). The ...deep_url.py test file goes five layers deep to provide better validation for the function * Deleting for file name change per Matt Clay * Deleting for file name change per Matt Clay * Correcting file names per Matt Clay @mattclay Thanks again for your continued guidance and patience. Please cancel the previous (incorrect) request * Wrong location for test file * Wrong location for test file * First attempt to comply with suggestions lib/ansible/module_utils/network/aci/aci.py:517:0: SyntaxWarning: "is not" with a literal. Did you mean "!="? lib/ansible/module_utils/network/aci/aci.py:534:0: SyntaxWarning: "is not" with a literal. Did you mean "!="? lib/ansible/module_utils/network/aci/aci.py:558:161: E501 line too long (210 > 160 characters) * First attempt to comply with suggestions test/units/module_utils/network/aci/test_aci_construct_url.py:1:14: SyntaxError: import pytest test/units/module_utils/network/aci/test_aci_deep_url.py:1:14: SyntaxError: import pytest test/units/module_utils/network/aci/test_aci_construct_url.py:0:0: use "\n" for line endings instead of "\r\n" test/units/module_utils/network/aci/test_aci_deep_url.py:0:0: use "\n" for line endings instead of "\r\n" Shortened test function names (less descriptive) * Second attempt to comply with suggestions * Second attempt to comply with suggestions * Third attempt to comply with suggestions * Third attempt to comply with suggestions * Pro Tip: Convert from 'CRLF' to 'LF' in VSCode It's on the status bar to the right * Added setup() support for tests * Continued corrections to support testing * Added two mocks to support testing I could not find where to place fakes/mocks, so please let me know if the current location is incorrect * Adding tmpdir property to mock_basic.py * Added last blank line to mock_basic.py To pass sanity test * Attempt to correct setup() issues * Attempt to correct setup() issues * Attempt to correct setup() issues * Attempt to correct setup() issues * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py * Withdrawing pending injectability tweak to aci.py |
||
|---|---|---|
| .. | ||
| ansible | ||