Toshio Kuratomi bd072fe83a Make the timeout decorator raise an exception out of the function's scope (#49921) ... * Revert "allow caller to deal with timeout (#49449)" This reverts commit 63279823a7. Flawed on many levels * Adds poor API to a public function * Papers over the fact that the public function is doing something bad by catching exceptions it cannot handle in the first place * Papers over the real cause of the issue which is a bug in the timeout decorator * Doesn't reraise properly * Catches the wrong exception Fixes #49824 Fixes #49817 * Make the timeout decorator properly raise an exception outside of the function's scope signal handlers which raise exceptions will never work well because the exception can be raised anywhere in the called code. This leads to exception race conditions where the exceptions could end up being hanlded by unintended pieces of the called code. The timeout decorator was using just that idiom. It was especially bad because the decorator syntactically occurs outside of the called code but because of the signal handler, the exception was being raised inside of the called code. This change uses a thread instead of a signal to manage the timeout in parallel to the execution of the decorated function. Since raising of the exception happens inside of the decorator, now, instead of inside of a signal handler, the timeout exception is raised from outside of the called code as expected which makes reasoning about where exceptions are to be expected intuitive again. Fixes #43884 * Add a common case test. Adding an integration test driven from our unittests. Most of the time we'll timeout in run_command which is running things in a subprocess. Create a test for that specific case in case anything funky comes up between threading and execve. * Don't use OSError-based TimeoutError as a base class Unlike most standard exceptions, OSError has a specific parameter list with specific meanings. Instead follow the example of other stdlib functions, concurrent.futures and multiprocessing and define a separate TimeoutException. * Add comment and docstring to point out that this is not hte Python3 TimeoutError		2018-12-18 18:01:46 -08:00
..
cache
integration	added handlers_from (#49220)	2018-12-18 11:28:24 -05:00
legacy	Update bare exceptions to specify Exception.	2018-12-16 15:03:19 -08:00
results
runner	Add OverlayFS work-around for CloudStack tests.	2018-12-17 15:45:31 -08:00
sanity	Convert to reduced list of known types (#50010)	2018-12-19 07:25:30 +10:00
units	Make the timeout decorator raise an exception out of the function's scope (#49921)	2018-12-18 18:01:46 -08:00
utils	Fix passing of env vars to Shippable.	2018-11-14 10:50:31 -08:00