c548ab0f18
This patch is primarily a refactor to make the validate-modules arg-spec no longer generate a traceback. It additionally includes removal of deprecated code in the virtual server module.
319 lines
9.8 KiB
Python
319 lines
9.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
#
|
|
# Copyright (c) 2017 F5 Networks Inc.
|
|
# GNU General Public License v3.0 (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import os
|
|
import json
|
|
import sys
|
|
|
|
from nose.plugins.skip import SkipTest
|
|
if sys.version_info < (2, 7):
|
|
raise SkipTest("F5 Ansible modules require Python >= 2.7")
|
|
|
|
from ansible.compat.tests import unittest
|
|
from ansible.compat.tests.mock import Mock
|
|
from ansible.compat.tests.mock import patch
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
|
|
try:
|
|
from library.bigip_vlan import ApiParameters
|
|
from library.bigip_vlan import ModuleParameters
|
|
from library.bigip_vlan import ModuleManager
|
|
from library.bigip_vlan import ArgumentSpec
|
|
from library.module_utils.network.f5.common import F5ModuleError
|
|
from library.module_utils.network.f5.common import iControlUnexpectedHTTPError
|
|
from test.unit.modules.utils import set_module_args
|
|
except ImportError:
|
|
try:
|
|
from ansible.modules.network.f5.bigip_vlan import ApiParameters
|
|
from ansible.modules.network.f5.bigip_vlan import ModuleParameters
|
|
from ansible.modules.network.f5.bigip_vlan import ModuleManager
|
|
from ansible.modules.network.f5.bigip_vlan import ArgumentSpec
|
|
from ansible.module_utils.network.f5.common import F5ModuleError
|
|
from ansible.module_utils.network.f5.common import iControlUnexpectedHTTPError
|
|
from units.modules.utils import set_module_args
|
|
except ImportError:
|
|
raise SkipTest("F5 Ansible modules require the f5-sdk Python library")
|
|
|
|
fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
|
|
fixture_data = {}
|
|
|
|
|
|
def load_fixture(name):
|
|
path = os.path.join(fixture_path, name)
|
|
|
|
if path in fixture_data:
|
|
return fixture_data[path]
|
|
|
|
with open(path) as f:
|
|
data = f.read()
|
|
|
|
try:
|
|
data = json.loads(data)
|
|
except Exception:
|
|
pass
|
|
|
|
fixture_data[path] = data
|
|
return data
|
|
|
|
|
|
class BigIpObj(object):
|
|
def __init__(self, **kwargs):
|
|
self.__dict__.update(kwargs)
|
|
|
|
|
|
class TestParameters(unittest.TestCase):
|
|
def test_module_parameters(self):
|
|
args = dict(
|
|
name='somevlan',
|
|
tag=213,
|
|
description='fakevlan',
|
|
untagged_interfaces=['1.1'],
|
|
)
|
|
p = ModuleParameters(params=args)
|
|
|
|
assert p.name == 'somevlan'
|
|
assert p.tag == 213
|
|
assert p.description == 'fakevlan'
|
|
assert p.untagged_interfaces == ['1.1']
|
|
|
|
def test_api_parameters(self):
|
|
args = dict(
|
|
name='somevlan',
|
|
description='fakevlan',
|
|
tag=213
|
|
)
|
|
|
|
p = ApiParameters(params=args)
|
|
|
|
assert p.name == 'somevlan'
|
|
assert p.tag == 213
|
|
assert p.description == 'fakevlan'
|
|
|
|
|
|
class TestManager(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
self.spec = ArgumentSpec()
|
|
|
|
def test_create_vlan(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
description='fakevlan',
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common'
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
mm.create_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=False)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['description'] == 'fakevlan'
|
|
|
|
def test_create_vlan_tagged_interface(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
tagged_interface=['2.1'],
|
|
tag=213,
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common'
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
mm.create_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=False)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['tagged_interfaces'] == ['2.1']
|
|
assert results['tag'] == 213
|
|
|
|
def test_create_vlan_untagged_interface(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
untagged_interface=['2.1'],
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common'
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
mm.create_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=False)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['untagged_interfaces'] == ['2.1']
|
|
|
|
def test_create_vlan_tagged_interfaces(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
tagged_interface=['2.1', '1.1'],
|
|
tag=213,
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common'
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
mm.create_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=False)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['tagged_interfaces'] == ['1.1', '2.1']
|
|
assert results['tag'] == 213
|
|
|
|
def test_create_vlan_untagged_interfaces(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
untagged_interface=['2.1', '1.1'],
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common',
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
mm.create_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=False)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['untagged_interfaces'] == ['1.1', '2.1']
|
|
|
|
def test_update_vlan_untag_interface(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
untagged_interface=['2.1'],
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common',
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
|
|
current = ApiParameters(params=load_fixture('load_vlan.json'))
|
|
interfaces = load_fixture('load_vlan_interfaces.json')
|
|
current.update({'interfaces': interfaces})
|
|
|
|
mm.update_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=True)
|
|
mm.read_current_from_device = Mock(return_value=current)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['untagged_interfaces'] == ['2.1']
|
|
|
|
def test_update_vlan_tag_interface(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
tagged_interface=['2.1'],
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common',
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
|
|
current = ApiParameters(params=load_fixture('load_vlan.json'))
|
|
|
|
mm.update_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=True)
|
|
mm.read_current_from_device = Mock(return_value=current)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['tagged_interfaces'] == ['2.1']
|
|
|
|
def test_update_vlan_description(self, *args):
|
|
set_module_args(dict(
|
|
name='somevlan',
|
|
description='changed_that',
|
|
server='localhost',
|
|
password='password',
|
|
user='admin',
|
|
partition='Common',
|
|
))
|
|
|
|
module = AnsibleModule(
|
|
argument_spec=self.spec.argument_spec,
|
|
supports_check_mode=self.spec.supports_check_mode
|
|
)
|
|
|
|
# Override methods to force specific logic in the module to happen
|
|
mm = ModuleManager(module=module)
|
|
|
|
current = ApiParameters(params=load_fixture('update_vlan_description.json'))
|
|
|
|
mm.update_on_device = Mock(return_value=True)
|
|
mm.exists = Mock(return_value=True)
|
|
mm.read_current_from_device = Mock(return_value=current)
|
|
|
|
results = mm.exec_module()
|
|
|
|
assert results['changed'] is True
|
|
assert results['description'] == 'changed_that'
|