ceb474bb9e
Batch of docs backports: * docs: Clarify include_task v import_tasks with conditionals (#43856) (cherry picked from commit6be42a2a0e) * Add single quotes around package name (#45152) (cherry picked from commit0d81386144) * prefer ansible_facts namespace and dict notation (#44980) (cherry picked from commit44510448b0) * fix cherrypick conflict - scenario_guides * Update implicit_localhost.rst (#45455) (cherry picked from commitf68cd1acc6) * updated fbsd install instructions (#45309) (cherry picked from commite9c2695ce7) * Change "Defaulting Undefined Variables" (#41379) (cherry picked from commite35c4be1c1) * adds license details to dev guide pages (#45574) (cherry picked from commit6e68d77f6d) * FAQ: fix a typo, add link to 'vars' lookup (#42412) (cherry picked from commit95649dc793) * Fix link and toctree (#45595) (cherry picked from commit6999bf318f) * Improve the local toctree (and title) (#45590) (cherry picked from commitafea00fa9f) * Add undocumented configuration parameter and explain in porting guide (#36059) (cherry picked from commita892a6ef03) * Simplify PPA installation for Ubuntu (#45690) (cherry picked from commit78e9f452a5) * adding git+ssh uri scheme (#36025) (cherry picked from commit84a4257774) * Add workaround for non-standard kerberos environments (#41465) (cherry picked from commit4e532e0ad9) * Restore license agreement (#45809) (cherry picked from commitf430f60541) * partial cherry-pick - lenovo doc update PR 45483
31 lines
871 B
ReStructuredText
31 lines
871 B
ReStructuredText
:orphan:
|
|
|
|
Sanity Tests » no-wildcard-import
|
|
=================================
|
|
|
|
Using :code:`import *` is a bad habit which pollutes your namespace, hinders
|
|
debugging, and interferes with static analysis of code. For those reasons, we
|
|
do want to limit the use of :code:`import *` in the ansible code. Change our
|
|
code to import the specific names that you need instead.
|
|
|
|
Examples of unfixed code:
|
|
|
|
.. code-block:: python
|
|
|
|
from ansible.module_utils.six import *
|
|
if isinstance(variable, string_types):
|
|
do_something(variable)
|
|
|
|
from ansible.module_utils.basic import *
|
|
module = AnsibleModule()
|
|
|
|
Examples of fixed code:
|
|
|
|
.. code-block:: python
|
|
|
|
from ansible.module_utils import six
|
|
if isinstance(variable, six.string_types):
|
|
do_something(variable)
|
|
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
module = AnsibleModule()
|