891f4f3b2d
* Enhance no-dict-* code-smell tests. * Enhance no-basestring code-smell test. * Enhance no-get-exception code-smell test. * Enhance empty-init code-smell test. * Enhance required-and-default-attribute test. * Remove unused code-smell test.
28 lines
683 B
Python
Executable file
28 lines
683 B
Python
Executable file
#!/usr/bin/env python
|
|
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
|
|
def main():
|
|
skip = set([
|
|
'test/sanity/code-smell/%s' % os.path.basename(__file__),
|
|
'lib/ansible/module_utils/six/__init__.py',
|
|
])
|
|
|
|
for path in sys.argv[1:]:
|
|
if path in skip:
|
|
continue
|
|
|
|
with open(path, 'r') as path_fd:
|
|
for line, text in enumerate(path_fd.readlines()):
|
|
match = re.search(r'\.(iterkeys)', text)
|
|
|
|
if match:
|
|
print('%s:%d:%d: use `dict.keys` or `for key in dict:` instead of `dict.iterkeys`' % (
|
|
path, line + 1, match.start(1) + 1))
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|