4a48fdba1d
Update blacklist for get_exception, boilerplate, and no-wildcard. f5, lenovo, and junos have updated their code.
94 lines
4.2 KiB
Bash
Executable file
94 lines
4.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
metaclass1=$(find ./bin -type f -exec grep -HL '__metaclass__ = type' '{}' '+')
|
|
future1=$(find ./bin -type f -exec grep -HL 'from __future__ import (absolute_import, division, print_function)' '{}' '+')
|
|
|
|
# We eventually want to remove the module_utils pruning from metaclass2 and future2
|
|
metaclass2=$(find ./lib/ansible -path ./lib/ansible/modules -prune \
|
|
-o -path ./lib/ansible/module_utils -prune \
|
|
-o -path ./lib/ansible/module_utils/six/_six.py -prune \
|
|
-o -path ./lib/ansible/compat/selectors/_selectors2.py -prune \
|
|
-o -path ./lib/ansible/utils/module_docs_fragments -prune \
|
|
-o -name '*.py' -type f -size +0c -exec grep -HL '__metaclass__ = type' '{}' '+')
|
|
|
|
future2=$(find ./lib/ansible -path ./lib/ansible/modules -prune \
|
|
-o -path ./lib/ansible/module_utils -prune \
|
|
-o -path ./lib/ansible/module_utils/six/_six.py -prune \
|
|
-o -path ./lib/ansible/compat/selectors/_selectors2.py -prune \
|
|
-o -path ./lib/ansible/utils/module_docs_fragments -prune \
|
|
-o -name '*.py' -type f -size +0c -exec grep -HL 'from __future__ import (absolute_import, division, print_function)' '{}' '+')
|
|
|
|
# Eventually we want metaclass3 and future3 to get down to 0
|
|
metaclass3=$(find ./lib/ansible/modules -path ./lib/ansible/modules/windows -prune \
|
|
-o -path ./lib/ansible/modules/cloud/ovirt -prune \
|
|
-o -path ./lib/ansible/modules/cloud/cloudstack -prune \
|
|
-o -path ./lib/ansible/modules/cloud/amazon -prune \
|
|
-o -path ./lib/ansible/modules/network/aos -prune \
|
|
-o -path ./lib/ansible/modules/network/avi -prune \
|
|
-o -path ./lib/ansible/modules/network/cloudengine -prune \
|
|
-o -path ./lib/ansible/modules/network/eos -prune \
|
|
-o -path ./lib/ansible/modules/network/ios -prune \
|
|
-o -path ./lib/ansible/modules/network/netvisor -prune \
|
|
-o -path ./lib/ansible/modules/network/nxos -prune \
|
|
-o -path ./lib/ansible/modules/network/panos -prune \
|
|
-o -path ./lib/ansible/modules/network/vyos -prune \
|
|
-o -name '*.py' -type f -size +0c -exec grep -HL '__metaclass__ = type' '{}' '+')
|
|
|
|
future3=$(find ./lib/ansible/modules -path ./lib/ansible/modules/windows -prune \
|
|
-o -path ./lib/ansible/modules/cloud/ovirt -prune \
|
|
-o -path ./lib/ansible/modules/cloud/cloudstack -prune \
|
|
-o -path ./lib/ansible/modules/cloud/amazon -prune \
|
|
-o -path ./lib/ansible/modules/network/aos -prune \
|
|
-o -path ./lib/ansible/modules/network/avi -prune \
|
|
-o -path ./lib/ansible/modules/network/cloudengine -prune \
|
|
-o -path ./lib/ansible/modules/network/eos -prune \
|
|
-o -path ./lib/ansible/modules/network/ios -prune \
|
|
-o -path ./lib/ansible/modules/network/netvisor -prune \
|
|
-o -path ./lib/ansible/modules/network/nxos -prune \
|
|
-o -path ./lib/ansible/modules/network/panos -prune \
|
|
-o -path ./lib/ansible/modules/network/vyos -prune \
|
|
-o -name '*.py' -type f -size +0c -exec egrep -HL 'from __future__ import (?absolute_import, division, print_function)?' '{}' '+')
|
|
|
|
###
|
|
### Important: If you're looking for a list of files to cleanup for boilerplate
|
|
### Look at this wikipage instead: https://github.com/ansible/community/wiki/Testing:-boilerplate,-wildcard-imports,-and-get_exception
|
|
###
|
|
|
|
### TODO:
|
|
### - module_utils <=== these are important but not well organized so we'd
|
|
### have to construct the test file by file
|
|
### - contrib/ <=== Not a priority as these will move to inventory plugins over time
|
|
|
|
|
|
if test -n "$metaclass1" -o -n "$metaclass2" -o -n "$metaclass3" ; then
|
|
printf "\n== Missing __metaclass__ = type ==\n"
|
|
fi
|
|
|
|
if test -n "$metaclass1" ; then
|
|
printf "%s\n" "$metaclass1"
|
|
fi
|
|
if test -n "$metaclass2" ; then
|
|
printf "%s\n" "$metaclass2"
|
|
fi
|
|
if test -n "$metaclass3" ; then
|
|
printf "%s\n" "$metaclass3"
|
|
fi
|
|
|
|
if test -n "$future1" -o -n "$future2" -o -n "$future3" ; then
|
|
printf "\n== Missing from __future__ import (absolute_import, division, print_function) ==\n"
|
|
fi
|
|
|
|
if test -n "$future1" ; then
|
|
printf "%s\n" "$future1"
|
|
fi
|
|
if test -n "$future2" ; then
|
|
printf "%s\n" "$future2"
|
|
fi
|
|
if test -n "$future3" ; then
|
|
printf "%s\n" "$future3"
|
|
fi
|
|
|
|
if test -n "$future1$future2$future3$metaclass1$metaclass2$metaclass3" ; then
|
|
exit 2
|
|
fi
|
|
exit 0
|