ansible/cloud
Andrew Pashkin e96549c95d Harden matching running containers by "command" in the Docker module
Before this patch:

  - Command was matched if 'Command' field of docker-py
    representation of Docker container ends with 'command' passed
    to Ansible docker module by user.
  - That can give false positives and false negatives.
  - For example:
      a) If 'command' was set up with more than one spaces,
         like 'command=sleep  123', it would be never matched again
         with a container(s) launched by this task.
         Because after launching, command would be normalized and
         appear, in docker-py API call, just as 'sleep 123' - with one
         space. This is false negative case.
      b) If 'entrypoint + command = command', for example
         'sleep + 123 = sleep 123', module would give false positive
         match.

This patch fixes it, by making matching more explicit - against
'Config'->Cmd' field of 'docker inspect' output, provided by docker-py
API and with proper normalization of user input by splitting it to
tokens with 'shlex.split()'.
2015-10-02 12:30:03 +03:00
..
amazon added version_added 2015-10-01 00:13:58 -04:00
azure ensure password or ssh cert specified 2015-07-09 13:33:46 -04:00
digital_ocean Updating cloud modules with proper github author information 2015-06-15 14:41:22 -04:00
docker Harden matching running containers by "command" in the Docker module 2015-10-02 12:30:03 +03:00
google Delete dead and broken code 2015-08-24 20:06:53 +02:00
linode Updating cloud modules with proper github author information 2015-06-15 14:41:22 -04:00
openstack Merge pull request #250 from saito-hideki/bug/249 2015-09-17 11:25:35 -04:00
rackspace Merge pull request #1002 from vmihailenco/fix/rx-isdir-path 2015-10-01 10:59:43 -05:00
vmware Merge pull request #1757 from gutoandreollo/devel 2015-09-14 15:08:47 -04:00
__init__.py package files 2014-09-26 11:05:47 -04:00