ansible/test/units/modules/network
Chris Van Heuveln 0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
2019-06-28 16:18:46 +05:30
..
aireos Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
aruba Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
asa ASA network/service object-group module (#52925) 2019-04-03 23:22:45 +05:30
basics
checkpoint Add checkpoint_session module (#50930) 2019-01-16 13:19:36 +01:00
cli Add backup parameter to cli_config (#50206) 2018-12-21 09:55:14 -05:00
cloudvision Ensure that current uses of BaseException are required 2018-12-16 15:03:19 -08:00
cnos The module fails on switchport. Check added to fix. (#54970) 2019-04-08 10:41:36 +05:30
cumulus
dellos6 Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
dellos9 Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
dellos10 Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
edgeos Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
edgeswitch new network module: edgeswitch_vlan (#48041) 2018-12-17 11:30:17 +05:30
enos Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
eos New module for BGP configuration management in Arista EOS (#52722) 2019-03-12 17:31:58 +05:30
exos Exos httpapi (#54405) 2019-03-27 14:44:04 +01:00
f5 adds initial_hotfix parameter to vcmp guest (#58180) 2019-06-25 15:26:09 +02:00
fortimanager FortiManager Plugin Module Conversion: fmgr_ha (#52768) 2019-03-07 12:31:17 +05:30
frr frr: New module for BGP configuration management (#51281) 2019-03-04 15:02:56 +05:30
ftd FTD configuration module: fix a bug with response parsing (#57480) 2019-06-10 18:30:35 +05:30
ingate modules: network: ingate: Add module ig_store_edit (#47675) 2019-01-17 23:05:45 -05:00
ios Revert nxos, ios, iosxr return_timestamps (#56206) 2019-05-08 20:49:29 +05:30
iosxr Revert nxos, ios, iosxr return_timestamps (#56206) 2019-05-08 20:49:29 +05:30
ironware Update slxos_vlan for new SLX-OS versions, linting fixes (#52956) 2019-03-15 08:55:50 +00:00
itential itential iap_start_workflow module (#51238) 2019-03-07 13:23:40 -05:00
junos Add platform facts in network facts modules (#51434) 2019-03-11 10:56:39 +05:30
netact Move unit test compat code out of lib/ansible/. (#46996) 2018-10-12 20:01:14 -07:00
netscaler Move unit test compat code out of lib/ansible/. (#46996) 2018-10-12 20:01:14 -07:00
netvisor Pluribus Networks ipv6security raguard module with UT (#57031) 2019-06-24 16:29:41 +05:30
nos Update slxos_vlan for new SLX-OS versions, linting fixes (#52956) 2019-03-15 08:55:50 +00:00
nso NSO - added validate_certs parameter to allow for ignoring of SSL certificates (#51981) 2019-02-25 14:17:56 +00:00
nuage Replace nose with pytest 2018-11-26 13:41:57 -08:00
nxos nxos_vpc: pkl_vrf fixes for #57069 (#57370) 2019-06-28 16:18:46 +05:30
onyx Adding New Model onyx_qos for Configuring QoS on Onyx Switches (#55127) 2019-05-17 14:20:56 -04:00
opx opx_cps_changes (#51952) 2019-03-07 03:41:36 -05:00
ovs Fix ovsdb module not being idempotent (#57735) 2019-06-26 10:48:46 -04:00
radware Changing the license to Apache 2 2019-05-20 10:14:32 -07:00
routeros Update bare exceptions to specify Exception. 2018-12-16 15:03:19 -08:00
slxos Update slxos_vlan for new SLX-OS versions, linting fixes (#52956) 2019-03-15 08:55:50 +00:00
voss Update slxos_vlan for new SLX-OS versions, linting fixes (#52956) 2019-03-15 08:55:50 +00:00
vyos Add platform facts in network facts modules (#51434) 2019-03-11 10:56:39 +05:30
__init__.py