f506fd4730
* Start adding ansible-galaxy collection list options * Working list all collections and list a specific collection * Nuke debugging cruft * Use to_text to get a string of the FQCN for sorting * Improve collection output formatting - add header - display collection name and version in separate columns - width of columns is dynamic based on collection name and version length * Make role list output match collection output list - add header - add columns for role name and version - make column width dynamic based on name and version length * remove debug statemnt and extra header * Revert "Make role list output match collection output list" This reverts commit a0b3db47bb3b198aafd34c1f1be5b6561af2f928. * Add validate_collection_path function Utility function for ensuring a collection target ends with 'ansible_collection' * Use validate_collection_path * Do not warn if a specific collection in found in any search path * Fix extraneous warning and remove duplicate code Do not warn when listing a specific collection and it does not exist in other collection paths. Restructure the code that loops through collection paths to remove duplicate conditional code. * Indicate role path was found * Use new function name * WIP Save Point * Use separate functions for role and collection list * Wrap error message There may be a better way to do this besides hard coding a line break, but this does make the message a lot more readable. * Add validate_collection_path function (#66441) * Add validate_collection_path function Utility function for ensuring a collection target ends with 'ansible_collection' * Fix bad syntax * Correct docstring * Bikeshed the names * Properly list a single role * Simplify _display_warnings() Only display warnings. Move exception raise back to each caller. * Move private methods to private functions They don't need self, so it makes sense to have them as functions Get rid of _display_warnings() function since it doesn't do anything worthy of an independent function. * Add integration tests for ansible-galaxy collection list * Fix docs sanity test * Fix bug where ansible_collections dir does not exist The path may exist, but if there is no ansible_collections dir inside that path, an exception was raised in find_existing_collections(). Add integration test for this scenario * Put execute_list() method back * Add some informational messages for debugging * Add unit tests Units tests for the various private methods in support of collection list * Start adding unit tests for test_execute_list * Display collection path when listing specific collection * Add unit tests for listing all collections and specific collection - Create fixture for creating test objects - Add function for controlling os.path.isdir results * Set defaults for minimum collection widths Ensure that collections with small FQCNs display correctly. Add unit tests * Split up unit tests and fix fixtures Add more fixtures for mocking objects during the specific collection tests * Change help message for -p in list subcommand Give accurate description of what it actually does rather than trying to use language shared between sub commands. * Disable colorized output in unit test * Add docs for collection list * Fix integration test on macOS The temp file path is really long on macOS, so the warning message gets wrapped across multiple lines. That make seth grep fail. Switch to matching on a smaller part of the warning. * Recreate common path options for collections Improve help about what the '-p' option does and how it works. * Remove unnecessary elif after continue statements * Account for duplicate paths in collections_searh_paths If someone specifies the same path via '-p' that is the COLLECTIONS_PATHS, do not list the collections twice. * Docs updates
296 lines
9.8 KiB
Bash
Executable file
296 lines
9.8 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
set -eux -o pipefail
|
|
|
|
ansible-playbook setup.yml "$@"
|
|
|
|
trap 'ansible-playbook ${ANSIBLE_PLAYBOOK_DIR}/cleanup.yml' EXIT
|
|
|
|
# Very simple version test
|
|
ansible-galaxy --version
|
|
|
|
# Need a relative custom roles path for testing various scenarios of -p
|
|
galaxy_relative_rolespath="my/custom/roles/path"
|
|
|
|
# Prep the local git repo with a role and make a tar archive so we can test
|
|
# different things
|
|
galaxy_local_test_role="test-role"
|
|
galaxy_local_test_role_dir=$(mktemp -d)
|
|
galaxy_local_test_role_git_repo="${galaxy_local_test_role_dir}/${galaxy_local_test_role}"
|
|
galaxy_local_test_role_tar="${galaxy_local_test_role_dir}/${galaxy_local_test_role}.tar"
|
|
pushd "${galaxy_local_test_role_dir}"
|
|
ansible-galaxy init "${galaxy_local_test_role}"
|
|
pushd "${galaxy_local_test_role}"
|
|
git init .
|
|
|
|
# Prep git, becuase it doesn't work inside a docker container without it
|
|
git config user.email "tester@ansible.com"
|
|
git config user.name "Ansible Tester"
|
|
|
|
git add .
|
|
git commit -m "local testing ansible galaxy role"
|
|
git archive \
|
|
--format=tar \
|
|
--prefix="${galaxy_local_test_role}/" \
|
|
master > "${galaxy_local_test_role_tar}"
|
|
popd # "${galaxy_local_test_role}"
|
|
popd # "${galaxy_local_test_role_dir}"
|
|
|
|
# Status message function (f_ to designate that it's a function)
|
|
f_ansible_galaxy_status()
|
|
{
|
|
printf "\n\n\n### Testing ansible-galaxy: %s\n" "${@}"
|
|
}
|
|
|
|
# Galaxy install test case
|
|
#
|
|
# Install local git repo
|
|
f_ansible_galaxy_status "install of local git repo"
|
|
galaxy_testdir=$(mktemp -d)
|
|
pushd "${galaxy_testdir}"
|
|
|
|
ansible-galaxy install git+file:///"${galaxy_local_test_role_git_repo}" "$@"
|
|
|
|
# Test that the role was installed to the expected directory
|
|
[[ -d "${HOME}/.ansible/roles/${galaxy_local_test_role}" ]]
|
|
popd # ${galaxy_testdir}
|
|
rm -fr "${galaxy_testdir}"
|
|
|
|
# Galaxy install test case
|
|
#
|
|
# Install local git repo and ensure that if a role_path is passed, it is in fact used
|
|
f_ansible_galaxy_status "install of local git repo with -p \$role_path"
|
|
galaxy_testdir=$(mktemp -d)
|
|
pushd "${galaxy_testdir}"
|
|
mkdir -p "${galaxy_relative_rolespath}"
|
|
|
|
ansible-galaxy install git+file:///"${galaxy_local_test_role_git_repo}" -p "${galaxy_relative_rolespath}" "$@"
|
|
|
|
# Test that the role was installed to the expected directory
|
|
[[ -d "${galaxy_relative_rolespath}/${galaxy_local_test_role}" ]]
|
|
popd # ${galaxy_testdir}
|
|
rm -fr "${galaxy_testdir}"
|
|
|
|
# Galaxy install test case
|
|
#
|
|
# Ensure that if both a role_file and role_path is provided, they are both
|
|
# honored
|
|
#
|
|
# Protect against regression (GitHub Issue #35217)
|
|
# https://github.com/ansible/ansible/issues/35217
|
|
|
|
f_ansible_galaxy_status \
|
|
"install of local git repo and local tarball with -p \$role_path and -r \$role_file" \
|
|
"Protect against regression (Issue #35217)"
|
|
galaxy_testdir=$(mktemp -d)
|
|
pushd "${galaxy_testdir}"
|
|
|
|
git clone "${galaxy_local_test_role_git_repo}" "${galaxy_local_test_role}"
|
|
ansible-galaxy init roles-path-bug "$@"
|
|
pushd roles-path-bug
|
|
cat <<EOF > ansible.cfg
|
|
[defaults]
|
|
roles_path = ../:../../:../roles:roles/
|
|
EOF
|
|
cat <<EOF > requirements.yml
|
|
---
|
|
- src: ${galaxy_local_test_role_tar}
|
|
name: ${galaxy_local_test_role}
|
|
EOF
|
|
|
|
ansible-galaxy install -r requirements.yml -p roles/ "$@"
|
|
popd # roles-path-bug
|
|
|
|
# Test that the role was installed to the expected directory
|
|
[[ -d "${galaxy_testdir}/roles-path-bug/roles/${galaxy_local_test_role}" ]]
|
|
|
|
popd # ${galaxy_testdir}
|
|
rm -fr "${galaxy_testdir}"
|
|
|
|
#################################
|
|
# ansible-galaxy collection tests
|
|
#################################
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection init tests to make sure the relative dir logic works"
|
|
galaxy_testdir=$(mktemp -d)
|
|
pushd "${galaxy_testdir}"
|
|
|
|
ansible-galaxy collection init ansible_test.my_collection "$@"
|
|
|
|
# Test that the collection skeleton was created in the expected directory
|
|
for galaxy_collection_dir in "docs" "plugins" "roles"
|
|
do
|
|
[[ -d "${galaxy_testdir}/ansible_test/my_collection/${galaxy_collection_dir}" ]]
|
|
done
|
|
|
|
popd # ${galaxy_testdir}
|
|
rm -fr "${galaxy_testdir}"
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection init tests to make sure the --init-path logic works"
|
|
galaxy_testdir=$(mktemp -d)
|
|
pushd "${galaxy_testdir}"
|
|
|
|
ansible-galaxy collection init ansible_test.my_collection --init-path "${galaxy_testdir}/test" "$@"
|
|
|
|
# Test that the collection skeleton was created in the expected directory
|
|
for galaxy_collection_dir in "docs" "plugins" "roles"
|
|
do
|
|
[[ -d "${galaxy_testdir}/test/ansible_test/my_collection/${galaxy_collection_dir}" ]]
|
|
done
|
|
|
|
popd # ${galaxy_testdir}
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection build test creating artifact in current directory"
|
|
|
|
pushd "${galaxy_testdir}/test/ansible_test/my_collection"
|
|
|
|
ansible-galaxy collection build "$@"
|
|
|
|
[[ -f "${galaxy_testdir}/test/ansible_test/my_collection/ansible_test-my_collection-1.0.0.tar.gz" ]]
|
|
|
|
popd # ${galaxy_testdir}/ansible_test/my_collection
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection build test to make sure we can specify a relative path"
|
|
|
|
pushd "${galaxy_testdir}"
|
|
|
|
ansible-galaxy collection build "test/ansible_test/my_collection" "$@"
|
|
|
|
[[ -f "${galaxy_testdir}/ansible_test-my_collection-1.0.0.tar.gz" ]]
|
|
|
|
# Make sure --force works
|
|
ansible-galaxy collection build "test/ansible_test/my_collection" --force "$@"
|
|
|
|
[[ -f "${galaxy_testdir}/ansible_test-my_collection-1.0.0.tar.gz" ]]
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection install from local tarball test"
|
|
|
|
ansible-galaxy collection install "ansible_test-my_collection-1.0.0.tar.gz" -p ./install "$@" | tee out.txt
|
|
|
|
[[ -f "${galaxy_testdir}/install/ansible_collections/ansible_test/my_collection/MANIFEST.json" ]]
|
|
grep "Installing 'ansible_test.my_collection:1.0.0' to .*" out.txt
|
|
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection install with existing collection and without --force"
|
|
|
|
ansible-galaxy collection install "ansible_test-my_collection-1.0.0.tar.gz" -p ./install "$@" | tee out.txt
|
|
|
|
[[ -f "${galaxy_testdir}/install/ansible_collections/ansible_test/my_collection/MANIFEST.json" ]]
|
|
grep "Skipping 'ansible_test.my_collection' as it is already installed" out.txt
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection install with existing collection and with --force"
|
|
|
|
ansible-galaxy collection install "ansible_test-my_collection-1.0.0.tar.gz" -p ./install --force "$@" | tee out.txt
|
|
|
|
[[ -f "${galaxy_testdir}/install/ansible_collections/ansible_test/my_collection/MANIFEST.json" ]]
|
|
grep "Installing 'ansible_test.my_collection:1.0.0' to .*" out.txt
|
|
|
|
f_ansible_galaxy_status \
|
|
"ansible-galaxy with a sever list with an undefined URL"
|
|
|
|
ANSIBLE_GALAXY_SERVER_LIST=undefined ansible-galaxy collection install "ansible_test-my_collection-1.0.0.tar.gz" -p ./install --force "$@" 2>&1 | tee out.txt || echo "expected failure"
|
|
|
|
grep "No setting was provided for required configuration plugin_type: galaxy_server plugin: undefined setting: url" out.txt
|
|
|
|
f_ansible_galaxy_status \
|
|
"ansible-galaxy with an empty server list"
|
|
|
|
ANSIBLE_GALAXY_SERVER_LIST='' ansible-galaxy collection install "ansible_test-my_collection-1.0.0.tar.gz" -p ./install --force "$@" | tee out.txt
|
|
|
|
[[ -f "${galaxy_testdir}/install/ansible_collections/ansible_test/my_collection/MANIFEST.json" ]]
|
|
grep "Installing 'ansible_test.my_collection:1.0.0' to .*" out.txt
|
|
|
|
|
|
## ansible-galaxy collection list tests
|
|
|
|
# Create more collections and put them in various places
|
|
f_ansible_galaxy_status \
|
|
"setting up for collection list tests"
|
|
|
|
rm -rf ansible_test/* install/*
|
|
|
|
NAMES=(zoo museum airport)
|
|
for n in "${NAMES[@]}"; do
|
|
ansible-galaxy collection init "ansible_test.$n"
|
|
ansible-galaxy collection build "ansible_test/$n"
|
|
done
|
|
|
|
ansible-galaxy collection install ansible_test-zoo-1.0.0.tar.gz
|
|
ansible-galaxy collection install ansible_test-museum-1.0.0.tar.gz -p ./install
|
|
ansible-galaxy collection install ansible_test-airport-1.0.0.tar.gz -p ./local
|
|
|
|
# Change the collection version and install to another location
|
|
sed -i -e 's#^version:.*#version: 2.5.0#' ansible_test/zoo/galaxy.yml
|
|
ansible-galaxy collection build ansible_test/zoo
|
|
ansible-galaxy collection install ansible_test-zoo-2.5.0.tar.gz -p ./local
|
|
|
|
export ANSIBLE_COLLECTIONS_PATHS=~/.ansible/collections:${galaxy_testdir}/local
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list all collections"
|
|
|
|
ansible-galaxy collection list -p ./install | tee out.txt
|
|
|
|
[[ $(grep -c ansible_test out.txt) -eq 4 ]]
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list specific collection"
|
|
|
|
ansible-galaxy collection list -p ./install ansible_test.airport | tee out.txt
|
|
|
|
[[ $(grep -c 'ansible_test\.airport' out.txt) -eq 1 ]]
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list specific collection found in multiple places"
|
|
|
|
ansible-galaxy collection list -p ./install ansible_test.zoo | tee out.txt
|
|
|
|
[[ $(grep -c 'ansible_test\.zoo' out.txt) -eq 2 ]]
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list all with duplicate paths"
|
|
|
|
ansible-galaxy collection list -p ~/.ansible/collections | tee out.txt
|
|
|
|
[[ $(grep -c '# /root/.ansible/collections/ansible_collections' out.txt) -eq 1 ]]
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list invalid collection name"
|
|
|
|
ansible-galaxy collection list -p ./install dirty.wraughten.name "$@" 2>&1 | tee out.txt || echo "expected failure"
|
|
|
|
grep 'ERROR! Invalid collection name' out.txt
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list path not found"
|
|
|
|
ansible-galaxy collection list -p ./nope "$@" 2>&1 | tee out.txt || echo "expected failure"
|
|
|
|
grep '\[WARNING\]: - the configured path' out.txt
|
|
|
|
f_ansible_galaxy_status \
|
|
"collection list missing ansible_collections dir inside path"
|
|
|
|
mkdir emptydir
|
|
|
|
ansible-galaxy collection list -p ./emptydir "$@"
|
|
|
|
rmdir emptydir
|
|
|
|
unset ANSIBLE_COLLECTIONS_PATHS
|
|
|
|
## end ansible-galaxy collection list
|
|
|
|
|
|
popd # ${galaxy_testdir}
|
|
|
|
rm -fr "${galaxy_testdir}"
|
|
|
|
rm -fr "${galaxy_local_test_role_dir}"
|