cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
ansible/test
History
willthames 377bc31311 Prevent premature substitution of variables into tasks 
As documented in #2623, early variable substitution causes when_
tests to fail and possibly other side effects.

I can see the reason for this early substitution, likely introduced
in 1dfe60a6, to allow many playbook parameters to be templated.
This is a valid goal, but the recursive nature of the utils.template
function means that it goes too far.

At this point removing tasks from the list of parameters to be
substituted seems sufficient to make my tests pass. It may be the
case that other parameters should be excluded, but I suspect not.

Adding a test case. I would prefer to analyse not just the aggregate
statistics but also whether the results are as expected - I can't
see an easy way to do that with the available callbacks at present.
2013-04-12 09:17:03 +10:00
..
assemble.d - Makefile now works with freebsd (date command options are diff) 2012-08-29 09:46:05 -04:00
inventory_dir Add some tests for directory-based inventory 2013-03-01 23:34:14 +01:00
test_playbook_vars Always load group_vars and host_vars. 2012-08-13 21:08:05 -07:00
ansible.cfg Fixed tests to reflect desired configuration behaviour 2012-10-18 12:53:30 +10:00
ansible_hosts - Makefile now works with freebsd (date command options are diff) 2012-08-29 09:46:05 -04:00
apt_key.gpg add apt_key module 2013-01-15 17:34:38 -08:00
CentOS.yml Allow conditional imports, see examples/playbook3.yml comments for a full explanation. Extensive 2012-03-19 22:42:31 -04:00
common_vars.yml Fix correct variable expansion in includes only_if. 2012-05-11 15:55:33 +02:00
complex_hosts Merge pull request #1776 from junegunn/inventory-group-var-ws 2012-12-17 16:51:49 -08:00
cron_test.yml Cron module upgrades 2013-02-09 11:11:19 -05:00
default_os.yml Allow conditional imports, see examples/playbook3.yml comments for a full explanation. Extensive 2012-03-19 22:42:31 -04:00
hosts_list.yml Make tests use the local connection type, fix missing callback in tests. 2012-11-19 10:30:30 -05:00
inventory_api.py Return multiple groups from inventory API. 2012-10-10 18:35:45 +02:00
jinja2_overrides.tpl moved override matching string to variable changed test template to match Signed-off-by: Brian Coca <briancoca+ansible@gmail.com> 2012-11-26 10:41:13 -05:00
large_range Alphabetic inventory hostname patterns. 2012-12-10 20:48:38 -06:00
lookup_plugins.yml password lookup plugin, with working tests and documentation 2013-03-10 13:36:53 +11:00
playbook-included.yml Make use of yes/no booleans in playbooks 2012-12-14 11:56:53 +01:00
playbook-includer.yml Since we removed the (undocumented) playbook include + with_items code, fix the tests to 2013-04-10 15:08:18 -04:00
playbook-when.yml Prevent premature substitution of variables into tasks 2013-04-12 09:17:03 +10:00
playbook1.yml Preliminary ability to use Jinja2 {{ }} to replace ${foo.bar} in playbooks. Can't use both at the same time per line. 2013-04-03 01:04:16 -04:00
results_list.yml Make tests use the local connection type, fix missing callback in tests. 2012-11-19 10:30:30 -05:00
rocannon.txt Added test cases for lineinfile. 2013-02-23 12:50:18 -05:00
sample.j2 Fixing bug with unicode templates. 2013-02-05 14:49:59 +01:00
simple_hosts Alphabetic inventory hostname patterns. 2012-12-10 20:48:38 -06:00
task-included.yml Test case and fix for shlex.split unicode bug 2013-04-08 14:47:43 +10:00
task-includer.yml Test case and fix for shlex.split unicode bug 2013-04-08 14:47:43 +10:00
template-basic Update tests to reflect new API 2012-06-18 00:13:12 +02:00
template-whitespace Update tests to reflect new API 2012-06-18 00:13:12 +02:00
TestConstants.py Fixed tests to reflect desired configuration behaviour 2012-10-18 12:53:30 +10:00
TestFilters.py Disable filter test for now since it should really be testing at a lower level. 2013-03-01 17:42:14 -05:00
TestInventory.py Standardize test output 2013-04-05 13:13:33 -04:00
TestPlayBook.py Prevent premature substitution of variables into tasks 2013-04-12 09:17:03 +10:00
TestRunner.py Add code to flag legacy templating like $foo.{bar} as deprecated in favor of Jinja2 {{ foo.bar }} so we 2013-04-10 17:52:35 -04:00
TestUtils.py Some continued work on new-style templates and associated test code changes. Legacy template functions 2013-04-10 19:09:57 -04:00
world Add test data file 2012-09-17 18:31:49 +02:00