ansible/test/sanity/code-smell/no-get-exception.py
Matt Clay 5d7cc993dd
Clean up sanity test ignore handling. (#59749)
* Allow sanity tests to easily ignore themselves.

Useful for simple regex based sanity tests that error on their own script due to the regex or error message generated.

* Simplify no-smart-quotes sanity test.

Pruning of unversioned directories is handled by ansible-test.

* Remove directory pruning from boilerplate tests.

Files not passing these tests should be ignored instead.

* Add missing sanity ignore entries.
2019-07-29 14:37:44 -07:00

28 lines
926 B
Python
Executable file

#!/usr/bin/env python
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import re
import sys
def main():
basic_allow_once = True
for path in sys.argv[1:] or sys.stdin.read().splitlines():
with open(path, 'r') as path_fd:
for line, text in enumerate(path_fd.readlines()):
match = re.search(r'([^a-zA-Z0-9_]get_exception[^a-zA-Z0-9_])', text)
if match:
if path == 'lib/ansible/module_utils/basic.py' and basic_allow_once:
# basic.py is allowed to import get_exception for backwards compatibility but should not call it anywhere
basic_allow_once = False
continue
print('%s:%d:%d: do not use `get_exception`' % (
path, line + 1, match.start(1) + 1))
if __name__ == '__main__':
main()