2016-06-25 04:11:56 +02:00
|
|
|
author: Hemant
|
|
|
|
> Hemant: "SLAs" for pull requests
|
|
|
|
> ALWAYS point to documents when critiquing PRs
|
|
|
|
> this should also include the blackbox of Windows/STEX testing
|
|
|
|
> time can totally be wishy-washy here
|
|
|
|
> "some tests we can only run internally"
|
|
|
|
> exact timeline not need for Aug17
|
|
|
|
> Windows quality gates
|
2016-07-11 18:42:22 +02:00
|
|
|
|
|
|
|
## Minimum gates (TODO)
|
|
|
|
|
|
|
|
Our [pull request template][pr-template] includes the bare minimum requirements for a pull request to be accepted into PowerShell. This includes:
|
|
|
|
* Writing tests
|
|
|
|
* Writing documentation (where does thie one live already? is it where this guidance should exist all up?)
|
|
|
|
* Our [code review process][code-review]
|
|
|
|
* Repository maintainer sign-off, per our [governance model][governance]
|
|
|
|
|
|
|
|
[pr-template]: ../.github/PULL_REQUEST_TEMPLATE.md
|
|
|
|
[code-review]: code-review-guidelines.md
|
|
|
|
[governance]: ../community/governance.md
|