maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Avoid unnecessary StringCollection allocation in formatting code (#15832)

Browse source
This commit is contained in:
xtqqczze 2021-07-27 19:18:53 +01:00 committed by GitHub
parent 5e15f66f97
commit 3733a0bb37
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/System.Management.Automation/FormatAndOutput/common/BaseOutputtingCommand.cs
View file

@ -3,7 +3,6 @@
using System;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.Management.Automation;
using System.Management.Automation.Internal;
@ -1117,33 +1116,40 @@ namespace Microsoft.PowerShell.Commands.Internal.Format
internal static string[] GetProperties(ListViewEntry lve)
{
StringCollection props = new StringCollection();
foreach (ListViewField lvf in lve.listViewFieldList)
int count = lve.listViewFieldList.Count;
if (count == 0)
{
props.Add(lvf.label ?? lvf.propertyName);
return null;
}
if (props.Count == 0)
return null;
string[] retVal = new string[props.Count];
props.CopyTo(retVal, 0);
return retVal;
string[] result = new string[count];
for (int index = 0; index < result.Length; ++index)
{
ListViewField lvf = lve.listViewFieldList[index];
result[index] = lvf.label ?? lvf.propertyName;
}
return result;
}
internal static string[] GetValues(ListViewEntry lve)
{
StringCollection vals = new StringCollection();
int count = lve.listViewFieldList.Count;
foreach (ListViewField lvf in lve.listViewFieldList)
if (count == 0)
{
vals.Add(lvf.formatPropertyField.propertyValue);
return null;
}
if (vals.Count == 0)
return null;
string[] retVal = new string[vals.Count];
vals.CopyTo(retVal, 0);
return retVal;
string[] result = new string[count];
for (int index = 0; index < result.Length; ++index)
{
ListViewField lvf = lve.listViewFieldList[index];
result[index] = lvf.formatPropertyField.propertyValue;
}
return result;
}
/// <summary>