From 5da825bdb164794b75b2da77d16bbd404ad45dc3 Mon Sep 17 00:00:00 2001
From: Christopher Ubben <chubben@microsoft.com>
Date: Wed, 5 Oct 2016 14:46:52 -0700
Subject: [PATCH] Added feature level test coverage to Alias provider (#2419)

---
 .../Alias.Tests.ps1                           | 99 ++++++++++++++-----
 1 file changed, 77 insertions(+), 22 deletions(-)

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Alias.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Alias.Tests.ps1
index e15893134..5bec99050 100644
--- a/test/powershell/Modules/Microsoft.PowerShell.Management/Alias.Tests.ps1
+++ b/test/powershell/Modules/Microsoft.PowerShell.Management/Alias.Tests.ps1
@@ -1,55 +1,110 @@
-Describe "Basic Validation of Alias Provider" -Tags "CI" {
+Describe "Basic Alias Provider Tests" -Tags "CI" {
     BeforeAll {
-        $testAliasName = 'TestAlias'
-        $testAliasValue = 'Get-Date'
+        $testAliasName = "TestAlias"
+        $testAliasValue = "Get-Date"
     }
 
     BeforeEach {
-        New-Item -Path Alias:\ -Name $testAliasName -Value $testAliasValue > $null
+        New-Item -Path "Alias:\" -Name $testAliasName -Value $testAliasValue > $null
     }
 
     AfterEach {
-        Remove-Item -Path "Alias:\${testAliasName}" -ErrorAction SilentlyContinue
+        Remove-Item -Path "Alias:\${testAliasName}" -Force -ErrorAction SilentlyContinue
     }
-    
+
     It "Test number of alias not Zero" {
-        $aliases = Get-ChildItem Alias:\
+        $aliases = @(Get-ChildItem "Alias:\")
         $aliases.Count | Should Not Be 0
     }
 
-    It "Test alias 'dir'" {
-        $dirAlias = Get-Item Alias:\dir
-        $dirAlias.CommandType | Should Be 'Alias'
-        $dirAlias.Name | Should Be 'dir'
-        $dirAlias.Definition | Should Be 'Get-ChildItem'
+    It "Test alias dir" {
+        $dirAlias = Get-Item "Alias:\dir"
+        $dirAlias.CommandType | Should Be "Alias"
+        $dirAlias.Name | Should Be "dir"
+        $dirAlias.Definition | Should Be "Get-ChildItem"
     }
 
     It "Test creating new alias" {
-        $newAlias = New-Item -Path Alias:\ -Name 'NewTestAlias' -Value $testAliasValue
         try {
-            $newAlias.CommandType | Should Be 'Alias'
-            $newAlias.Name | Should Be 'NewTestAlias'
+            $newAlias = New-Item -Path "Alias:\" -Name "NewTestAlias" -Value $testAliasValue
+            $newAlias.CommandType | Should Be "Alias"
+            $newAlias.Name | Should Be "NewTestAlias"
             $newAlias.Definition | Should Be $testAliasValue
         }
         finally {
-            Remove-Item -Path 'Alias:\NewTestAlias' -ErrorAction SilentlyContinue
+            Remove-Item -Path "Alias:\NewTestAlias" -Force -ErrorAction SilentlyContinue
         }
     }
 
-    It "Test get-item on alias provider" {
+    It "Test Get-Item on alias provider" {
         $alias = Get-Item -Path "Alias:\${testAliasName}"
-        $alias.CommandType | Should Be 'Alias'
+        $alias.CommandType | Should Be "Alias"
         $alias.Name | Should Be $testAliasName
         $alias.Definition | Should Be $testAliasValue
     }
 
-    It "Test test-path on alias provider" {
-        $aliasExists = Test-Path Alias:\testAlias
+    It "Test Test-Path on alias provider" {
+        $aliasExists = Test-Path "Alias:\testAlias"
         $aliasExists | Should Be $true
     }
 
     It "Test executing the new alias" {
-        $result = testAlias
-        $result.GetType().Name | Should Be 'DateTime'
+        $result = Invoke-Expression $testAliasName
+        $result.GetType().Name | Should Be "DateTime"
+    }
+}
+
+Describe "Extended Alias Provider Tests" -Tags "Feature" {
+    Context "Valdiation of Set-Item parameters for the Alias Provider" {
+        BeforeAll {
+            $testAliasName = "TestAlias"
+            $testAliasName2 = "TestAlias2"
+            $testAliasValue = "Get-Date"
+        }
+
+        BeforeEach {
+            New-Item -Path Alias:\ -Name $testAliasName -Value $testAliasValue > $null
+            New-Item -Path Alias:\ -Name $testAliasName2 -Value $testAliasValue > $null
+        }
+
+        AfterEach {
+            Remove-Item -Path "Alias:\${testAliasName}" -Force -ErrorAction SilentlyContinue
+            Remove-Item -Path "Alias:\${testAliasName2}" -Force -ErrorAction SilentlyContinue
+        }
+
+        It "Verifying Whatif" {
+            $before = (Get-Item -Path "Alias:\${testAliasName}").Definition
+            Set-Item -Path "Alias:\${testAliasName}" -Value "Get-Location" -Whatif
+            $after = (Get-Item -Path "Alias:\${testAliasName}").Definition
+            $after | Should Be $before # Definition should not have changed
+        }
+
+        It "Verifying Confirm can be bypassed" {
+            Set-Item -Path "Alias:\${testAliasName}" -Value "Get-Location" -Confirm:$false
+            $result = Get-Item -Path "Alias:\${testAliasName}"
+            $result.Definition | Should Be "Get-Location"
+        }
+
+        It "Verifying Force" {
+            Set-Item -Path "Alias:\${testAliasName}" -Value "Get-Location" -Force
+            $result =  Get-Item -Path "Alias:\${testAliasName}"
+            $result.Definition | Should Be "Get-Location"
+        }
+
+        It "Verifying Include" {
+            Set-Item -Path "Alias:\*" -Value "Get-Location" -Include "TestAlias*"
+            $alias1 = Get-Item -Path "Alias:\${testAliasName}"
+            $alias2 = Get-Item -Path "Alias:\${testAliasName2}"
+            $alias1.Definition | Should Be "Get-Location"
+            $alias2.Definition | Should Be "Get-Location"
+        }
+
+        It "Verifying Exclude" {
+            Set-Item -Path "Alias:\TestAlias*" -Value "Get-Location" -Exclude "*2"
+            $alias1 = Get-Item -Path "Alias:\${testAliasName}"
+            $alias2 = Get-Item -Path "Alias:\${testAliasName2}"
+            $alias1.Definition | Should Be "Get-Location"
+            $alias2.Definition | Should Be "Get-Date"
+        }
     }
 }