maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix splatting being treated as positional parameter (#14623)

Browse source
This commit is contained in:
MartinGC94 2021-06-16 01:56:14 +02:00 committed by GitHub
parent eeabbe7f21
commit 77054ff586
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
View file

@ -1862,6 +1862,13 @@ namespace System.Management.Automation.Language
while (unboundArgumentsIndex < unboundArgumentsCollection.Count)
{
AstParameterArgumentPair argument = unboundArgumentsCollection[unboundArgumentsIndex++];
if (argument is AstPair astPair
&& astPair.Argument is VariableExpressionAst argumentVariable
&& argumentVariable.Splatted)
{
continue;
}
if (!argument.ParameterSpecified)
{
result = argument;

7
test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
View file

@ -1022,6 +1022,13 @@ dir -Recurse `
$res.CompletionMatches | Should -HaveCount 4
[string]::Join(',', ($res.CompletionMatches.completiontext | Sort-Object)) | Should -BeExactly "-wa,-Wait,-WarningAction,-WarningVariable"
}
It "Test completion with splatted variable" {
$inputStr = 'Get-Content @Splat -P'
$res = TabExpansion2 -inputScript $inputStr -cursorColumn $inputStr.Length
$res.CompletionMatches | Should -HaveCount 4
[string]::Join(',', ($res.CompletionMatches.completiontext | Sort-Object)) | Should -BeExactly "-Path,-PipelineVariable,-PSPath,-pv"
}
}
Context "Module completion for 'using module'" {