Try Assembly.Load correctly
This should resolve #791. Instead of checking if `Assembly.Load` returned null (it doesn't), check if it threw `FileNotFoundException`, which it will if it doesn't find the assembly.
This commit is contained in:
parent
80b15f64e2
commit
839014b599
1 changed files with 12 additions and 7 deletions
|
@ -186,10 +186,12 @@ namespace System.Management.Automation
|
|||
|
||||
// Try loading it from the TPA list. All PowerShell dependencies are in the
|
||||
// TPA list when published with dotnet-cli.
|
||||
try
|
||||
{
|
||||
asmLoaded = Assembly.Load(assemblyName);
|
||||
|
||||
}
|
||||
// If it wasn't there, try loading from path
|
||||
if (asmLoaded == null)
|
||||
catch (FileNotFoundException)
|
||||
{
|
||||
asmLoaded = asmFilePath.EndsWith(".ni.dll", StringComparison.OrdinalIgnoreCase)
|
||||
? LoadFromNativeImagePath(asmFilePath, null)
|
||||
|
@ -250,9 +252,12 @@ namespace System.Management.Automation
|
|||
|
||||
// Try loading it from the TPA list. All PowerShell dependencies are in the
|
||||
// TPA list when published with dotnet-cli.
|
||||
try
|
||||
{
|
||||
asmLoaded = Assembly.Load(assemblyName);
|
||||
|
||||
if (asmLoaded == null)
|
||||
}
|
||||
// If it wasn't there, try loading from path
|
||||
catch (FileNotFoundException)
|
||||
{
|
||||
// Load the assembly through 'LoadFromNativeImagePath' or 'LoadFromAssemblyPath'
|
||||
asmLoaded = assemblyPath.EndsWith(".ni.dll", StringComparison.OrdinalIgnoreCase)
|
||||
|
|
Loading…
Reference in a new issue