maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Specify exe path as TargetObect for non-zero exit code ErrorRecord (#16108)

Browse source
This commit is contained in:
Keith Hill 2021-10-14 15:47:54 -06:00 committed by GitHub
parent 9a63f412ef
commit b94dd91e74
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/System.Management.Automation/engine/NativeCommandProcessor.cs
View file

@ -884,7 +884,7 @@ namespace System.Management.Automation
errorMsg,
errorId);
var errorRecord = new ErrorRecord(exception, errorId, ErrorCategory.NotSpecified, targetObject: NativeCommandName);
var errorRecord = new ErrorRecord(exception, errorId, ErrorCategory.NotSpecified, targetObject: Path);
this.commandRuntime._WriteErrorSkipAllowCheck(errorRecord);
}
}

9
test/powershell/engine/Basic/NativeCommandErrorHandling.Tests.ps1
View file

@ -14,6 +14,7 @@ Describe 'Native command error handling tests' -Tags 'CI' {
}
$exeName = $IsWindows ? 'testexe.exe' : 'testexe'
$exePath = @(Get-Command $exeName -Type Application)[0].Path
$errorActionPrefTestCases = @(
@{ ErrorActionPref = 'Stop' }
@ -43,7 +44,7 @@ Describe 'Native command error handling tests' -Tags 'CI' {
$error.Count | Should -Be 1
$error[0].FullyQualifiedErrorId | Should -BeExactly 'ProgramExitedWithNonZeroCode'
$error[0].TargetObject | Should -BeExactly $exeName
$error[0].TargetObject | Should -BeExactly $exePath
}
It 'Non-zero exit code outputs a non-teminating error for $ErrorActionPreference = ''Continue''' {
@ -52,7 +53,7 @@ Describe 'Native command error handling tests' -Tags 'CI' {
$stderr = testexe -returncode 1 2>&1
$error[0].FullyQualifiedErrorId | Should -BeExactly 'ProgramExitedWithNonZeroCode'
$error[0].TargetObject | Should -BeExactly $exeName
$error[0].TargetObject | Should -BeExactly $exePath
$stderr[1].Exception.Message | Should -BeExactly "Program `"$exeName`" ended with non-zero exit code: 1."
}
@ -65,7 +66,7 @@ Describe 'Native command error handling tests' -Tags 'CI' {
$stderr = testexe -returncode 1 2>&1
$error[0].FullyQualifiedErrorId | Should -BeExactly 'ProgramExitedWithNonZeroCode'
$error[0].TargetObject | Should -BeExactly $exeName
$error[0].TargetObject | Should -BeExactly $exePath
$stderr[1].Exception.Message | Should -BeExactly "Program `"$exeName`" ended with non-zero exit code: 1."
}
@ -76,7 +77,7 @@ Describe 'Native command error handling tests' -Tags 'CI' {
$error.Count | Should -Be 1
$error[0].FullyQualifiedErrorId | Should -BeExactly 'ProgramExitedWithNonZeroCode'
$error[0].TargetObject | Should -BeExactly $exeName
$error[0].TargetObject | Should -BeExactly $exePath
}
It 'Non-zero exit code does not generates an error record for $ErrorActionPreference = ''Ignore''' {