maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use LOGIN_NAME_MAX instead of L_cuserid

Browse source 
Since L_cuserid is only for cuserid, not getlogin_r

Unit test for L_cuserid removed because the macro may not be available
on all platforms.
This commit is contained in:
Andrew Schwartzmeyer 2015-07-22 16:04:11 -07:00
parent e2d4ce0ab1
commit bb8d0b793e
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/impl/getusername.cpp
View file

@ -43,8 +43,8 @@ BOOL GetUserName(WCHAR_T *lpBuffer, LPDWORD lpnSize)
}
// Get username from system in a thread-safe manner
char userName[L_cuserid];
int err = getlogin_r(userName, L_cuserid);
char userName[LOGIN_NAME_MAX];
int err = getlogin_r(userName, LOGIN_NAME_MAX);
// Map errno to Win32 Error Codes
if (err != 0) {
switch (errno) {

6
src/tests/test-getusername.cpp
View file

@ -114,8 +114,8 @@ TEST_F(GetUserNameTest, BufferSizeAsUserNamePlusOne) {
TestSuccess();
}
TEST_F(GetUserNameTest, L_cuseridSize) {
// L_cuserid is big enough to hold any username
TestWithSize(L_cuserid);
TEST_F(GetUserNameTest, BufferSizeAsLoginNameMax) {
// LoginNameMax is big enough to hold any username
TestWithSize(LOGIN_NAME_MAX);
TestSuccess();
}