maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Update 'CommandNotFound' fuzzy suggestion to only return unique results (#8640)

Browse source
This commit is contained in:
Steve Lee 2019-01-14 14:28:15 -08:00 committed by Dongbo Wang
parent 812456f84c
commit c3cb6df809
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/System.Management.Automation/engine/hostifaces/HostUtilities.cs
View file

@ -68,7 +68,7 @@ namespace System.Management.Automation
[System.Diagnostics.DebuggerHidden()] [System.Diagnostics.DebuggerHidden()]
param([string] $formatString) param([string] $formatString)
$formatString -f [string]::Join(', ', (Get-Command $lastError.TargetObject -UseFuzzyMatch | Select-Object -First 10 -ExpandProperty Name)) $formatString -f [string]::Join(', ', (Get-Command $lastError.TargetObject -UseFuzzyMatch | Select-Object -First 10 -Unique -ExpandProperty Name))
"; ";
private static ArrayList s_suggestions = new ArrayList( private static ArrayList s_suggestions = new ArrayList(

11
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1
View file

@ -1,7 +1,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved. # Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. # Licensed under the MIT License.
Describe "Get-Command CI tests" -Tag Feature { Describe "Get-Command Feature tests" -Tag Feature {
Context "-UseFuzzyMatch tests" { Context "-UseFuzzyMatch tests" {
It "Should match cmdlets" { It "Should match cmdlets" {
$cmds = Get-Command get-hlp -UseFuzzyMatch $cmds = Get-Command get-hlp -UseFuzzyMatch
@ -10,14 +10,15 @@ Describe "Get-Command CI tests" -Tag Feature {
} }
It "Should match native commands" { It "Should match native commands" {
$ping = "ping" $input = "pwsg"
$expectedcmd = "pwsh"
if ($IsWindows) { if ($IsWindows) {
$ping = "PING.EXE" $expectedcmd = "pwsh.EXE"
} }
$cmds = Get-Command pinh -UseFuzzyMatch $cmds = Get-Command $input -UseFuzzyMatch
$cmds.Count | Should -BeGreaterThan 0 $cmds.Count | Should -BeGreaterThan 0
$cmds.Name | Should -Contain $ping $cmds.Name | Should -Contain $expectedcmd
} }
} }