maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix New-LocalUser cmdlet to roll back user in case of user attributes assignment failure.

Browse source 
Resolving #3242

At this point, user account is created even if user attributes assignment
(like setting password) fails. The cmdlet throws a
non-terminating error but ends up creating the user. This behavior is
confusing. As per the changes, the localuser account will be rolled back
in case of failure in user attributes assignment.
This commit is contained in:
charub 2017-03-03 11:13:42 -08:00 committed by Mike Richmond
parent 44bd923d22
commit d59627f9ae
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/Sam.cs
View file

@ -1271,6 +1271,14 @@ namespace System.Management.Automation.SecurityAccountsManager
},
userHandle);
}
catch (Exception)
{
if (IntPtr.Zero != userHandle)
{
SamApi.SamDeleteUser(userHandle);
}
throw;
}
finally
{
if (buffer != IntPtr.Zero)

11
test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1
View file

@ -348,6 +348,17 @@ try {
VerifyFailingTest $sb "InvalidPassword,Microsoft.PowerShell.Commands.NewLocalUserCommand"
}
It "User should not be created when invalid password is provided" {
$sb = {
New-LocalUser TestUserNew1 -Password (ConvertTo-SecureString ("A"*257) -AsPlainText -Force)
}
VerifyFailingTest $sb "InvalidPassword,Microsoft.PowerShell.Commands.NewLocalUserCommand"
$sb1 = {
Get-LocalUser TestUserNew1
}
VerifyFailingTest $sb1 "UserNotFound,Microsoft.PowerShell.Commands.GetLocalUserCommand"
}
It "Can set UserMayNotChangePassword" {
$result = New-LocalUser TestUserNew1 -NoPassword -UserMayNotChangePassword